|
[EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)
Andrew, I agree with your points. Mike, You’ve got a lot more there. Let me take a look and update the draft. I’ll ping back ASAP. - Bret Sent: Wednesday, December 4, 2019 9:50 AM To: devel@...
Andrew, I agree with your points. Mike, You’ve got a lot more there. Let me take a look and update the draft. I’ll ping back ASAP. - Bret Sent: Wednesday, December 4, 2019 9:50 AM To: devel@...
|
By
...
· #208
·
|
|
[EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)
1. I see that MdePkg adds a dependency on UnitTestPkg. This makes UnitTestPkg the root package when building and running host based unit tests. This makes sense, but good to highlight that all package
1. I see that MdePkg adds a dependency on UnitTestPkg. This makes UnitTestPkg the root package when building and running host based unit tests. This makes sense, but good to highlight that all package
|
By
...
· #209
·
|
|
[EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)
Mike, I think I’ve gotten all the feedback here and all the action items from our call. The current branch should be good to go, minus the couple of things that Intel was going to look into. Thanks! -
Mike, I think I’ve gotten all the feedback here and all the action items from our call. The current branch should be good to go, minus the couple of things that Intel was going to look into. Thanks! -
|
By
...
· #210
·
|
|
[EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)
The host-based tests now build on Linux/GCC, but the final executables don’t seem to get created. Don’t know where the disconnect is there. I can see the test get compiled (along with all the librarie
The host-based tests now build on Linux/GCC, but the final executables don’t seem to get created. Don’t know where the disconnect is there. I can see the test get compiled (along with all the librarie
|
By
...
· #211
·
|
|
[EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)
Did you make sure to stuart_update? It will pull a dependency repo that is only needed for CI. - Bret ________________________________ Sent: Monday, December 16, 2019 2:31:13 PM To: rfc@edk2.groups.io
Did you make sure to stuart_update? It will pull a dependency repo that is only needed for CI. - Bret ________________________________ Sent: Monday, December 16, 2019 2:31:13 PM To: rfc@edk2.groups.io
|
By
...
· #216
·
|
|
[EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)
Yeah, if we don't want to carry Cmocka in edk2, there's a necessary trade off of having to keep a dependency for the host-based tests. You wouldn't need this dependency for a simple shell-based test,
Yeah, if we don't want to carry Cmocka in edk2, there's a necessary trade off of having to keep a dependency for the host-based tests. You wouldn't need this dependency for a simple shell-based test,
|
By
...
· #218
·
|
|
[RFC] VariablePolicy - Protocol, Libraries, and Implementation for VariableLock Alternative
All, VariablePolicy is our proposal for an expanded “VarLock-like” interface to constrain and govern platform variables. I brought this up back in May to get initial comments on the interface and impl
All, VariablePolicy is our proposal for an expanded “VarLock-like” interface to constrain and govern platform variables. I brought this up back in May to get initial comments on the interface and impl
|
By
...
· #233
·
|
|
[RFC] VariablePolicy - Protocol, Libraries, and Implementation for VariableLock Alternative
Expanding the audience beyond the RFC list…. If no one has additional input, I’ll try to start formatting these as patches later this week. Thanks! - Bret Sent: Tuesday, January 28, 2020 5:36 PM To: r
Expanding the audience beyond the RFC list…. If no one has additional input, I’ll try to start formatting these as patches later this week. Thanks! - Bret Sent: Tuesday, January 28, 2020 5:36 PM To: r
|
By
...
· #234
·
|
|
[EXTERNAL] Re: [edk2-devel] [RFC] VariablePolicy - Protocol, Libraries, and Implementation for VariableLock Alternative
Kevin, Agreed and we were sensitive to that in our codebase as well. Surface and other consumers had drivers expecting VarLock and we didn’t want to have to rewrite them all (at least not immediately)
Kevin, Agreed and we were sensitive to that in our codebase as well. Surface and other consumers had drivers expecting VarLock and we didn’t want to have to rewrite them all (at least not immediately)
|
By
...
· #238
·
|
|
[EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
As a counterpoint: if we force a new branch or force push on every tweak, we lose the “thread” of discussion on what caused the change, what changed as a result, and the easy hook for the original cha
As a counterpoint: if we force a new branch or force push on every tweak, we lose the “thread” of discussion on what caused the change, what changed as a result, and the easy hook for the original cha
|
By
...
· #283
·
|
|
[EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I feel like this process is a good compromise. It’s not perfect (frankly, I’m a fan of enforced squash merges, which can maintain bisectability if managed well), but it allows for rapid iteration, eas
I feel like this process is a good compromise. It’s not perfect (frankly, I’m a fan of enforced squash merges, which can maintain bisectability if managed well), but it allows for rapid iteration, eas
|
By
...
· #291
·
|
|
[EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Agreed. Responsibility to verify the commit message when squashing is always something to be aware of. With Github, the one who presses the “Close and Merge” (or whatever it’s called) button has the f
Agreed. Responsibility to verify the commit message when squashing is always something to be aware of. With Github, the one who presses the “Close and Merge” (or whatever it’s called) button has the f
|
By
...
· #293
·
|
|
[EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
“… boundless and bare, The lone and level sands stretch far away.” - Bret Sent: Friday, May 15, 2020 12:34 AM To: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew@micr
“… boundless and bare, The lone and level sands stretch far away.” - Bret Sent: Friday, May 15, 2020 12:34 AM To: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew@micr
|
By
...
· #297
·
|
|
[EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I agree with some of your points, but I don’t believe that this calls for dependencies at all. If a PR can pass CI with the changes, it’s functionally unordered. And if a PR can’t, it has to wait unti
I agree with some of your points, but I don’t believe that this calls for dependencies at all. If a PR can pass CI with the changes, it’s functionally unordered. And if a PR can’t, it has to wait unti
|
By
...
· #298
·
|
|
[edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Nate, I believe you missed Sean’s point. Each one of those packages should have been a separate PR. Ergo, no information would have been lost in the squash. Also, it’s not so much that we *can’t* lear
Nate, I believe you missed Sean’s point. Each one of those packages should have been a separate PR. Ergo, no information would have been lost in the squash. Also, it’s not so much that we *can’t* lear
|
By
...
· #305
·
|
|
[edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I will honor Mike Kinney’s efforts with my vote of confidence. I think we’re headed in the right direction, even with some of the things that I disagree with. In my history with TianoCore, I have lear
I will honor Mike Kinney’s efforts with my vote of confidence. I think we’re headed in the right direction, even with some of the things that I disagree with. In my history with TianoCore, I have lear
|
By
...
· #307
·
|
|
[edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I’ll pour another cup of tea to that. - Bret ________________________________ Sent: Tuesday, May 19, 2020 2:02:49 PM To: rfc@edk2.groups.io <rfc@edk2.groups.io>; Bret Barkelew <Bret.Barkelew@microsoft
I’ll pour another cup of tea to that. - Bret ________________________________ Sent: Tuesday, May 19, 2020 2:02:49 PM To: rfc@edk2.groups.io <rfc@edk2.groups.io>; Bret Barkelew <Bret.Barkelew@microsoft
|
By
...
· #310
·
|
|
[edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Agreed. :) - Bret ________________________________ Sent: Tuesday, May 19, 2020 2:35:37 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; lersek@... <lersek@...>; Bret Barkelew <Bret.Ba
Agreed. :) - Bret ________________________________ Sent: Tuesday, May 19, 2020 2:35:37 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; lersek@... <lersek@...>; Bret Barkelew <Bret.Ba
|
By
...
· #313
·
|
|
[EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
You know what… That’s fair. Apologies to the community. - Bret Sent: Wednesday, May 20, 2020 2:53 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew@microsoft
You know what… That’s fair. Apologies to the community. - Bret Sent: Wednesday, May 20, 2020 2:53 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew@microsoft
|
By
...
· #323
·
|
|
[EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
“But we do have tools that insert the Bugzilla number in all the commits of the series, assist with the squash, etc.” Are these internal-only, or are they something we could evaluate when we move to t
“But we do have tools that insert the Bugzilla number in all the commits of the series, assist with the squash, etc.” Are these internal-only, or are they something we could evaluate when we move to t
|
By
...
· #324
·
|