A version of this Wiki page is also provided here for review: https://github.com/mdkinney/edk2/wiki/EDK-II-Code-First-Process Mike

Hi Artem, We discussed this topic briefly in the EDK II Community meeting this morning With Felix. For the tags topic, I believe the feature being asked for here is a simple way to identify and search

Bret, If the original submission is a single patch, and the code review generates changes that are added as additional patches for review, but the intent in the end is still a single patch, then squas

Hi Bret, This is a good point. What I am proposing is the first version of the patch series submitted as a pull request. Let the community do a complete review of the content. The submitter can add pa

Hi Ray, Comments below. Mike

Hello, I have added the following repository to TianoCore to support the evaluation of the GitHub pull request based code review process and the email archive webbook. This is a copy of tianocore/edk2

Rebecca, I agree that the first version should rerun CI checks on every time commits are added to a PR or there is a forced push to the PR. Perhaps we should use Draft Pull Requests as a way to indica

Rebecca, There is no difference between CI checks run during code review and the final CI checks before merge. I think it is an interesting conversation to decide how many times those CI checks should

Hello, This is a proposal to change from the current email-based code review process to a GitHub pull request-based code review process for all repositories maintained in TianoCore. The current email-

Leif, A few comments included below. Thanks, Mike

Amol, All the APIs are available from BaseCryptLib. I agree that implementations of HashLib on top of other crypto libs would require a different implementation of the library instance and if all the

Amol, Your style requires bigger source changes to exiting modules to switch from BaseCryptLib to HashLib. Your style also required a loop to search for matching API on every call. Mine will optimize

Amol, I would recommend a different set of APIs in the HashLib class. Instead of doing a registration, define a PCD to select the hash type and have the generic HashLib function call the BaseCryptLib

Hi Bret, No. I did not do that step yet. I will try that next. I was just trying to build the new DSC in the MdePkg. The external dependency for a set of simple lib API unit tests in MdePkg was not ex

Hi Bret, I am looking at the latest version of the content on your branch. I am confused by MdePkg/Test/MdePkgTest.dsc. It makes references to lib classes and packages that do not exist. CmockaLib|Cmo

Hi Jiewen, Many of your responses are related to fuzz testing. Can we focus current infrastructure on host based unit testing and minimizing the content to support that testing type. Then, add a new s

Hi Bret, Thanks for posting this content. Host based unit testing is a very valuable addition to the CI checks. I have the following comments: 1. I see that MdePkg adds a dependency on UnitTestPkg. Th

As Sean points out, different components in a platform may have different hash requirements. If we want to go down the path where we have a few modules that produce Protocols/PPIs for the BaseCryptLib

Nate and Amol, There is some work already started by Sean and Matt that implements a PEIM, DXE Driver, and SMM Driver to produce Protocol/PPI that wraps the BaseCryptLib services. This content broken

Hi Sean, For host based tests, I agree that VS2017 or VS2019 would be a good choice. Pick the one with the best coverage and easiest for developers to get feedback on the test results and test coverag