[RFC] EdkRepo - The Multi-Repository Tool for EDK II
Hi All,
This RFC is raised to add EdkRepo, the multi-repository tool for EDK II firmware development to TianoCore. EdkRepo is built on top of git. It is intended to automate common developer workflows for projects that use more than one git repository. For example many of the new projects in the edk2-platforms repository require the user to clone several git repositories. EdkRepo makes it easier to set up and upstream changes for these projects. EdkRepo does not replace git, rather it provides higher level extensions that make it easier to work with git. EdkRepo uses "manifest XML" files to describe the git repositories and EDK II packages that a project uses. EdkRepo is aware of the DSC file format and is able to combine this XML with metadata from DSC files to create a development experience tailored specifically for EDK II firmware development. EdkRepo is written in Python and is compatible with Python 3.5 or later. EdkRepo has been internally developed at Intel for 2.5 years. EdkRepo was originally created to support our own product development. With the recent release of MinPlatformPkg, the number of complete open source UEFI firmware implementations available at TianoCore has been growing rapidly. We see that many of the development workflows we encounter for our product work now apply more broadly to the TianoCore community. Accordingly, we would like to open EdkRepo to community. We see this process going through several phases. First, we provide an initial commit of EdkRepo via edk2-staging. We envision two branches being added to edk2-staging: 1. EdkRepo - Contains the source code for the EdkRepo tool. 2. EdkRepo-Manifest - Contains an initial set of example manifest files which can be used to try EdkRepo I will send out patches to create these two branches shortly. After these branches are created, we will send a series of commits to populate the first open source version of EdkRepo. At this point the community can take a look and provide feedback. There are several options for where the final location where this tool might live: 1. edk2-platforms 2. edk2-pytool-library 3. The edk2-toolenv repository proposed by Sean (assuming approval of Sean's RFC) 4. A new, separate repository created for EdkRepo In addition, we recommend that a new TianoCore owned repository be created to host the manifest XML content. The initial proposed maintainer list for EdkRepo is: M: Nate DeSimone <nathaniel.l.desimone@...> M: Ashley DeSimone <ashley.e.desimone@...> R: Puja Pandya <puja.pandya@...> I believe a community discussion is needed to make a decision on the exact final location. Once consensus is reached, we can retire the edk2-staging version of EdkRepo. As always, feedback on this proposal is welcome and appreciated. With Best Regards, Nate
|
|
Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
Wu, Hao A
Hello all,
With Leif's comment on the better usage of the wildcard character & 'X:' tag: https://edk2.groups.io/g/devel/message/42587 The list is updated as shown below. Also, I forgot to mention that some directory/file may be classified into multiple classes. I think it is a valid case, for example: MdeModulePkg/Library/SmmMemoryAllocationProfileLib matches both 'Memory Management' and 'SMM' sections: Memory Management - F: MdeModulePkg/*Mem*/ SMM - F: MdeModulePkg/*Smm*/ Then, reviewers from both classes should be Cc-ed when changes are made in the above library. If the updated list is good enough, the next step will be determining the reviewer(s) for each feature in the list. The updated list: ACPI: F: MdeModulePkg/Include/*/*Acpi*.h F: MdeModulePkg/Universal/Acpi/ BDS: F: MdeModulePkg/*BootManager*/ X: MdeModulePkg/Application/BootManagerMenuApp/ F: MdeModulePkg/Include/Library/UefiBootManagerLib.h F: MdeModulePkg/Universal/BdsDxe/ F: MdeModulePkg/Universal/LoadFileOnFv2/ F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.* Console: F: MdeModulePkg/Include/Guid/ConnectConInEvent.h F: MdeModulePkg/Include/Guid/Console*.h F: MdeModulePkg/Include/Guid/StandardErrorDevice.h F: MdeModulePkg/Include/Guid/TtyTerm.h F: MdeModulePkg/Universal/Console/ X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/ Core (PEI, DXE and Runtime): F: MdeModulePkg/*SectionExtract*/ F: MdeModulePkg/Core/Dxe/ X: MdeModulePkg/Core/Dxe/Gcd/ X: MdeModulePkg/Core/Dxe/Mem/ F: MdeModulePkg/Core/DxeIplPeim/ F: MdeModulePkg/Core/Pei/ X: MdeModulePkg/Core/Pei/Memory/ X: MdeModulePkg/Core/Pei/PciCfg2/ X: MdeModulePkg/Core/Pei/Reset/ X: MdeModulePkg/Core/Pei/StatusCode/ F: MdeModulePkg/Core/RuntimeDxe/ F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h F: MdeModulePkg/Include/Guid/IdleLoopEvent.h F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h F: MdeModulePkg/Include/Library/SecurityManagementLib.h F: MdeModulePkg/Library/DxeSecurityManagementLib/ F: MdeModulePkg/Universal/PlatformDriOverrideDxe/ F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c Debug: F: MdeModulePkg/*Debug*/ X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/ F: MdeModulePkg/Include/Guid/DebugMask.h F: MdeModulePkg/Include/Library/DebugAgentLib.h F: MdeModulePkg/Include/Ppi/Debug.h Decompress: F: MdeModulePkg/Include/Guid/LzmaDecompress.h F: MdeModulePkg/Library/*Decompress*/ Device: F: MdeModulePkg/*Serial*/ X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/ F: MdeModulePkg/Bus/ X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/ X: MdeModulePkg/Bus/Pci/PciBusDxe/ X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/ F: MdeModulePkg/Include/*/*Ata*.h F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h F: MdeModulePkg/Include/*/*NvmExpress*.h F: MdeModulePkg/Include/*/*SerialPort*.h F: MdeModulePkg/Include/*/*SdMmc*.h F: MdeModulePkg/Include/*/*Ufs*.h F: MdeModulePkg/Include/*/*Usb*.h F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h F: MdeModulePkg/Include/Guid/RecoveryDevice.h F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h F: MdeModulePkg/Include/Protocol/Ps2Policy.h F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/ Disk: F: MdeModulePkg/Universal/Disk/ EBC: F: MdeModulePkg/Include/*/*Ebc*.h F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h F: MdeModulePkg/Universal/EbcDxe/ Firmware Update: F: MdeModulePkg/*Capsule*/ F: MdeModulePkg/Include/*/*Capsule*.h F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h F: MdeModulePkg/Include/Protocol/EsrtManagement.h F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h F: MdeModulePkg/Library/DisplayUpdateProgressLib*/ F: MdeModulePkg/Library/FmpAuthenticationLibNull/ F: MdeModulePkg/Universal/Esrt*/ Graphic: F: MdeModulePkg/*Logo*/ F: MdeModulePkg/Include/*/*Logo*.h F: MdeModulePkg/Include/Library/BmpSupportLib.h F: MdeModulePkg/Include/Library/FrameBufferBltLib.h F: MdeModulePkg/Library/BaseBmpSupportLib/ F: MdeModulePkg/Library/FrameBufferBltLib/ F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/ HII/UI: F: MdeModulePkg/*FileExplorer*/ F: MdeModulePkg/*Hii*/ F: MdeModulePkg/*Ui*/ F: MdeModulePkg/Application/BootManagerMenuApp/ F: MdeModulePkg/Include/*/*FileExplorer*.h F: MdeModulePkg/Include/*/*FormBrowser*.h F: MdeModulePkg/Include/*/*Hii*.h F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h F: MdeModulePkg/Include/Protocol/DisplayProtocol.h F: MdeModulePkg/Library/CustomizedDisplayLib/ F: MdeModulePkg/Universal/DisplayEngineDxe/ F: MdeModulePkg/Universal/SetupBrowserDxe/ IPMI: F: MdeModulePkg/Include/*/*Ipmi*.h F: MdeModulePkg/Library/*Ipmi*/ Memory Management: F: MdeModulePkg/*Mem*/ F: MdeModulePkg/Core/Dxe/Gcd/ F: MdeModulePkg/Include/*/*Mem*.h F: MdeModulePkg/Include/*/*IoMmu*.h PCD: F: MdeModulePkg/Application/DumpDynPcd/ F: MdeModulePkg/Include/*/*Pcd*.h F: MdeModulePkg/Universal/PCD/ PCI Bus: F: MdeModulePkg/*PciHostBridge*/ F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/ F: MdeModulePkg/Bus/Pci/PciBusDxe/ F: MdeModulePkg/Core/Pei/PciCfg2/ F: MdeModulePkg/Include/Library/PciHostBridgeLib.h F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/ Performance: F: MdeModulePkg/Include/*/*Perf*.h F: MdeModulePkg/Library/*Perf*/ Reset: F: MdeModulePkg/*Reset*/ F: MdeModulePkg/Include/*/*Reset*.h S3: F: MdeModulePkg/*LockBox*/ F: MdeModulePkg/Include/*/*BootScript*.h F: MdeModulePkg/Include/*/*LockBox*.h F: MdeModulePkg/Include/*/*S3*.h F: MdeModulePkg/Library/*S3*/ SMBIOS: F: MdeModulePkg/Universal/Smbios*/ SMM: F: MdeModulePkg/*Smi*/ F: MdeModulePkg/*Smm*/ F: MdeModulePkg/Include/*/*Smi*.h F: MdeModulePkg/Include/*/*Smm*.h Status Code: F: MdeModulePkg/*StatusCode*/ F: MdeModulePkg/Include/*/*StatusCode*.h Variable: F: MdeModulePkg/*Var*/ F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h F: MdeModulePkg/Include/*/*Var*.h F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h F: MdeModulePkg/Include/Protocol/SwapAddressRange.h F: MdeModulePkg/Universal/FaultTolerantWrite*/ Misc: F: MdeModulePkg/Application/HelloWorld/ F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h F: MdeModulePkg/Include/Guid/MtcVendor.h F: MdeModulePkg/Include/Guid/ZeroGuid.h F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h F: MdeModulePkg/Include/Library/PlatformHookLib.h F: MdeModulePkg/Include/Library/RecoveryLib.h F: MdeModulePkg/Include/Library/SortLib.h F: MdeModulePkg/Include/Library/TpmMeasurementLib.h F: MdeModulePkg/Include/Protocol/Dpc.h F: MdeModulePkg/Include/Protocol/LoadPe32Image.h F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h F: MdeModulePkg/Include/Protocol/Print2.h F: MdeModulePkg/Library/BaseHobLibNull/ F: MdeModulePkg/Library/BasePlatformHookLibNull/ F: MdeModulePkg/Library/BaseSortLib/ F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/ F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/ F: MdeModulePkg/Library/PeiRecoveryLibNull/ F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/ F: MdeModulePkg/Library/TpmMeasurementLibNull/ F: MdeModulePkg/Library/UefiSortLib/ F: MdeModulePkg/Universal/DevicePathDxe/ F: MdeModulePkg/Universal/DriverHealthManagerDxe/ F: MdeModulePkg/Universal/DriverSampleDxe/ F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/ F: MdeModulePkg/Universal/LegacyRegion2Dxe/ F: MdeModulePkg/Universal/Metronome/ F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/ F: MdeModulePkg/Universal/PrintDxe/ F: MdeModulePkg/Universal/RegularExpressionDxe/ F: MdeModulePkg/Universal/TimestampDxe/ F: MdeModulePkg/Universal/WatchdogTimerDxe/ Best Regards, Hao Wu
|
|
Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
Laszlo Ersek
On 06/24/19 03:16, Wu, Hao A wrote:
Hello all,I think it's good enough. :) Thanks Laszlo
|
|
Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
Yao, Jiewen
thanks
toggle quoted messageShow quoted text
How about to put driversample to ui? How about to put iommu to device? thank you! Yao, Jiewen
在 2019年6月25日,上午4:30,Laszlo Ersek <lersek@...> 写道:On 06/24/19 03:16, Wu, Hao A wrote:I think it's good enough. :)
|
|
Re: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
Wu, Hao A
Hello all,
toggle quoted messageShow quoted text
For this RFC patch, so far it has received the below feedbacks: * Ack tag from Laszlo: https://edk2.groups.io/g/devel/message/42381 * Reviewed-by tag from Ray (PcAtChipsetPkg maintainer): https://edk2.groups.io/g/devel/message/42793 * Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: https://edk2.groups.io/g/devel/topic/31823819#41532 For the last feedback, 8259 PIC can still be configured (to a reasonable state for OS) by Chipset/SI initialization codes without requiring the 8259 driver in PcAtChipsetPkg. Hence, I think it is not considered as a blockade for the removal of 8259 driver proposed by this patch. If there is no other concern, I plan to push this change in 24 hours. Best Regards, Hao Wu
-----Original Message-----
|
|
[RFC][PATCH 0/1] Drop the SourceForge SVN mirror
Wu, Hao A
The patch proposes to:
A. Remove the information on the SourceForge SVN mirror repository from the Maintainers.txt file. B. Stop the sync of the SourceForge SVN mirror from the upstream Github Git repository. (At this moment, the SVN mirror is still syncing the latest changes) Cc: Liming Gao <liming.gao@...> Cc: Andrew Fish <afish@...> Cc: Laszlo Ersek <lersek@...> Cc: Leif Lindholm <leif.lindholm@...> Cc: Michael D Kinney <michael.d.kinney@...> Hao A Wu (1): Maintainers.txt: Drop deprecated SourceForge SVN link Maintainers.txt | 1 - 1 file changed, 1 deletion(-) -- 2.12.0.windows.1
|
|
[RFC][PATCH 1/1] Maintainers.txt: Drop deprecated SourceForge SVN link
Wu, Hao A
The commit will remove the deprecated edk2 SVN mirror at:
https://svn.code.sf.net/p/edk2/code/trunk/edk2 After this commit, the above minnor will not be synced with the changes made in the GitHub upstream. Cc: Liming Gao <liming.gao@...> Cc: Andrew Fish <afish@...> Cc: Laszlo Ersek <lersek@...> Cc: Leif Lindholm <leif.lindholm@...> Cc: Michael D Kinney <michael.d.kinney@...> Signed-off-by: Hao A Wu <hao.a.wu@...> --- Maintainers.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index e52f044bec..e4eb37d641 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -43,7 +43,6 @@ W: http://www.tianocore.org/edk2/ L: https://edk2.groups.io/g/devel/ T: git - https://github.com/tianocore/edk2.git T: git (mirror) - https://bitbucket.org/tianocore/edk2.git -T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2 Tianocore Stewards ------------------ -- 2.12.0.windows.1
|
|
Re: [RFC][PATCH 0/1] Drop the SourceForge SVN mirror
Leif Lindholm
On Thu, Jun 27, 2019 at 01:50:43PM +0800, Hao A Wu wrote:
The patch proposes to:From my point of view, a strong: Reviewed-by: Leif Lindholm <leif.lindholm@...> But please wait for additional feedback before pushing. Hao A Wu (1):
|
|
Re: [RFC][PATCH 1/1] Maintainers.txt: Drop deprecated SourceForge SVN link
Laszlo Ersek
+Jordan
On 06/27/19 07:50, Hao A Wu wrote: The commit will remove the deprecated edk2 SVN mirror at:(1) s/minnor/mirror/ made in the GitHub upstream.Reviewed-by: Laszlo Ersek <lersek@...>
|
|
Re: [RFC] EdkRepo - The Multi-Repository Tool for EDK II
Hi All,
toggle quoted messageShow quoted text
The initial drop of EdkRepo has to edk2-staging has been completed! https://github.com/tianocore/edk2-staging/tree/EdkRepo For convenience, I have compiled binaries of the current state of EdkRepo and attached them to a personal fork of edk2-staging. By no means should these binaries be considered an official release, they are a snapshot that I created to help everyone give EdkRepo a try. Linux: https://github.com/nate-desimone/edk2-staging/releases/download/EdkRepo-preview-2019-06-28/edkrepo-preview-2019-06-28.tar.gz Windows: https://github.com/nate-desimone/edk2-staging/releases/download/EdkRepo-preview-2019-06-28/EdkRepoSetup-preview-2019-06-28.exe To get started, you can try cloning the Intel-MinPlatform project, which we created as an example of how EdkRepo is used. This is also a convenient way to set up a MinPlatform development workspace: edkrepo clone min_platform Intel-MinPlatform Questions or comments, are always welcome! Regards, Nate
-----Original Message-----
From: rfc@edk2.groups.io <rfc@edk2.groups.io> On Behalf Of Nate DeSimone Sent: Tuesday, June 11, 2019 4:59 PM To: devel@edk2.groups.io; rfc@edk2.groups.io Subject: [edk2-rfc] [RFC] EdkRepo - The Multi-Repository Tool for EDK II Hi All, This RFC is raised to add EdkRepo, the multi-repository tool for EDK II firmware development to TianoCore. EdkRepo is built on top of git. It is intended to automate common developer workflows for projects that use more than one git repository. For example many of the new projects in the edk2-platforms repository require the user to clone several git repositories. EdkRepo makes it easier to set up and upstream changes for these projects. EdkRepo does not replace git, rather it provides higher level extensions that make it easier to work with git. EdkRepo uses "manifest XML" files to describe the git repositories and EDK II packages that a project uses. EdkRepo is aware of the DSC file format and is able to combine this XML with metadata from DSC files to create a development experience tailored specifically for EDK II firmware development. EdkRepo is written in Python and is compatible with Python 3.5 or later. EdkRepo has been internally developed at Intel for 2.5 years. EdkRepo was originally created to support our own product development. With the recent release of MinPlatformPkg, the number of complete open source UEFI firmware implementations available at TianoCore has been growing rapidly. We see that many of the development workflows we encounter for our product work now apply more broadly to the TianoCore community. Accordingly, we would like to open EdkRepo to community. We see this process going through several phases. First, we provide an initial commit of EdkRepo via edk2-staging. We envision two branches being added to edk2-staging: 1. EdkRepo - Contains the source code for the EdkRepo tool. 2. EdkRepo-Manifest - Contains an initial set of example manifest files which can be used to try EdkRepo I will send out patches to create these two branches shortly. After these branches are created, we will send a series of commits to populate the first open source version of EdkRepo. At this point the community can take a look and provide feedback. There are several options for where the final location where this tool might live: 1. edk2-platforms 2. edk2-pytool-library 3. The edk2-toolenv repository proposed by Sean (assuming approval of Sean's RFC) 4. A new, separate repository created for EdkRepo In addition, we recommend that a new TianoCore owned repository be created to host the manifest XML content. The initial proposed maintainer list for EdkRepo is: M: Nate DeSimone <nathaniel.l.desimone@...> M: Ashley DeSimone <ashley.e.desimone@...> R: Puja Pandya <puja.pandya@...> I believe a community discussion is needed to make a decision on the exact final location. Once consensus is reached, we can retire the edk2-staging version of EdkRepo. As always, feedback on this proposal is welcome and appreciated. With Best Regards, Nate
|
|
Re: [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg
Wu, Hao A
Hello all,
toggle quoted messageShow quoted text
So far, this RFC series has received the below feedbacks: * Ack tag from Laszlo Ersek: https://edk2.groups.io/g/devel/message/42382 * Reviewed-by tag from Liming Gao: https://edk2.groups.io/g/devel/message/43144 Also, the latest status is that all the known platforms/packages dependencies on IntelFrameworkModulePkg & IntelFrameworkPkg have been dropped. If there is no other comments, I plan to push this series after 24 hours. Best Regards, Hao Wu
-----Original Message-----
|
|
Re: [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg
Ni, Ray
Reviewed-by: Ray Ni <ray.ni@...>
toggle quoted messageShow quoted text
-----Original Message-----
|
|
Re: [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg
Wu, Hao A
Thanks all,
toggle quoted messageShow quoted text
The series has been pushed via commits 4286eb22f4..896db3a4ce. Best Regards, Hao Wu
-----Original Message-----
|
|
Re: [edk2-devel] [RFC][PATCH 1/1] Maintainers.txt: Drop deprecated SourceForge SVN link
Wu, Hao A
toggle quoted messageShow quoted text
-----Original Message----- Hello all, If there is no other comment, I plan to push this patch (with Laszlo's feedback addressed) and stop the sync for the SourceForge SVN mirror. Best Regards, Hao Wu
|
|
Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
Wu, Hao A
toggle quoted messageShow quoted text
-----Original Message----- Posting to the rfc list as well. Best Regards, Hao Wu +M: Leif Lindholm <leif.lindholm@...>
|
|
Re: [edk2-devel] [RFC][PATCH 1/1] Maintainers.txt: Drop deprecated SourceForge SVN link
Wu, Hao A
toggle quoted messageShow quoted text
-----Original Message----- Thanks all, patch pushed via commit 03835a8c73. Best Regards, Hao Wu
|
|
Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
Wu, Hao A
toggle quoted messageShow quoted text
-----Original Message----- Yes, the proposed BaseTools script is working for: MdeModulePkg/*Ufs*/ to match changes made in both directories. I am also fine (and prefer) for the wildcard character to match multiple levels of folders. 2. Matching header files (usually within the Include/ directory)My view is that this second option would be required. The script is working like the 2nd option, and I think it is expected. So, there seems to me no bug in my tests. I do met a little problem that for a patch that touches multiple features, the contacts order in the output is not ideally perfect: Content in Maintainers.txt: ''' MdeModulePkg F: MdeModulePkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg M: Jian J Wang <jian.j.wang@...> M: Hao A Wu <hao.a.wu@...> F: MdeModulePkg/*Ufs*/ R: Ufs Guy <ufs@...> F: MdeModulePkg/Include/*Hii*.h F: MdeModulePkg/*Hii*/ R: Hii Guy <hii@...> ''' Script output: ''' $ py BaseTools/Scripts/GetMaintainer.py HEAD MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.uni Jian J Wang <jian.j.wang@...> Hao A Wu <hao.a.wu@...> Ufs Guy <ufs@...> devel@edk2.groups.io Hii Guy <hii@...> ''' The 'Hii Guy' is at the end of the list. But this is a rather minor problem and does not impact the use at all. Best Regards, Hao Wu
|
|
Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
Leif Lindholm
On Thu, Jul 04, 2019 at 06:14:04AM +0000, Wu, Hao A wrote:
I do met a little problem that for a patch that touches multiple features,Totally agree. The idea was to keep the first revision simple. Another thing missing (that I would argue is even more important than listed order), is an indication of *why* said person is listed. But this is a rather minor problem and does not impact the use at all.Good. I will respin the set based on Laszlo's feedback on previous version and resubmit. Best Regards, Leif
|
|
Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
Leif Lindholm
Hi Hao Wu,
toggle quoted messageShow quoted text
Are you ready to send out a v1 yet? (Or did I miss it?) I would prefer to get this in before the GetMaintainer.py script, and after the comment updates to Maintainers.txt. Best Regards, Leif
On Mon, Jun 24, 2019 at 01:16:05AM +0000, Wu, Hao A wrote:
Hello all,
|
|
Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
Wu, Hao A
toggle quoted messageShow quoted text
-----Original Message----- Sorry Leif, You did not miss anything. I was planning to send out the patch after your proposed changes are pushed. Now, I have sent out the patch at: https://edk2.groups.io/g/devel/message/43827 Best Regards, Hao Wu
|
|