Hi Mike, In my proposal, only the API that is selected by PcdSystemHashPolicy will be registered and it will not matter whether other hashing algorithms are supported or not. Whereas, in your

Amol, Your style requires bigger source changes to exiting modules to switch from BaseCryptLib to HashLib. Your style also required a loop to search for matching API on every call. Mine will

Thanks, Mike! Based on your suggestion below and keeping in line with our implementation, I would like to recommend the following changes. I will make those and upload for review: The PCD defined

Amol, I would recommend a different set of APIs in the HashLib class. Instead of doing a registration, define a PCD to select the hash type and have the generic HashLib function call the

Hello everyone, Checking if there are any review comments for https://github.com/ansukerk/edk2. Do I need to submit patches in any other format? Thanks, Amol

Yeah, if we don't want to carry Cmocka in edk2, there's a necessary trade off of having to keep a dependency for the host-based tests. You wouldn't need this dependency for a simple shell-based test,

Hi Bret, No. I did not do that step yet. I will try that next. I was just trying to build the new DSC in the MdePkg. The external dependency for a set of simple lib API unit tests in MdePkg was

Did you make sure to stuart_update? It will pull a dependency repo that is only needed for CI. - Bret ________________________________ Sent: Monday, December 16, 2019 2:31:13 PM To:

Hi Bret, I am looking at the latest version of the content on your branch. I am confused by MdePkg/Test/MdePkgTest.dsc. It makes references to lib classes and packages that do not exist.

No problem for me. Thank you Yao Jiewen Sent: Tuesday, December 17, 2019 5:28 AM To: Yao, Jiewen <jiewen.yao@...>; devel@edk2.groups.io; bret.barkelew@...; Andrew Fish

Hi Jiewen, Many of your responses are related to fuzz testing. Can we focus current infrastructure on host based unit testing and minimizing the content to support that testing type. Then, add a

Answer the question 5,6,7,8, which are related to HBFA. For other MSFT unit test, I don't have strong opinion. I am OK with that. Thank you Yao Jiewen Sent: Saturday, December 14, 2019 8:47 AM To:

The host-based tests now build on Linux/GCC, but the final executables don’t seem to get created. Don’t know where the disconnect is there. I can see the test get compiled (along with all the

Mike, I think I’ve gotten all the feedback here and all the action items from our call. The current branch should be good to go, minus the couple of things that Intel was going to look

1. I see that MdePkg adds a dependency on UnitTestPkg. This makes UnitTestPkg the root package when building and running host based unit tests. This makes sense, but good to highlight that all

Andrew, I agree with your points. Mike, You’ve got a lot more there. Let me take a look and update the draft. I’ll ping back ASAP. - Bret Sent: Wednesday, December 4, 2019 9:50 AM To:

Mike, I like and agree with your comments. On the UnitTestPkg(s) dependency issue I think it would make sense to move as much as possible into the *Pkg/Test/ ( *Pkg/HostLibrary,

Hi Bret, Thanks for posting this content. Host based unit testing is a very valuable addition to the CI checks. I have the following comments: 1. I see that MdePkg adds a dependency on

No objection from me. Thank you for managing the SFF / HFF process, and the release, again, Liming! Laszlo

Hi, all Today, I review all patches in edk2 mail list. There is no patches for EDK II Stable Tag edk2-stable201911. Based on edk2-stable201911 tag planning, it will be released at 2019-11-29. So, I