This is a proposal for a process by which new features can be added to UEFI forum specifications after first having been designed and prototyped in the open. This process lets changes and the

I agree -- I expect that most if not all platform DSC files will need updates. That's because the most frugal approach for a platform is to use the self-contained UefiDevicePathLib instance only in

So, the impact is every platform DSC needs to be updated to reference the correct path of the UefiDevicePath lib after your merge. Let's wait for at least 2 weeks for feedbacks. Thanks, Ray Sent:

Ray, I prefer to merge these two lib instance into one folder and remove the duplicated code. I can change all the required change in open source repo. But not sure how many close source platforms

Zhichao, What's your recommendation regarding this? Back to your 2nd question, drivers/applications consuming UefiDevicePathLibOptionalDevicePathProtocol can firstly use the firmware built-in

HI all, REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298 In the MdePkg, there are two folder for the DevicePathLib: 1. MdePkg\Library\UefiDevicePathLib 2.

Thanks, Mike! I was in the process of sending out the review, so, went ahead and blasted the review email. I will look at your suggestions in the meantime. ~ Amol

Amol, All the APIs are available from BaseCryptLib. I agree that implementations of HashLib on top of other crypto libs would require a different implementation of the library instance and if all

Hi Mike, In my proposal, only the API that is selected by PcdSystemHashPolicy will be registered and it will not matter whether other hashing algorithms are supported or not. Whereas, in your

Amol, Your style requires bigger source changes to exiting modules to switch from BaseCryptLib to HashLib. Your style also required a loop to search for matching API on every call. Mine will

Thanks, Mike! Based on your suggestion below and keeping in line with our implementation, I would like to recommend the following changes. I will make those and upload for review: The PCD defined

Amol, I would recommend a different set of APIs in the HashLib class. Instead of doing a registration, define a PCD to select the hash type and have the generic HashLib function call the

Hello everyone, Checking if there are any review comments for https://github.com/ansukerk/edk2. Do I need to submit patches in any other format? Thanks, Amol

Yeah, if we don't want to carry Cmocka in edk2, there's a necessary trade off of having to keep a dependency for the host-based tests. You wouldn't need this dependency for a simple shell-based test,

Hi Bret, No. I did not do that step yet. I will try that next. I was just trying to build the new DSC in the MdePkg. The external dependency for a set of simple lib API unit tests in MdePkg was

Did you make sure to stuart_update? It will pull a dependency repo that is only needed for CI. - Bret ________________________________ Sent: Monday, December 16, 2019 2:31:13 PM To:

Hi Bret, I am looking at the latest version of the content on your branch. I am confused by MdePkg/Test/MdePkgTest.dsc. It makes references to lib classes and packages that do not exist.

No problem for me. Thank you Yao Jiewen Sent: Tuesday, December 17, 2019 5:28 AM To: Yao, Jiewen <jiewen.yao@...>; devel@edk2.groups.io; bret.barkelew@...; Andrew Fish

Hi Jiewen, Many of your responses are related to fuzz testing. Can we focus current infrastructure on host based unit testing and minimizing the content to support that testing type. Then, add a

Answer the question 5,6,7,8, which are related to HBFA. For other MSFT unit test, I don't have strong opinion. I am OK with that. Thank you Yao Jiewen Sent: Saturday, December 14, 2019 8:47 AM To: