|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Rebecca,
I cheated and used smtpServer = relay.apple.com and smtpEncryption = tls. Seems relay.apple.com does not require authentication and it just worked.
I used an internal git mailing list to
Rebecca,
I cheated and used smtpServer = relay.apple.com and smtpEncryption = tls. Seems relay.apple.com does not require authentication and it just worked.
I used an internal git mailing list to
|
By
Andrew Fish <afish@...>
·
#345
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I'm getting the same error, but with a different packaging of Git: mine's in C:\Program Files\Git\cmd\git.exe .
It's version "git version 2.26.2.windows.1".
Of course it's possible it's just the
I'm getting the same error, but with a different packaging of Git: mine's in C:\Program Files\Git\cmd\git.exe .
It's version "git version 2.26.2.windows.1".
Of course it's possible it's just the
|
By
Rebecca Cran
·
#344
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I think your perl installation and your git installation may come from
different sources, and the perl install may not satisfy the git
install's dependencies.
In GNU/Linux distribution lingo, I'd
I think your perl installation and your git installation may come from
different sources, and the perl install may not satisfy the git
install's dependencies.
In GNU/Linux distribution lingo, I'd
|
By
Laszlo Ersek
·
#343
·
|
|
Re: PKCS7 Authenticated Variable Enrollment
I am sorry that I have not the use case, and I plan to investigating it after August.
I am sorry that I have not the use case, and I plan to investigating it after August.
|
By
Guomin Jiang
·
#342
·
|
|
Re: PKCS7 Authenticated Variable Enrollment
Hi Goumin,
I had discussion internally, and I got hold off tools from: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git.
It is generating the correct format as per
Hi Goumin,
I had discussion internally, and I got hold off tools from: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git.
It is generating the correct format as per
|
By
Wadhawan, Divneil R
·
#341
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
This will probably be down to the [send-email] section of git config, do you have smtpEncryption enabled by any chance?
You could also try updating the required package:
perl -MCPAN -e 'install
This will probably be down to the [send-email] section of git config, do you have smtpEncryption enabled by any chance?
You could also try updating the required package:
perl -MCPAN -e 'install
|
By
Tomas Pilar (tpilar)
·
#340
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
So, today I followed the Wiki (that I had never seen) and now I’m staring down the barrel of this fellow…
[cid:image002.png@...]
[Not using SSL_VERIFY_PEER due to out-of-date
So, today I followed the Wiki (that I had never seen) and now I’m staring down the barrel of this fellow…
[cid:image002.png@...]
[Not using SSL_VERIFY_PEER due to out-of-date
|
By
Bret Barkelew <bret.barkelew@...>
·
#339
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Samer,
Have you had a chance to review Mike’s PR process? Any thoughts as comparison?
- Bret
________________________________
Sent: Tuesday, May 26, 2020 7:39:55 AM
To: rfc@edk2.groups.io
Samer,
Have you had a chance to review Mike’s PR process? Any thoughts as comparison?
- Bret
________________________________
Sent: Tuesday, May 26, 2020 7:39:55 AM
To: rfc@edk2.groups.io
|
By
Bret Barkelew <bret.barkelew@...>
·
#338
·
|
|
Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I actually agree with you, when we migrated from reviewboard to github pull requests, I was sorely disappointed with the PR functionality and ergonomics.
Tomas Pilar
I actually agree with you, when we migrated from reviewboard to github pull requests, I was sorely disappointed with the PR functionality and ergonomics.
Tomas Pilar
|
By
Tomas Pilar (tpilar)
·
#337
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I agree with Andrew. I also found Laszlo's "unkempt guide" very useful. In addition, there is a short page by Peter Batard that adds more details on the commits validation, patchset generation, and
I agree with Andrew. I also found Laszlo's "unkempt guide" very useful. In addition, there is a short page by Peter Batard that adds more details on the commits validation, patchset generation, and
|
By
Samer El-Haj-Mahmoud
·
#336
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
The article at [1] is an official document, while the "unkempt guide" is
not official. The unkempt guide starts by deferring to [1]. I didn't
think the official document should point to my unofficial
The article at [1] is an official document, while the "unkempt guide" is
not official. The unkempt guide starts by deferring to [1]. I didn't
think the official document should point to my unofficial
|
By
Laszlo Ersek
·
#335
·
|
|
[RFC]: StandAloneMM in OP-TEE
Hi All,
We are working on enabling the Secure Storage of Variables for Secure UEFI.
Let me give you a brief idea of what we are doing.
We need StandAlone Management Mode to run in the Secure
Hi All,
We are working on enabling the Secure Storage of Variables for Secure UEFI.
Let me give you a brief idea of what we are doing.
We need StandAlone Management Mode to run in the Secure
|
By
Sahil Malhotra <sahil.malhotra@...>
·
#334
·
|
|
Re: PKCS7 Authenticated Variable Enrollment
Hi Wadhawan,
I will check it after August because I am busy recently.
Best Regards
Guomin
Hi Wadhawan,
I will check it after August because I am busy recently.
Best Regards
Guomin
|
By
Guomin Jiang
·
#333
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Laszlo,
Your wiki article was very very helpful. I just could not find it from the Tianocre wiki. It would be good if we could link to it from here [1], maybe as add to this: "Are you new to using
Laszlo,
Your wiki article was very very helpful. I just could not find it from the Tianocre wiki. It would be good if we could link to it from here [1], maybe as add to this: "Are you new to using
|
By
Andrew Fish <afish@...>
·
#332
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Hi Andrew,
(apologies if I've lost context; please disregard my message below in
that case).
I wrote the following wiki article originally in
Hi Andrew,
(apologies if I've lost context; please disregard my message below in
that case).
I wrote the following wiki article originally in
|
By
Laszlo Ersek
·
#331
·
|
|
Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Bret,
Sorry for being confusing, and lazy.....
The lazy part is in house we have a bug tracking tool called radar, so I just replaced radar with BZ to make a general point.
So the scripts I
Bret,
Sorry for being confusing, and lazy.....
The lazy part is in house we have a bug tracking tool called radar, so I just replaced radar with BZ to make a general point.
So the scripts I
|
By
Andrew Fish <afish@...>
·
#330
·
|
|
Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Proposal:
- Whenever upstreaming a bugfix or a feature, open an upstream BZ.
- In your downstream ticket for the same bugfix or feature,
cross-reference the upstream BZ URL. This shouldn't be a
Proposal:
- Whenever upstreaming a bugfix or a feature, open an upstream BZ.
- In your downstream ticket for the same bugfix or feature,
cross-reference the upstream BZ URL. This shouldn't be a
|
By
Laszlo Ersek
·
#329
·
|
|
Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
I was working on a web project recently, and apparently people don't even check email any more! So someone had set up a Slack channel where Github pull requests were posted/linked, and we were
I was working on a web project recently, and apparently people don't even check email any more! So someone had set up a Slack channel where Github pull requests were posted/linked, and we were
|
By
Rebecca Cran
·
#328
·
|
|
Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Or at least, that's what Microsoft is betting on! :D
Personally, I remain unconvinced about the usability of Github Pull Requests for a project the size of EDK2, but I hope to be proven wrong.
--
Or at least, that's what Microsoft is betting on! :D
Personally, I remain unconvinced about the usability of Github Pull Requests for a project the size of EDK2, but I hope to be proven wrong.
--
|
By
Rebecca Cran
·
#327
·
|
|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Mike,
I'd suggest following what other Github projects do, which I think is to run the CI checks automatically on every change that's made in a pull request - I don't know if it might also be
Mike,
I'd suggest following what other Github projects do, which I think is to run the CI checks automatically on every change that's made in a pull request - I don't know if it might also be
|
By
Rebecca Cran
·
#326
·
|