|
回复: [edk2-rfc] [RFC V3] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
Mike:
It is OK to me. I have no other comments.
Thanks
Liming
Mike:
It is OK to me. I have no other comments.
Thanks
Liming
|
By
gaoliming
·
#474
·
|
|
Re: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
I'd suggest just using the Gitlab mirror. Unlike cryptomilk.org, Gitlab should be just as reliable as Github and won't introduce another potential failure point.
--
Rebecca Cran
I'd suggest just using the Gitlab mirror. Unlike cryptomilk.org, Gitlab should be just as reliable as Github and won't introduce another potential failure point.
--
Rebecca Cran
|
By
Rebecca Cran
·
#473
·
|
|
Re: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
I like it.
- Bret
Sent: Saturday, December 19, 2020 10:59 AM
To: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret
I like it.
- Bret
Sent: Saturday, December 19, 2020 10:59 AM
To: rfc@edk2.groups.io<mailto:rfc@edk2.groups.io>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret
|
By
Bret Barkelew <bret.barkelew@...>
·
#472
·
|
|
Re: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
Hello,
There have been a few suggestions to create a mirror of cmocka in TianoCore
org in GitHub.
I have found a GitHub action that can do a repo sync.
Hello,
There have been a few suggestions to create a mirror of cmocka in TianoCore
org in GitHub.
I have found a GitHub action that can do a repo sync.
|
By
Michael D Kinney
·
#471
·
|
|
[RFC V3] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
Hello,
The following bug has been fixed on edk2/master
https://bugzilla.tianocore.org/show_bug.cgi?id=3111
https://github.com/tianocore/edk2/pull/1226
This bug is also considered a
Hello,
The following bug has been fixed on edk2/master
https://bugzilla.tianocore.org/show_bug.cgi?id=3111
https://github.com/tianocore/edk2/pull/1226
This bug is also considered a
|
By
Michael D Kinney
·
#470
·
|
|
Re: [EXTERNAL] Re: [RFC V2] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
I agree that the default policy is to only support a branch until the next
stable tag. My comments were only to address the potential for a request
after that defined support timeline. If a portion
I agree that the default policy is to only support a branch until the next
stable tag. My comments were only to address the potential for a request
after that defined support timeline. If a portion
|
By
Michael D Kinney
·
#469
·
|
|
回复: [RFC V2] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
Mike:
This case is clear. One commit is for the bug fix, another is for the unit test.
If the unit test is also important for this fix, it can be cherry-pick. I understand the critical bug fix is
Mike:
This case is clear. One commit is for the bug fix, another is for the unit test.
If the unit test is also important for this fix, it can be cherry-pick. I understand the critical bug fix is
|
By
gaoliming
·
#468
·
|
|
回复: [edk2-devel] [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
Mike:
I review all submodules in edk2. They are all from github except for cmocka. So, I agree to use github mirror for cmocka.
Thanks
Liming
Mike:
I review all submodules in edk2. They are all from github except for cmocka. So, I agree to use github mirror for cmocka.
Thanks
Liming
|
By
gaoliming
·
#467
·
|
|
回复: [RFC V2] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
Mike:
[Liming] This one is for unit test. It is not critical fix. I don't think it is required.
Here is my suggestion on the live period of the stable tag branch.
The stable tag branch will be
Mike:
[Liming] This one is for unit test. It is not critical fix. I don't think it is required.
Here is my suggestion on the live period of the stable tag branch.
The stable tag branch will be
|
By
gaoliming
·
#466
·
|
|
Re: [EXTERNAL] Re: [RFC V2] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
“I agree with Liming that stable branches should have a predefined
lifetime. Keeping stable branches regression-free is very difficult and
ungrateful work, and the community should not have
“I agree with Liming that stable branches should have a predefined
lifetime. Keeping stable branches regression-free is very difficult and
ungrateful work, and the community should not have
|
By
Bret Barkelew <bret.barkelew@...>
·
#465
·
|
|
Re: [EXTERNAL] Re: [edk2-rfc] [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
My vote is to own a fork. I agree with Laszlo that it’s very low maintenance (may even be able to automate it with an existing DevOps pipeline to run every day) and gives us the most control of our
My vote is to own a fork. I agree with Laszlo that it’s very low maintenance (may even be able to automate it with an existing DevOps pipeline to run every day) and gives us the most control of our
|
By
Bret Barkelew <bret.barkelew@...>
·
#464
·
|
|
Re: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
Also, apparently Neverware is part of Google:
https://cloudreadykb.neverware.com/s/article/Neverware-is-now-part-of-Google-FAQ
--
Rebecca Cran
Also, apparently Neverware is part of Google:
https://cloudreadykb.neverware.com/s/article/Neverware-is-now-part-of-Google-FAQ
--
Rebecca Cran
|
By
Rebecca Cran <rebecca@...>
·
#463
·
|
|
Re: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
I'm sorry, this was silly.
The whole point of git is "addressing by content". Our submodule
reference in edk2 makes us check out the cmocka tree at a known hash, so
where that comes from is totally
I'm sorry, this was silly.
The whole point of git is "addressing by content". Our submodule
reference in edk2 makes us check out the cmocka tree at a known hash, so
where that comes from is totally
|
By
Laszlo Ersek
·
#462
·
|
|
Re: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
We could create our own fork under the <https://github.com/tianocore>
organization.
It does not require much extra maintenance or monitoring, in my opinion.
We only need to advance our fork to the
We could create our own fork under the <https://github.com/tianocore>
organization.
It does not require much extra maintenance or monitoring, in my opinion.
We only need to advance our fork to the
|
By
Laszlo Ersek
·
#461
·
|
|
Re: [RFC V2] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
- Looks good; just a typo in the example: "edk2-stable201111.01" should
use 2020, not 2011.
- I agree with Liming that stable branches should have a predefined
lifetime. Keeping stable branches
- Looks good; just a typo in the example: "edk2-stable201111.01" should
use 2020, not 2011.
- I agree with Liming that stable branches should have a predefined
lifetime. Keeping stable branches
|
By
Laszlo Ersek
·
#460
·
|
|
Re: [RFC] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
Sounds good to me as well, thanks!
Laszlo
Sounds good to me as well, thanks!
Laszlo
|
By
Laszlo Ersek
·
#459
·
|
|
[RFC] UnitTestFrameworkPkg cmocka submodule alternatives
Hello,
We have had at least three incidents in the last year where the link to the
cmocka submodule in the UnitTestFrameworkPkg has not been available, and this
impacted the EDK II CI system. The
Hello,
We have had at least three incidents in the last year where the link to the
cmocka submodule in the UnitTestFrameworkPkg has not been available, and this
impacted the EDK II CI system. The
|
By
Michael D Kinney
·
#458
·
|
|
Re: [RFC V2] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
By
Michael D Kinney
·
#457
·
|
|
[RFC V2] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
Hello,
The following bug has been fixed on edk2/master
https://bugzilla.tianocore.org/show_bug.cgi?id=3111
https://github.com/tianocore/edk2/pull/1226
This bug is also considered a critical
Hello,
The following bug has been fixed on edk2/master
https://bugzilla.tianocore.org/show_bug.cgi?id=3111
https://github.com/tianocore/edk2/pull/1226
This bug is also considered a critical
|
By
Michael D Kinney
·
#456
·
|
|
Re: [RFC] Create supported branch from edk2-stable* tag (Required to address critical bug BZ3111)
Hi Leif,
Thank you for the feedback.
I will send a revised RFC soon.
I will discuss with Liming in the Tianocore bug scrub this evening.
Mike
Hi Leif,
Thank you for the feedback.
I will send a revised RFC soon.
I will discuss with Liming in the Tianocore bug scrub this evening.
Mike
|
By
Michael D Kinney
·
#455
·
|