|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
To clarify, I don't think we should allow any github-side automatism to
auto-rebase pull requests. I think such rebases need to occur on
personal developer machines, under human oversight, and then
To clarify, I don't think we should allow any github-side automatism to
auto-rebase pull requests. I think such rebases need to occur on
personal developer machines, under human oversight, and then
|
By
Laszlo Ersek
·
#282
·
|
|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Build-testing at every stage through a patch series is important for
ensuring bisectability.
But there's a critical ingredient to that: based on the assumption that
our build system / build rules are
Build-testing at every stage through a patch series is important for
ensuring bisectability.
But there's a critical ingredient to that: based on the assumption that
our build system / build rules are
|
By
Laszlo Ersek
·
#281
·
|
|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
(
Wow, "squash-on-merge" is even the *default* now? That's terrible.
Unfortunately, github.com sets a very bad example with this, which is
made worse by github's popularity.
How can we expect
(
Wow, "squash-on-merge" is even the *default* now? That's terrible.
Unfortunately, github.com sets a very bad example with this, which is
made worse by github's popularity.
How can we expect
|
By
Laszlo Ersek
·
#280
·
|
|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
That's because the proof-of-concept list is currently subscriber-only,
and subscription requests have to be manually approved -- by Phil, or by
me. The PoC list contains a bunch of webhook test
That's because the proof-of-concept list is currently subscriber-only,
and subscription requests have to be manually approved -- by Phil, or by
me. The PoC list contains a bunch of webhook test
|
By
Laszlo Ersek
·
#279
·
|
|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
s/decryption/description/
(Because I'm assuming this will turn into a wiki article at some point.)
s/make add/add/
Do I understand correctly that this recommends the contributor first
push
s/decryption/description/
(Because I'm assuming this will turn into a wiki article at some point.)
s/make add/add/
Do I understand correctly that this recommends the contributor first
push
|
By
Laszlo Ersek
·
#278
·
|
|
Re: GitHub Pull Request based Code Review Process
Hi Ray,
Comments below.
Mike
Hi Ray,
Comments below.
Mike
|
By
Michael D Kinney
·
#277
·
|
|
Re: GitHub Pull Request based Code Review Process
Hello,
I have added the following repository to TianoCore to
support the evaluation of the GitHub pull request based
code review process and the email archive webbook. This
is a copy of
Hello,
I have added the following repository to TianoCore to
support the evaluation of the GitHub pull request based
code review process and the email archive webbook. This
is a copy of
|
By
Michael D Kinney
·
#276
·
|
|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Rebecca,
I agree that the first version should rerun CI checks
on every time commits are added to a PR or there is a
forced push to the PR.
Perhaps we should use Draft Pull Requests as a way
to
Rebecca,
I agree that the first version should rerun CI checks
on every time commits are added to a PR or there is a
forced push to the PR.
Perhaps we should use Draft Pull Requests as a way
to
|
By
Michael D Kinney
·
#275
·
|
|
Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Rebecca,
There is no difference between CI checks run during code review
and the final CI checks before merge. I think it is an interesting
conversation to decide how many times those CI checks
Rebecca,
There is no difference between CI checks run during code review
and the final CI checks before merge. I think it is an interesting
conversation to decide how many times those CI checks
|
By
Michael D Kinney
·
#274
·
|
|
Re: GitHub Pull Request based Code Review Process
Mike,
It's a huge improvement to me as an Outlook user if pull-request-based review is enabled!
Please help me to understand: The pull-request-based review has been enabled naturally when edk2
was
Mike,
It's a huge improvement to me as an Outlook user if pull-request-based review is enabled!
Please help me to understand: The pull-request-based review has been enabled naturally when edk2
was
|
By
Ni, Ray
·
#273
·
|
|
GitHub Pull Request based Code Review Process
Hello,
This is a proposal to change from the current email-based code review process to
a GitHub pull request-based code review process for all repositories maintained
in TianoCore. The current
Hello,
This is a proposal to change from the current email-based code review process to
a GitHub pull request-based code review process for all repositories maintained
in TianoCore. The current
|
By
Michael D Kinney
·
#272
·
|
|
PKCS7 Authenticated Variable Enrollment
Hi,
I am trying to test if the enrollment of Authenticated Variables is possible with verification of signature with different key sizes.
File: AuthService.c :: Function: VerifyTimeBasedPayload() ->
Hi,
I am trying to test if the enrollment of Authenticated Variables is possible with verification of signature with different key sizes.
File: AuthService.c :: Function: VerifyTimeBasedPayload() ->
|
By
Wadhawan, Divneil R <divneil.r.wadhawan@...>
·
#271
·
|
|
[RFC] BaseTools/Source/Python as a standalone python package in independent repo
Hello Tianocore Community,
I’m submitting an RFC, proposing the movement of the basetools folder in edk2 to a separate repo and treated as a separate python project.
We talked about it during the
Hello Tianocore Community,
I’m submitting an RFC, proposing the movement of the basetools folder in edk2 to a separate repo and treated as a separate python project.
We talked about it during the
|
By
Matthew Carlson
·
#270
·
|
|
Re: [RFCv2] code-first process for UEFI-forum specifications
Acked-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>
Acked-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>
|
By
Samer El-Haj-Mahmoud
·
#268
·
|
|
Re: [RFC] fix for virt-install failure with OVMF?
Hi Aaron.
(I'm responding through the groups.io webui because it's way too late for a full email fetch now. So the threading & quoting will most likely be broken. Sorry about that.)
The
Hi Aaron.
(I'm responding through the groups.io webui because it's way too late for a full email fetch now. So the threading & quoting will most likely be broken. Sorry about that.)
The
|
By
Laszlo Ersek
·
#267
·
|
|
Re: [RFC] fix for virt-install failure with OVMF?
Hi Lazslo, thanks for the comments.
My apologies - the actual virt-install command our Q/A team is using is this (which has extra args for a kick start file):
virt-install --name guest-31156337
Hi Lazslo, thanks for the comments.
My apologies - the actual virt-install command our Q/A team is using is this (which has extra args for a kick start file):
virt-install --name guest-31156337
|
By
Aaron Young
·
#266
·
|
|
Re: [RFC] fix for virt-install failure with OVMF?
This is by-design. The behavior is expected, and your virt-install
command line is wrong.
The "--location" parameter invokes a direct kernel boot. When you pass a
local ISO image with "--location",
This is by-design. The behavior is expected, and your virt-install
command line is wrong.
The "--location" parameter invokes a direct kernel boot. When you pass a
local ISO image with "--location",
|
By
Laszlo Ersek
·
#265
·
|
|
[RFC] fix for virt-install failure with OVMF?
Hello, we have found what we think is a BUG in OVMF, but wanted to run it by the rfc list first to confirm.
We have discovered that the following virt-install command causes the latest OVMF code to
Hello, we have found what we think is a BUG in OVMF, but wanted to run it by the rfc list first to confirm.
We have discovered that the following virt-install command causes the latest OVMF code to
|
By
Aaron Young
·
#264
·
|
|
RFC: ASIX USB drivers
EDK2 community,
(and CCing OptionRomPkg maintainers),
ASIX (https://www.asix.com.tw/) has graciously contributed the source code of their latest USB NIC drivers to be up-streamed to TianoCore.
The
EDK2 community,
(and CCing OptionRomPkg maintainers),
ASIX (https://www.asix.com.tw/) has graciously contributed the source code of their latest USB NIC drivers to be up-streamed to TianoCore.
The
|
By
Samer El-Haj-Mahmoud
·
#263
·
|
|
Re: [edk2-devel] [RFC][PATCH v1] UefiCpuPkg/MpInitLib DXE: Reduce AP status check interval
Thank you. I agree with Laszlo: MP initialization is tricky to scale, and platform dependent. My group builds real machines with thousands of APs, and we have had to do various tweaks to the MP
Thank you. I agree with Laszlo: MP initialization is tricky to scale, and platform dependent. My group builds real machines with thousands of APs, and we have had to do various tweaks to the MP
|
By
Brian J. Johnson
·
#262
·
|