On 10/1/20, 4:52 AM, " Leif Lindholm" <leif@...> wrote:
Very positive to this on the whole.
Happy to hear!
I have only been following MinPlatformPkg peripherally - at the time it was
merged, I did not have the bandwidth to look into it and help make it cross-
architecture from the start, so I mostly refrained from comment.
One thing I think is needed for this to move out of Platform/Intel would be a
ReadMe.rst describing the intended real-world use.
Some of this lives in Platform/Intel/Readme.md today.
Could we start with a set moving this text into a separate file under
MinPlatformPkg and rework that into something that stands on its own?
Yeah agreed, given that the feedback on this RFC has been pretty positive thus far, I'm planning on making a patch series for this. I'll make these changes part of said patch series.
If I was to bikeshed, I'd probably suggest
Platform/TianoCore/MinPlatformPkg. Oops, guess I did.
Seems a little superfluous to me... isn't edk2-platforms part of TianoCore by definition? 😊
I think we should see this as a separate step, regardless.
I do think we should be able to do better on sharing some of this platform
image tooling cross-architecture (even moreso now Risc-V is involved), but I
would prefer for us to spend the effort of identifying the intersections
upfront before we start uploading tools to places where they look generic
and may confuse people.
Maybe we should raise this part as a BZ?
Yup, sounds like good next steps to me. I've filed the BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2992