Re: [edk2-devel] [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag
Eric Jin <eric.jin@...>
Hi Leif,toggle quoted messageShow quoted text
Thank for the valuable suggestion.
In the patch series V2, Sean has been set as author on patch 1/2. Thank you.
From: firstname.lastname@example.org [mailto:email@example.com] On Behalf Of Leif Lindholm
Sent: Wednesday, August 14, 2019 2:47 AM
To: Gao, Liming <firstname.lastname@example.org>
Cc: Jin, Eric <email@example.com>; firstname.lastname@example.org; email@example.com; Feng, Bob C <firstname.lastname@example.org>; Cetola, Stephano <email@example.com>; Laszlo Ersek (firstname.lastname@example.org) <email@example.com>; firstname.lastname@example.org; Kinney, Michael D <email@example.com>
Subject: Re: [edk2-devel] [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag
This is the other one. As I said, the fact that we are slipping multiple scripts in *just* before freeze is a concern for me.
I have no objection to the code here though.
I would however request that Sean is set as author on patch 1/2 as he was the original author of the script. (This was easy for me to find out because the commit message was exemplary.)
On Tue, Aug 13, 2019 at 01:49:24PM +0000, Gao, Liming wrote:
I see this patch was sent a week ago. This is a standalone tool. There is no impact on normal build and boot. I am OK to add it for 201908 stable tag.