Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
Bret Barkelew <bret.barkelew@...>
So, today I followed the Wiki (that I had never seen) and now I’m staring down the barrel of this fellow…
[Not using SSL_VERIFY_PEER due to out-of-date IO::Socket::SSL.
To use SSL please install IO::Socket::SSL with version>=2.007 at /usr/share/perl5/core_perl/Net/SMTP.pm line 270.]
Anyone have thoughts? I’mma go get a scotch.
From: Andrew Fish<mailto:firstname.lastname@example.org>
Sent: Monday, May 25, 2020 11:28 AM
To: Laszlo Ersek<mailto:email@example.com>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; firstname.lastname@example.org<mailto:email@example.com>; firstname.lastname@example.org<mailto:email@example.com>; firstname.lastname@example.org<mailto:email@example.com>; Desimone, Nathaniel L<mailto:firstname.lastname@example.org>; Kinney, Michael D<mailto:email@example.com>; Leif Lindholm (Nuvia address)<mailto:firstname.lastname@example.org>
Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process
On May 25, 2020, at 11:10 AM, Laszlo Ersek <email@example.com> wrote:Laszlo,
Your wiki article was very very helpful. I just could not find it from the Tianocre wiki. It would be good if we could link to it from here , maybe as add to this: "Are you new to using git? If so, then the New to git page may be helpful."?
There are a lot folks who use git but don't use the email based review so they have never setup git with emali before. Your wiki, plus me figuring out the magic internal SMTP reflector (I reached out on an internal git malling list) is what got me unblocked.