Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64


Wu, Hao A
 

-----Original Message-----
From: Wu, Hao A
Sent: Wednesday, July 03, 2019 3:53 PM
To: 'Leif Lindholm'
Cc: devel@edk2.groups.io
Subject: RE: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association
for Arm/AArch64

-----Original Message-----
From: Leif Lindholm [mailto:leif.lindholm@...]
Sent: Saturday, June 15, 2019 4:21 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C; Gao, Liming; Andrew Fish; Laszlo Ersek; Kinney, Michael D;
Wu, Hao A
Subject: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for
Arm/AArch64

Add Ard and Leif as responsible for any path matching
F: */Arm/
F: */AArch64/

Signed-off-by: Leif Lindholm <leif.lindholm@...>
---
Maintainers.txt | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index cd32f9b00170..e415f51468d5 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -82,6 +82,14 @@ EDK II Releases:
W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-
Planning
M: Liming Gao <liming.gao@...>

+EDK II Architectures:
+---------------------
+ARM, AARCH64
+F: */AArch64/
+F: */Arm/

Hello Leif,

I want to confirm a couple of usage model for the wildcard character.

Maybe they have been explained with your response to Laszlo's comments,
but I just want to double-confirm with my using cases.

1. Matching multiple levels of directories

For the below 2 folders:
MdeModulePkg/Bus/Ufs/
MdeModulePkg/Bus/Pci/UfsPciHcDxe/

I can use:
MdeModulePkg/*Ufs*/

to match them all, right?


2. Matching header files (usually within the Include/ directory)

In some cases, a feature may include some drivers + some include header
files. So for the below case:
MdeModulePkg/Include/Library/HiiLib.h
MdeModulePkg/Include/Guid/HiiResourceSampleHii.h
MdeModulePkg/Universal/HiiDatabaseDxe/
MdeModulePkg/Universal/HiiResourcesSampleDxe/
MdeModulePkg/Library/UefiHiiLib/

Should I use:
MdeModulePkg/*Hii*/

to match the drivers(libraries) and the headers all or should I use:
MdeModulePkg/*Hii*/
MdeModulePkg/Include/*Hii*.h

instead?

Best Regards,
Hao Wu

Posting to the rfc list as well.

Best Regards,
Hao Wu




+M: Leif Lindholm <leif.lindholm@...>
+M: Ard Biesheuvel <ard.biesheuvel@...>
+
EDK II Packages:
----------------
ArmPkg
--
2.11.0

Join rfc@edk2.groups.io to automatically receive all group messages.