1. Edk2 | Discuss
  2. Topics

State of the `edk2-libc` project

Konstantin Aladyshev
 

Hello!

What is the state of the `edk2-libc` project?

The last commit is dated Apr 29, 2019. I've tried to compile
`edk2-libc` with the master `edk2` and have come to some build issues.

For example this edk2 commit (13 Oct 2020 "MdePkg: Remove code wrapped
by DISABLE_NEW_DEPRECATED_INTERFACES"
https://github.com/tianocore/edk2/commit/9c1f455f5f0ee63ce080940bf974aac4fefe526b)
have dropped support for several functions, but these functions are
still used in `edk2-libs`:
- `StrCpy` and `StrCpy` functions are used in
https://github.com/tianocore/edk2-libc/blob/master/StdLib/LibC/Wchar/Copying.c
- `AsciiStrCat` and `AsciiStrnCat` functions are used in
https://github.com/tianocore/edk2-libc/blob/master/StdLib/LibC/String/Concatenation.c
In the modern `edk2` all these old functions are replaced with their
safe versions (StrCpyS, StrCpyS, AsciiStrCatS, AsciiStrnCatS).

My question is should these unsafe string functions be deprecated in
the `edk2-libc` as well? And more importantly does the tianocore
community have any plans for support of `edk2-libc` project or can it
be counted as obsolete?

Best regards,
Konstantin Aladyshev

Rebecca Cran
 

I submitted a patch to fix it several weeks ago, but it never got committed.

Rebecca Cran

On Jul 14, 2021, at 11:36 AM, Konstantin Aladyshev <aladyshev22@...> wrote:

Hello!

What is the state of the `edk2-libc` project?

The last commit is dated Apr 29, 2019. I've tried to compile
`edk2-libc` with the master `edk2` and have come to some build issues.

For example this edk2 commit (13 Oct 2020 "MdePkg: Remove code wrapped
by DISABLE_NEW_DEPRECATED_INTERFACES"
https://github.com/tianocore/edk2/commit/9c1f455f5f0ee63ce080940bf974aac4fefe526b)
have dropped support for several functions, but these functions are
still used in `edk2-libs`:
- `StrCpy` and `StrCpy` functions are used in
https://github.com/tianocore/edk2-libc/blob/master/StdLib/LibC/Wchar/Copying.c
- `AsciiStrCat` and `AsciiStrnCat` functions are used in
https://github.com/tianocore/edk2-libc/blob/master/StdLib/LibC/String/Concatenation.c
In the modern `edk2` all these old functions are replaced with their
safe versions (StrCpyS, StrCpyS, AsciiStrCatS, AsciiStrnCatS).

My question is should these unsafe string functions be deprecated in
the `edk2-libc` as well? And more importantly does the tianocore
community have any plans for support of `edk2-libc` project or can it
be counted as obsolete?

Best regards,
Konstantin Aladyshev




Rebecca Cran <rebecca@...>
 

By the lack of replies, I suspect we should bring it up as a topic of discussion in the Community Meeting next week.


--
Rebecca Cran

On 7/14/21 1:43 PM, Rebecca Cran wrote:
I submitted a patch to fix it several weeks ago, but it never got committed.

Rebecca Cran
On Jul 14, 2021, at 11:36 AM, Konstantin Aladyshev <aladyshev22@...> wrote:

Hello!

What is the state of the `edk2-libc` project?

The last commit is dated Apr 29, 2019. I've tried to compile
`edk2-libc` with the master `edk2` and have come to some build issues.

For example this edk2 commit (13 Oct 2020 "MdePkg: Remove code wrapped
by DISABLE_NEW_DEPRECATED_INTERFACES"
https://github.com/tianocore/edk2/commit/9c1f455f5f0ee63ce080940bf974aac4fefe526b)
have dropped support for several functions, but these functions are
still used in `edk2-libs`:
- `StrCpy` and `StrCpy` functions are used in
https://github.com/tianocore/edk2-libc/blob/master/StdLib/LibC/Wchar/Copying.c
- `AsciiStrCat` and `AsciiStrnCat` functions are used in
https://github.com/tianocore/edk2-libc/blob/master/StdLib/LibC/String/Concatenation.c
In the modern `edk2` all these old functions are replaced with their
safe versions (StrCpyS, StrCpyS, AsciiStrCatS, AsciiStrnCatS).

My question is should these unsafe string functions be deprecated in
the `edk2-libc` as well? And more importantly does the tianocore
community have any plans for support of `edk2-libc` project or can it
be counted as obsolete?

Best regards,
Konstantin Aladyshev






1 - 3 of 3