PatchChecker LF failure not updating to see new CRLF ending


Clark-williams, Zachary
 

I'm submitting a PR for EDK2 to add 1 new file and edit 6 existing files. The 6 existing files all pass all checks and tests. The 1 new file had a error from patchchecker python script for LF on all lines. I've updated the branch and commited the file with CRLF line types, verified the change in the online editor, local notepad++ and VSCode as well as git autocrlf =true, yet the issue persists.

Anyone have an issue with this before?

PR: https://github.com/tianocore/edk2/pull/3197


Sean
 

For edk2, autocrlf should be false otherwise git will automatically change line endings on checkout and check in
________________________________
From: discuss@edk2.groups.io <discuss@edk2.groups.io> on behalf of zachary.clark-williams@... <zachary.clark-williams@...>
Sent: Tuesday, August 16, 2022 2:20:16 PM
To: discuss@edk2.groups.io <discuss@edk2.groups.io>
Subject: [edk2-discuss] PatchChecker LF failure not updating to see new CRLF ending

I'm submitting a PR for EDK2 to add 1 new file and edit 6 existing files. The 6 existing files all pass all checks and tests. The 1 new file had a error from patchchecker python script for LF on all lines. I've updated the branch and commited the file with CRLF line types, verified the change in the online editor, local notepad++ and VSCode as well as git autocrlf =true, yet the issue persists.

Anyone have an issue with this before?

PR: https://github.com/tianocore/edk2/pull/3197