Re: Pull request process for the edk2 repo


Laszlo Ersek
 

On 05/25/21 15:45, Satoshi Tanda wrote:
I received emails from devel@ today so will be good to go through the patch
review process. Thank you for assisting me on this (and checking the patch
as well)!
No problem; thanks for the bug report and the contribution!
Laszlo


Best,
Satoshi


On Tue, May 25, 2021 at 5:26 AM Laszlo Ersek <lersek@redhat.com> wrote:

On 05/24/21 07:05, Satoshi Tanda wrote:
Hi Laszlo,

Thank you for letting me know the process. That is very helpful. I
_believe_ I have sent the patch to the list (CC: you) and subscribed to
the
list as well. Let me know if it does not seem to be the case. I notice I
have not received the confirmation of subscription or my email yet so
something might not be quite right :-)
It worked out fine (I just commented on the patch).

groups.io allows list admins / moderators to moderate messages in two
ways, roughly:

- approve individual messages (from non-subscribers)
- permanently un-moderate a particular subscriber

Unfortunately, we can't add non-subscribers to the allow-list
permanently; messages sent by non-subscribers require manual action
every time. That's why I requested that you please subscribe, too.

And then, even after you subscribe, your initial messages will be held
for moderation until an admin or mod catches up on their mod
notifications, and actually adds you to the allow-list. In the meantime,
your message may appear stuck or lost to you.

Thanks!
Laszlo



Best,
Satoshi


On Sun, May 23, 2021 at 4:38 AM Laszlo Ersek <lersek@redhat.com> wrote:

Hello Satoshi-san,

On 05/21/21 23:30, Satoshi Tanda wrote:
Is there any documents and instructions I can follow to create a PR for
the edk2 repo by myself? I filed an issue to the edk2 repo, and I doubt
it
will be fixed by anyone very soon. Since the fix seems trivial, I could
submit a PR if that works.

Here is the ticket.

https://bugzilla.tianocore.org/show_bug.cgi?id=3405

How I can learn edk2’s PR process, or can anyone suggest what I could
do
to make it resolved?

Thanks for opening the ticket. I've added a comment to it, moved its
status to CONFIRMED, and (with your retroactive permission :)) assigned
the ticket to you.

For the time being, the edk2 project on github.com uses github.com pull
requests for two purposes:

- All contributors can open pull requests for setting off CI builds on
their topic branches.

- Edk2 maintainers can open pull requests and set the "push" label on
them. When CI completes on such a PR, the mergify bot proceeds to merge
the branch.

Edk2 maintainers open such pull requests for patches / patch series that
have been reviewed on the list. For the time being, patch review occurs
exclusively on the list. All patches should be sent to
<devel@edk2.groups.io> with git-send-email. Please subscribe at
<https://edk2.groups.io/g/devel> before posting.


Please see the development process article here:


https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process


An informal (non-normative) article with some additional details is
here:


https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers


Thanks!
Laszlo




Join discuss@edk2.groups.io to automatically receive all group messages.