Re: Issues with PatchCheck script

Laszlo Ersek

On 10/28/20 12:45, Sandeep Dhanvada wrote:

I have 2 local commits in EDK-II repo. As per the steps mentioned in,
I am executing, but, the execution of this script is giving below error. I see that the command used is "git show --pretty=%cn <%ce>, --no-patch, --no-use-mailmap, <CommitID>, but, as git complains that there is no --no-patch option for git show and also format for --pretty should be in quotes. I tried on git version and 2.1.1. Is there any specific git version needed to execute this script ?

python BaseTools/Scripts/ -1
Checking git commit: HEAD
Traceback (most recent call last):
File "BaseTools/Scripts/", line 770, in <module>
File "BaseTools/Scripts/", line 733, in __init__
File "BaseTools/Scripts/", line 747, in process_one_arg
self.ok &= CheckOneArg(arg, self.count).ok
File "BaseTools/Scripts/", line 714, in __init__
checker = CheckGitCommits(param, max_count)
File "BaseTools/Scripts/", line 650, in __init__
self.ok &= EmailAddressCheck(email, 'Committer').ok
File "BaseTools/Scripts/", line 36, in __init__
self.error('Email address is missing!')
File "BaseTools/Scripts/", line 47, in error
print('The ' + self.description + ' email address is not valid:')
AttributeError: EmailAddressCheck instance has no attribute 'description'

"--no-patch" appeared in 1.8.4, as a synonym for "-s".

Not sure why it doesn't work with 2.1.1 -- perhaps your old git instance
appears first on $PATH?


Join to automatically receive all group messages.