|
[PATCH 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue
3 messages
From: Ranbir Singh <Ranbir.Singh3@...> Line number 365 does contain a typecast with UINT32, but it is after all the operations (16-bit left shift followed by OR'ing) are over. To avoid any SIGN_EXTENS
From: Ranbir Singh <Ranbir.Singh3@...> Line number 365 does contain a typecast with UINT32, but it is after all the operations (16-bit left shift followed by OR'ing) are over. To avoid any SIGN_EXTENS
|
By
Ranbir Singh
·
|
|
[Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page
3 messages
Remove RO and NX protection when unset guard page. When UnsetGuardPage(), remove all the memory attribute protection for guarded page. Signed-off-by: Dun Tan <dun.tan@...> Cc: Liming Gao <gaoliming@..
Remove RO and NX protection when unset guard page. When UnsetGuardPage(), remove all the memory attribute protection for guarded page. Signed-off-by: Dun Tan <dun.tan@...> Cc: Liming Gao <gaoliming@..
|
By
duntan
·
|
|
[Patch V5 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry
2 messages
Remove code that apply AddressEncMask to non-leaf entry when split smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask bit
Remove code that apply AddressEncMask to non-leaf entry when split smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask bit
|
By
duntan
·
|
|
[Patch V5 04/14] UefiCpuPkg: Add DEBUG_CODE for special case when clear RP
2 messages
In ConvertMemoryPageAttributes() function, when clear RP for a specific range [BaseAddress, BaseAddress + Length], it means to set the present bit to 1 and assign default value for other attributes in
In ConvertMemoryPageAttributes() function, when clear RP for a specific range [BaseAddress, BaseAddress + Length], it means to set the present bit to 1 and assign default value for other attributes in
|
By
duntan
·
|
|
[Patch V5 05/14] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid setting non-present range to RO/NX
2 messages
In PiSmmCpuDxeSmm code, SetMemMapAttributes() marks memory ranges in SmmMemoryAttributesTable to RO/NX. There may exist non-present range in these memory ranges. Set other attributes for a non-present
In PiSmmCpuDxeSmm code, SetMemMapAttributes() marks memory ranges in SmmMemoryAttributesTable to RO/NX. There may exist non-present range in these memory ranges. Set other attributes for a non-present
|
By
duntan
·
|
|
[Patch V5 03/14] UefiCpuPkg: Use CpuPageTableLib to convert SMM paging attribute.
2 messages
Simplify the ConvertMemoryPageAttributes API to convert paging attribute by CpuPageTableLib. In the new API, it calls PageTableMap() to update the page attributes of a memory range. With the PageTable
Simplify the ConvertMemoryPageAttributes API to convert paging attribute by CpuPageTableLib. In the new API, it calls PageTableMap() to update the page attributes of a memory range. With the PageTable
|
By
duntan
·
|
|
[Patch V5 08/14] UefiCpuPkg: Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h
2 messages
Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h and remove extern for mSmmShadowStackSize in c files to simplify code. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Cc: Ray Ni <ray
Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h and remove extern for mSmmShadowStackSize in c files to simplify code. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Cc: Ray Ni <ray
|
By
duntan
·
|
|
[Patch V5 13/14] UefiCpuPkg: Refinement to smm runtime InitPaging() code
2 messages
This commit is code refinement to current smm runtime InitPaging() page table update code. In InitPaging(), if PcdCpuSmmProfileEnable is TRUE, use ConvertMemoryPageAttributes() API to map the range in
This commit is code refinement to current smm runtime InitPaging() page table update code. In InitPaging(), if PcdCpuSmmProfileEnable is TRUE, use ConvertMemoryPageAttributes() API to map the range in
|
By
duntan
·
|
|
[Patch V5 12/14] UefiCpuPkg: Sort mProtectionMemRange when ReadyToLock
2 messages
Sort mProtectionMemRange in InitProtectedMemRange() when ReadyToLock. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Cc: Ray Ni <ray.ni@...> Cc: Rahul Kumar <rahul1.kumar@...> Cc:
Sort mProtectionMemRange in InitProtectedMemRange() when ReadyToLock. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Cc: Ray Ni <ray.ni@...> Cc: Rahul Kumar <rahul1.kumar@...> Cc:
|
By
duntan
·
|
|
[Patch V5 11/14] UefiCpuPkg: Sort mSmmCpuSmramRanges in FindSmramInfo
2 messages
Sort mSmmCpuSmramRanges after get the SMRAM info in FindSmramInfo() function. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Cc: Ray Ni <ray.ni@...> Cc: Rahul Kumar <rahul1.kumar@.
Sort mSmmCpuSmramRanges after get the SMRAM info in FindSmramInfo() function. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Cc: Ray Ni <ray.ni@...> Cc: Rahul Kumar <rahul1.kumar@.
|
By
duntan
·
|
|
[Patch V5 09/14] UefiCpuPkg: Add GenSmmPageTable() to create smm page table
2 messages
This commit is code refinement to current smm pagetable generation code. Add a new GenSmmPageTable() API to create smm page table based on the PageTableMap() API in CpuPageTableLib. Caller only needs
This commit is code refinement to current smm pagetable generation code. Add a new GenSmmPageTable() API to create smm page table based on the PageTableMap() API in CpuPageTableLib. Caller only needs
|
By
duntan
·
|
|
[PATCH] UefiPayloadPkg: change capsulelib to null lib and move to bdsfv
From: MarsX Lin <marsx.lin@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4479 CapsuleRuntimeDxe consume null CapsuleLib instance and move the driver into BDSFV. then, platform code could
From: MarsX Lin <marsx.lin@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4479 CapsuleRuntimeDxe consume null CapsuleLib instance and move the driver into BDSFV. then, platform code could
|
By
marsx.lin@...
·
|
|
[PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.
3 messages
I create the PR: ShellPkg/SmbiosView: type 45 and type 46 support. by ZhichaoGao · Pull Request #4528 · tianocore/edk2 (github.com) But it fail because some CI canceled. Thanks, Zhichao
I create the PR: ShellPkg/SmbiosView: type 45 and type 46 support. by ZhichaoGao · Pull Request #4528 · tianocore/edk2 (github.com) But it fail because some CI canceled. Thanks, Zhichao
|
By
Gao, Zhichao
·
|
|
[PATCH 4/4] UefiCpuPkg: Init new MSR value for MtrrLib Unit Test
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Using new API GetMaxPlatformAddressBits, MtrrLib Unit Test needs to provide the value of MSR MSR_IA32_TME_CAPABILITY. Cc: Eric Dong <eric.dong@
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Using new API GetMaxPlatformAddressBits, MtrrLib Unit Test needs to provide the value of MSR MSR_IA32_TME_CAPABILITY. Cc: Eric Dong <eric.dong@
|
By
Zhiguang Liu
·
|
|
[PATCH 3/4] UefiCpuPkg: Clean up some Mtrr code using new API
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 With new API GetMaxPlatformAddressBits, the API MtrrLibInitializeMtrrMask and InitializeMtrrMask can be replaced. Cc: Eric Dong <eric.dong@...>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 With new API GetMaxPlatformAddressBits, the API MtrrLibInitializeMtrrMask and InitializeMtrrMask can be replaced. Cc: Eric Dong <eric.dong@...>
|
By
Zhiguang Liu
·
|
|
[PATCH 1/4] MdePkg: Add new API GetMaxPlatformAddressBits
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Add new API GetMaxPlatformAddressBits to get the max platform address bits. Max physical address bits can be get from CPUID. When TME-MK featur
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Add new API GetMaxPlatformAddressBits to get the max platform address bits. Max physical address bits can be get from CPUID. When TME-MK featur
|
By
Zhiguang Liu
·
|
|
[Patch V5 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove unnecessary function
Remove unnecessary function SetNotPresentPage(). We can directly use ConvertMemoryPageAttributes to set a range to non-present. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Revie
Remove unnecessary function SetNotPresentPage(). We can directly use ConvertMemoryPageAttributes to set a range to non-present. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Revie
|
By
duntan
·
|
|
[Patch V5 10/14] UefiCpuPkg: Use GenSmmPageTable() to create Smm S3 page table
Use GenSmmPageTable() to create both IA32 and X64 Smm S3 page table. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Reviewed-by: Ray Ni <ray.ni@...> Cc: Rahul Kumar <rahul1.kumar@.
Use GenSmmPageTable() to create both IA32 and X64 Smm S3 page table. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eric.dong@...> Reviewed-by: Ray Ni <ray.ni@...> Cc: Rahul Kumar <rahul1.kumar@.
|
By
duntan
·
|
|
[Patch V5 07/14] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR0.WP before modify page table
Clear CR0.WP before modify smm page table. Currently, there is an assumption that smm pagetable is always RW before ReadyToLock. However, when AMD SEV is enabled, FvbServicesSmm driver calls MemEncryp
Clear CR0.WP before modify smm page table. Currently, there is an assumption that smm pagetable is always RW before ReadyToLock. However, when AMD SEV is enabled, FvbServicesSmm driver calls MemEncryp
|
By
duntan
·
|
|
[Patch V5 06/14] UefiCpuPkg/PiSmmCpuDxeSmm: Add 2 function to disable/enable CR0.WP
Add two functions to disable/enable CR0.WP. These two unctions will also be used in later commits. This commit doesn't change any functionality. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eri
Add two functions to disable/enable CR0.WP. These two unctions will also be used in later commits. This commit doesn't change any functionality. Signed-off-by: Dun Tan <dun.tan@...> Cc: Eric Dong <eri
|
By
duntan
·
|