Topics

[PATCH v6 00/14] Add the VariablePolicy feature


Yao, Jiewen
 

Got it. Thanks!

 

From: gaoliming <gaoliming@...>
Sent: Wednesday, September 16, 2020 9:37 AM
To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...>; bret.barkelew@...; Wang, Jian J <jian.j.wang@...>; bret@...; Bi, Dandan <dandan.bi@...>
Cc: Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; 'Laszlo Ersek' <lersek@...>; 'Ard Biesheuvel' <ard.biesheuvel@...>; 'Andrew Fish' <afish@...>; Ni, Ray <ray.ni@...>
Subject: 回复: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Jiewen:

 I just forward the patch to your email address. Another way is to find the mail in web https://edk2.groups.io/g/devel/messages

 

Thanks

Liming

发件人: bounce+27952+65298+4905953+8761045@groups.io <bounce+27952+65298+4905953+8761045@groups.io> 代表 Yao, Jiewen
发送时间: 2020916 9:05
收件人: devel@edk2.groups.io; gaoliming@...; bret.barkelew@...; Wang, Jian J <jian.j.wang@...>; bret@...; Bi, Dandan <dandan.bi@...>
抄送: Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; 'Laszlo Ersek' <lersek@...>; 'Ard Biesheuvel' <ard.biesheuvel@...>; 'Andrew Fish' <afish@...>; Ni, Ray <ray.ni@...>
主题: Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Hi Bret/Liming

I checked my email and found that I have 9/14, 10/14, then 12/14, 13/14.

I don’t have 11/14 in my mailbox. That’s weird and embarrassing.

 

Could any of you forward 11/14 to me, so that I can review?

I apologize for the inconvenience.

 

Thank you

Yao Jiewen

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
Sent: Wednesday, September 16, 2020 8:55 AM
To: devel@edk2.groups.io; bret.barkelew@...; Wang, Jian J <jian.j.wang@...>; bret@...; Bi, Dandan <dandan.bi@...>
Cc: Yao, Jiewen <jiewen.yao@...>; Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; 'Laszlo Ersek' <lersek@...>; 'Ard Biesheuvel' <ard.biesheuvel@...>; 'Andrew Fish' <afish@...>; Ni, Ray <ray.ni@...>
Subject: 回复: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Bret:

 Patch 06 is for EmulatorPkg. Ray, Andrew are also the reviewers for this package.

 

Patch 11 is for SecurityPkg. Jian and Jiewen are the reviewer for this package.

 

Thanks

Liming

发件人: bounce+27952+65284+4905953+8761045@groups.io <bounce+27952+65284+4905953+8761045@groups.io> 代表 Bret Barkelew via groups.io
发送时间: 2020916 4:51
收件人: Wang, Jian J <jian.j.wang@...>; devel@edk2.groups.io; bret@...; Bi, Dandan <dandan.bi@...>
抄送: Yao, Jiewen <jiewen.yao@...>; Wu, Hao A <hao.a.wu@...>; liming.gao <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek <lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Andrew Fish <afish@...>; Ni, Ray <ray.ni@...>
主题: Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Thanks for the update, Jian. Dandan has submitted RBs on another thread.

 

That leaves patches 06 and 11.

 

Next up, Jordan Justen. How’s it going, Jordan. We’ve never spoken directly (to my knowledge) and that’s a shame.

If you had to eat a single food for the rest of your life, what would it be and can I have a Reviewed-by?

Keep in mind that you probably don’t want it to be particularly strong flavors; it’s going to get disgusting eventually.

I’d probably go with some simple red beans and rice or something.

 

- Bret

 

From: Wang, Jian J
Sent: Sunday, September 13, 2020 11:42 PM
To: Bret Barkelew; devel@edk2.groups.io; bret@...; Bi, Dandan
Cc: Yao, Jiewen; Wu, Hao A; liming.gao; Justen, Jordan L; Laszlo Ersek; Ard Biesheuvel; Andrew Fish; Ni, Ray
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Hi Bret,

 

Sorry to hear the Seattle’s situation. I’ve been there for several times and love the city very much. Hope everything goes back normal soon.

 

And sorry for slow response. This patch series have been delegated to Dandan to review by Liming. She has completed security review from Intel perspective, and given back comments to you. It seems that you forgot to include her in the CC-list. Sorry I didn’t notice it and told her to do review in time. She’ll give comments ASAP.

 

Since MdeModulePkg is a huge package, I cannot do detail review for each patch for this package. And we have already modules reviewers designated . I think, usually, they should do the detailed review first. The package maintainer will do gate-keeper works as the last step. Correct me if any misunderstanding here.

 

Removed Chao from cc-list (his email is not valid) and added Dandan in loop.

 

Regards,

Jian

 

From: Bret Barkelew <Bret.Barkelew@...>
Sent: Friday, September 11, 2020 11:18 PM
To: devel@edk2.groups.io; bret@...; Wang, Jian J <jian.j.wang@...>
Cc: Yao, Jiewen <jiewen.yao@...>; Zhang, Chao B <chao.b.zhang@...>; Wang, Jian J <jian.j.wang@...>; Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek <lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Andrew Fish <afish@...>; Ni, Ray <ray.ni@...>
Subject: RE: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

11 Days to go. I will single out an email every day…

 

Jian, today is your day.

How’s it going? Life good? Yeah, I know. Things are crazy here, too. Seattle is covered in smoke.

You know what would brighten things up, though? A nice “reviewed by”.

 

- Bret

 

From: Bret Barkelew via groups.io
Sent: Tuesday, September 8, 2020 3:20 PM
To: devel@edk2.groups.io; bret@...
Cc: Yao, Jiewen; Zhang, Chao B; Wang, Jian J; Wu, Hao A; liming.gao; Justen, Jordan L; Laszlo Ersek; Ard Biesheuvel; Andrew Fish; Ni, Ray; liming.gao
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Now that 2008 is labelled and everyone can take a breather… I still need reviews on the following patches (v7)…

Patch(es) 01, 02, 03,06,09,10,11,12,13,14

 

As such, the following email addresses may or may not be subscribed to CatFacts™ within the next 14 days if I get no responses:

Cc: Jian J Wang <jian.j.wang@...>
Cc: Hao A Wu <hao.a.wu@...>
Cc: Liming Gao <liming.gao@...>

Cc: Jordan Justen <jordan.l.justen@...>
Cc: Andrew Fish <afish@...>
Cc: Ray Ni <ray.ni@...>

Cc: Jiewen Yao <jiewen.yao@...>

Cc: Chao Zhang <chao.b.zhang@...>

 

May God have mercy on your inboxes.

 

- Bret

 

 

 


Bret Barkelew
 

Ha! I was *just* about to click the button to send the patch again. Glad you found it.

Let me know if you have any questions!

 

- Bret

 

From: Yao, Jiewen
Sent: Tuesday, September 15, 2020 6:44 PM
To: gaoliming; devel@edk2.groups.io; Bret Barkelew; Wang, Jian J; bret@...; Bi, Dandan
Cc: Wu, Hao A; liming.gao; Justen, Jordan L; 'Laszlo Ersek'; 'Ard Biesheuvel'; 'Andrew Fish'; Ni, Ray
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Got it. Thanks!

 

From: gaoliming <gaoliming@...>
Sent: Wednesday, September 16, 2020 9:37 AM
To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...>; bret.barkelew@...; Wang, Jian J <jian.j.wang@...>; bret@...; Bi, Dandan <dandan.bi@...>
Cc: Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; 'Laszlo Ersek' <lersek@...>; 'Ard Biesheuvel' <ard.biesheuvel@...>; 'Andrew Fish' <afish@...>; Ni, Ray <ray.ni@...>
Subject: 回复: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Jiewen:

 I just forward the patch to your email address. Another way is to find the mail in web https://edk2.groups.io/g/devel/messages

 

Thanks

Liming

发件人: bounce+27952+65298+4905953+8761045@groups.io <bounce+27952+65298+4905953+8761045@groups.io> 代表 Yao, Jiewen
发送时间: 2020916 9:05
收件人: devel@edk2.groups.io; gaoliming@...; bret.barkelew@...; Wang, Jian J <jian.j.wang@...>; bret@...; Bi, Dandan <dandan.bi@...>
抄送: Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; 'Laszlo Ersek' <lersek@...>; 'Ard Biesheuvel' <ard.biesheuvel@...>; 'Andrew Fish' <afish@...>; Ni, Ray <ray.ni@...>
主题: Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Hi Bret/Liming

I checked my email and found that I have 9/14, 10/14, then 12/14, 13/14.

I don’t have 11/14 in my mailbox. That’s weird and embarrassing.

 

Could any of you forward 11/14 to me, so that I can review?

I apologize for the inconvenience.

 

Thank you

Yao Jiewen

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
Sent: Wednesday, September 16, 2020 8:55 AM
To: devel@edk2.groups.io; bret.barkelew@...; Wang, Jian J <jian.j.wang@...>; bret@...; Bi, Dandan <dandan.bi@...>
Cc: Yao, Jiewen <jiewen.yao@...>; Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; 'Laszlo Ersek' <lersek@...>; 'Ard Biesheuvel' <ard.biesheuvel@...>; 'Andrew Fish' <afish@...>; Ni, Ray <ray.ni@...>
Subject: 回复: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Bret:

 Patch 06 is for EmulatorPkg. Ray, Andrew are also the reviewers for this package.

 

Patch 11 is for SecurityPkg. Jian and Jiewen are the reviewer for this package.

 

Thanks

Liming

发件人: bounce+27952+65284+4905953+8761045@groups.io <bounce+27952+65284+4905953+8761045@groups.io> 代表 Bret Barkelew via groups.io
发送时间: 2020916 4:51
收件人: Wang, Jian J <jian.j.wang@...>; devel@edk2.groups.io; bret@...; Bi, Dandan <dandan.bi@...>
抄送: Yao, Jiewen <jiewen.yao@...>; Wu, Hao A <hao.a.wu@...>; liming.gao <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek <lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Andrew Fish <afish@...>; Ni, Ray <ray.ni@...>
主题: Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Thanks for the update, Jian. Dandan has submitted RBs on another thread.

 

That leaves patches 06 and 11.

 

Next up, Jordan Justen. How’s it going, Jordan. We’ve never spoken directly (to my knowledge) and that’s a shame.

If you had to eat a single food for the rest of your life, what would it be and can I have a Reviewed-by?

Keep in mind that you probably don’t want it to be particularly strong flavors; it’s going to get disgusting eventually.

I’d probably go with some simple red beans and rice or something.

 

- Bret

 

From: Wang, Jian J
Sent: Sunday, September 13, 2020 11:42 PM
To: Bret Barkelew; devel@edk2.groups.io; bret@...; Bi, Dandan
Cc: Yao, Jiewen; Wu, Hao A; liming.gao; Justen, Jordan L; Laszlo Ersek; Ard Biesheuvel; Andrew Fish; Ni, Ray
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Hi Bret,

 

Sorry to hear the Seattle’s situation. I’ve been there for several times and love the city very much. Hope everything goes back normal soon.

 

And sorry for slow response. This patch series have been delegated to Dandan to review by Liming. She has completed security review from Intel perspective, and given back comments to you. It seems that you forgot to include her in the CC-list. Sorry I didn’t notice it and told her to do review in time. She’ll give comments ASAP.

 

Since MdeModulePkg is a huge package, I cannot do detail review for each patch for this package. And we have already modules reviewers designated . I think, usually, they should do the detailed review first. The package maintainer will do gate-keeper works as the last step. Correct me if any misunderstanding here.

 

Removed Chao from cc-list (his email is not valid) and added Dandan in loop.

 

Regards,

Jian

 

From: Bret Barkelew <Bret.Barkelew@...>
Sent: Friday, September 11, 2020 11:18 PM
To: devel@edk2.groups.io; bret@...; Wang, Jian J <jian.j.wang@...>
Cc: Yao, Jiewen <jiewen.yao@...>; Zhang, Chao B <chao.b.zhang@...>; Wang, Jian J <jian.j.wang@...>; Wu, Hao A <hao.a.wu@...>; Gao, Liming <liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek <lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Andrew Fish <afish@...>; Ni, Ray <ray.ni@...>
Subject: RE: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

11 Days to go. I will single out an email every day…

 

Jian, today is your day.

How’s it going? Life good? Yeah, I know. Things are crazy here, too. Seattle is covered in smoke.

You know what would brighten things up, though? A nice “reviewed by”.

 

- Bret

 

From: Bret Barkelew via groups.io
Sent: Tuesday, September 8, 2020 3:20 PM
To: devel@edk2.groups.io; bret@...
Cc: Yao, Jiewen; Zhang, Chao B; Wang, Jian J; Wu, Hao A; liming.gao; Justen, Jordan L; Laszlo Ersek; Ard Biesheuvel; Andrew Fish; Ni, Ray; liming.gao
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

 

Now that 2008 is labelled and everyone can take a breather… I still need reviews on the following patches (v7)…

Patch(es) 01, 02, 03,06,09,10,11,12,13,14

 

As such, the following email addresses may or may not be subscribed to CatFacts™ within the next 14 days if I get no responses:

Cc: Jian J Wang <jian.j.wang@...>
Cc: Hao A Wu <hao.a.wu@...>
Cc: Liming Gao <liming.gao@...>

Cc: Jordan Justen <jordan.l.justen@...>
Cc: Andrew Fish <afish@...>
Cc: Ray Ni <ray.ni@...>

Cc: Jiewen Yao <jiewen.yao@...>

Cc: Chao Zhang <chao.b.zhang@...>

 

May God have mercy on your inboxes.

 

- Bret