Topics

[PATCH v3 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK


PierreGondois
 

From: Pierre Gondois <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3


Notes:
v3:
- Remove ScmiMessageIdBasexxx related changes. [Sami]

ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 10 +++++-----
ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 10 +++++-----
2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
index b7892bfd7771..9cd3a7ed232d 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
@@ -123,7 +123,7 @@ ClockGetClockAttributes (
*MessageParams = ClockId;

Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_ATTRIBUTES;
+ Cmd.MessageId = ScmiMessageIdClockAttributes;

PayloadLength = sizeof (ClockId);

@@ -204,7 +204,7 @@ ClockDescribeRates (
}

Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_DESCRIBE_RATES;
+ Cmd.MessageId = ScmiMessageIdClockDescribeRates;

*MessageParams++ = ClockId;

@@ -321,7 +321,7 @@ ClockRateGet (
*MessageParams = ClockId;

Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_RATE_GET;
+ Cmd.MessageId = ScmiMessageIdClockRateGet;

PayloadLength = sizeof (ClockId);

@@ -375,7 +375,7 @@ ClockRateSet (
ClockRateSetAttributes->Rate.High = (UINT32)(Rate >> 32);

Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_RATE_SET;
+ Cmd.MessageId = ScmiMessageIdClockRateSet;

PayloadLength = sizeof (CLOCK_RATE_SET_ATTRIBUTES);

@@ -422,7 +422,7 @@ ClockEnable (
ClockConfigSetAttributes->Attributes = Enable ? BIT0 : 0;

Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_CONFIG_SET;
+ Cmd.MessageId = ScmiMessageIdClockConfigSet;

PayloadLength = sizeof (CLOCK_CONFIG_SET_ATTRIBUTES);

diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
index 85b5b8d1e764..cd62f05a58fd 100644
--- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
+++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
@@ -22,11 +22,11 @@ extern EFI_GUID gArmScmiClockProtocolGuid;

// Message Type for clock management protocol.
typedef enum {
- SCMI_MESSAGE_ID_CLOCK_ATTRIBUTES = 0x3,
- SCMI_MESSAGE_ID_CLOCK_DESCRIBE_RATES = 0x4,
- SCMI_MESSAGE_ID_CLOCK_RATE_SET = 0x5,
- SCMI_MESSAGE_ID_CLOCK_RATE_GET = 0x6,
- SCMI_MESSAGE_ID_CLOCK_CONFIG_SET = 0x7
+ ScmiMessageIdClockAttributes = 0x3,
+ ScmiMessageIdClockDescribeRates = 0x4,
+ ScmiMessageIdClockRateSet = 0x5,
+ ScmiMessageIdClockRateGet = 0x6,
+ ScmiMessageIdClockConfigSet = 0x7
} SCMI_MESSAGE_ID_CLOCK;

typedef enum {
--
2.17.1


Sami Mujawar
 

Reviewed-by: Sami Mujawar <sami.mujawar@...>

Regards,

Sami Mujawar