Topics

[PATCH v3 22/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID


PierreGondois
 

From: Pierre Gondois <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3

ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 6 +++---
ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
index a1bf1b95c052..3793c0663666 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
@@ -195,7 +195,7 @@ ScmiGetProtocolVersion (

Status = ScmiProtocolDiscoveryCommon (
ProtocolId,
- SCMI_MESSAGE_ID_PROTOCOL_VERSION,
+ ScmiMessageIdProtocolVersion,
(UINT32**)&ProtocolVersion
);
if (EFI_ERROR (Status)) {
@@ -224,7 +224,7 @@ ScmiGetProtocolAttributes (
{
return ScmiProtocolDiscoveryCommon (
ProtocolId,
- SCMI_MESSAGE_ID_PROTOCOL_ATTRIBUTES,
+ ScmiMessageIdProtocolAttributes,
ReturnValues
);
}
@@ -246,7 +246,7 @@ ScmiGetProtocolMessageAttributes (
{
return ScmiProtocolDiscoveryCommon (
ProtocolId,
- SCMI_MESSAGE_ID_PROTOCOL_MESSAGE_ATTRIBUTES,
+ ScmiMessageIdProtocolMessageAttributes,
ReturnValues
);
}
diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h
index 118961dbe219..e56c9e0dc342 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h
@@ -45,9 +45,9 @@ typedef enum {

// SCMI message IDs common to all protocols.
typedef enum {
- SCMI_MESSAGE_ID_PROTOCOL_VERSION = 0x0,
- SCMI_MESSAGE_ID_PROTOCOL_ATTRIBUTES = 0x1,
- SCMI_MESSAGE_ID_PROTOCOL_MESSAGE_ATTRIBUTES = 0x2
+ ScmiMessageIdProtocolVersion = 0x0,
+ ScmiMessageIdProtocolAttributes = 0x1,
+ ScmiMessageIdProtocolMessageAttributes = 0x2
} SCMI_MESSAGE_ID;

// Not defined in SCMI specification but will help to identify a message.
--
2.17.1