[Patch V2 0/3] Remove git reset and optimize


Michael D Kinney
 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986

New in V2
----------
* Change temp directory path from Build/ecctemp to
Build/.pytool/Plugin/EccCheck to provide a unique
temp directory location for any .pytool Plugin.
* Set working directory when ECC runs to temp directory
to guarantee all temp files created by EccCheck are
cleaned up.

* Use temp directory for all operations to prevent any
changed to git state.
* Remove git reset operation that could corrupt staged
and local changes.
* Improve performance by removing redundant directory scans
* Improve performance and reduce log file sizes by using
--output option of git diff to a temp file instead of
using stdout.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (3):
.pytool/Plugin/EccCheck: Remove RevertCode()
.pytool/Plugin/EccCheck: Remove temp directory on exception
.pytool/Plugin/EccCheck: Add performance optimizations

.pytool/Plugin/EccCheck/EccCheck.py | 242 +++++++++++++++++++---------
1 file changed, 169 insertions(+), 73 deletions(-)

--
2.32.0.windows.1


Sean
 

Acked-by: Sean Brogan <sean.brogan@microsoft.com>

On 11/23/2021 8:30 AM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986
New in V2
----------
* Change temp directory path from Build/ecctemp to
Build/.pytool/Plugin/EccCheck to provide a unique
temp directory location for any .pytool Plugin.
* Set working directory when ECC runs to temp directory
to guarantee all temp files created by EccCheck are
cleaned up.
* Use temp directory for all operations to prevent any
changed to git state.
* Remove git reset operation that could corrupt staged
and local changes.
* Improve performance by removing redundant directory scans
* Improve performance and reduce log file sizes by using
--output option of git diff to a temp file instead of
using stdout.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Michael D Kinney (3):
.pytool/Plugin/EccCheck: Remove RevertCode()
.pytool/Plugin/EccCheck: Remove temp directory on exception
.pytool/Plugin/EccCheck: Add performance optimizations
.pytool/Plugin/EccCheck/EccCheck.py | 242 +++++++++++++++++++---------
1 file changed, 169 insertions(+), 73 deletions(-)