Topics

[PATCH v2 00/19] Fix Vlv2TbltDevicePkg gcc build


Gary Lin
 

This series amend the build script of Vlv2TbltDevicePkg and fix the
error messages from gcc. I've built the firmware with gcc 6.1.1 on openSUSE
Tumbleweed, and the firmware binary[*] was generated successfully (but not
guaranteed to work).

[*] Vlv2TbltDevicePkg/Stitch/MNW2MAX_X64_D_0093_01_GCC.bin

The patches are also available in my github branch:
https://github.com/lcp/edk2/tree/Vlv2-gcc-fix-v2-platforms

Changes in v2:
1. Instead of removing MDEPKG_NDEBUG completely, amend the CFLAG to define
MDEPKG_NDEBUG only for the gcc release build.
2. Remove the variable Hob and the related code from IchRcrbInit() in
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c.
3. Include UefiBootServicesTableLib.h in PlatformGopPolicy/PlatformGopPolicy.c
so that we don't have to declare gBS.
4. Rebase the patchset on minnowboard-max-udk2015 of
https://github.com/tianocore/edk2-platforms.git instead of the master of
https://github.com/tianocore/edk2.git. Besides the patches of this series,
minnowboard-max-udk2015 needs a few more commits from edk2.git to make it
work with gcc6:
* NetworkPkg: fix ASSERT_EFI_ERROR() typos
* EdkCompatibilityPkg: fix ASSERT_EFI_ERROR() typos
* Vlv2TbltDevicePkg: fix ASSERT_EFI_ERROR() typos
* CryptoPkg/BaseCryptLib: Add missing OpenSSL includes
* CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage
* CryptoPkg: Fix OpenSSL BN wordsize and OPENSSL_SYS_UEFI handling
For convenience, I merged all the patches before and include openssl 1.0.2h
update in my branch.

Gary Lin (19):
Vlv2TbltDevicePkg: Amend the build script
Vlv2TbltDevicePkg: Only define MDEPKG_NDEBUG for gcc release build
Vlv2TbltDevicePkg/MultiPlatformLib: Remove the unused variables
Vlv2TbltDevicePkg/PlatformPei: Remove the unused variable
Vlv2TbltDevicePkg/PlatformBdsLib: Remove the unused variable
Vlv2TbltDevicePkg/PlatformInitPei: Remove the unused variables
Vlv2TbltDevicePkg/PlatformInitPei: Suppress the gcc error message
Vlv2TbltDevicePkg/AcpiPlatform: Remove unused variables
Vlv2TbltDevicePkg/AcpiPlatform: Amend the declaration of mGlobalNvsArea
Vlv2TbltDevicePkg/PlatformGopPolicy: include UefiBootServicesTableLib.h
Vlv2DeviceRefCodePkg/ValleyView2Soc: Remove the unused code
Vlv2TbltDevicePkg/FvbRuntimeDxe: Remove unused variables
Vlv2TbltDevicePkg/PlatformSetupDxe: Remove the unused variables
Vlv2TbltDevicePkg/VlvPlatformInitDxe: Remove unused variables
Vlv2TbltDevicePkg/PlatformDxe: Remove the unused variables
Vlv2TbltDevicePkg/Wpce791: Remove the unused variable
Vlv2TbltDevicePkg/SmBiosMiscDxe: Remove unused variables
Vlv2TbltDevicePkg/PpmPolicy: Remove the usage of global variables
Vlv2TbltDevicePkg/PpmPolicy: Remove the unused variable

.../SouthCluster/Include/PchAccess.h | 49 -----
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 9 +-
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.h | 2 +-
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatformHooks.c | 4 +-
Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c | 11 --
.../MultiPlatformLib/BoardClkGens/BoardClkGens.c | 5 +-
.../Library/MultiPlatformLib/MultiPlatformLib.c | 53 ++---
.../Library/PlatformBdsLib/BdsPlatform.c | 3 +-
Vlv2TbltDevicePkg/PlatformDxe/IchRegTable.c | 2 -
Vlv2TbltDevicePkg/PlatformDxe/PciDevice.c | 214 ++++++++++-----------
Vlv2TbltDevicePkg/PlatformDxe/Platform.c | 40 ++--
.../PlatformGopPolicy/PlatformGopPolicy.c | 4 +-
Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c | 2 -
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c | 12 --
.../PlatformInitPei/PlatformEarlyInit.c | 1 +
Vlv2TbltDevicePkg/PlatformPei/MemoryCallback.c | 9 +-
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 +-
.../PlatformSetupDxe/SetupInfoRecords.c | 41 ++--
Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c | 13 +-
Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.h | 6 +-
.../SmBiosMiscDxe/MiscOemType0x90Function.c | 5 -
.../SmBiosMiscDxe/MiscProcessorCacheFunction.c | 2 -
.../MiscProcessorInformationFunction.c | 2 -
Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c | 4 -
Vlv2TbltDevicePkg/Wpce791/LpcDriver.c | 4 -
Vlv2TbltDevicePkg/bld_vlv.sh | 24 ++-
26 files changed, 203 insertions(+), 320 deletions(-)

--
2.9.2