[PATCH v1] MinPlatformPkg: Add PcdAcpiGpe1BlockLength for FADT from board package


Chiu, Chasel
 

Reviewed-by: Chasel Chiu <chasel.chiu@...>

-----Original Message-----
From: Chen, Aryeh <aryeh.chen@...>
Sent: Monday, August 15, 2022 1:36 AM
To: devel@edk2.groups.io
Cc: Chen, Aryeh <aryeh.chen@...>; Chiu, Chasel
<chasel.chiu@...>; Desimone, Nathaniel L
<nathaniel.l.desimone@...>; Oram, Isaac W <isaac.w.oram@...>;
Gao, Liming <gaoliming@...>; Dong, Eric <eric.dong@...>
Subject: [PATCH v1] MinPlatformPkg: Add PcdAcpiGpe1BlockLength for FADT
from board package

From: Aryeh Chen <aryeh.chen@...>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4020

Add PcdAcpiGpe1BlockLength of FADT Gpe1BlkLen register on MinPlatformPkg
for PlatformBoardpkg to update platform setting.

Signed-off-by: Aryeh Chen <aryeh.chen@...>
Cc: Chasel Chiu <chasel.chiu@...>
Cc: Nate DeSimone <nathaniel.l.desimone@...>
Cc: Isaac Oram <isaac.w.oram@...>
Cc: Liming Gao <gaoliming@...>
Cc: Eric Dong <eric.dong@...>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 ++-
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index f134c8a58f..6e57b638e0 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -88,7 +88,7 @@ EFI_STATUS
AppendCpuMapTableEntry ( IN VOID *ApicPtr, IN UINT32
LocalApicCounter,- IN EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable + IN
EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable ) { EFI_STATUS Status;@@
-1111,6 +1111,7 @@ PlatformUpdateTables (
FadtHeader->Gpe0Blk = PcdGet16 (PcdAcpiGpe0BlockAddress);
FadtHeader->Gpe0BlkLen = PcdGet8 (PcdAcpiGpe0BlockLength);
FadtHeader->Gpe1Blk = PcdGet16 (PcdAcpiGpe1BlockAddress);+
FadtHeader->Gpe1BlkLen = PcdGet8 (PcdAcpiGpe1BlockLength);
FadtHeader->Gpe1Base = PcdGet8 (PcdAcpiGpe1Base);
FadtHeader->XPm1aEvtBlk.Address = PcdGet16
(PcdAcpiPm1AEventBlockAddress);diff --git
a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 89350828d6..451034fb8a 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -84,6 +84,7 @@
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress+
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockLength
gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSizediff --git
a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
index db0a19066f..8e603b7bf9 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -123,6 +123,7 @@

gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0
x0001003B
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x000
1003C
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT16|0
x0001003D+
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockLength|0x00|UINT8|0x000
1003E
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x00010040
gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize|0x00|UINT8
|0x00010042 --
2.26.2.windows.1


Chen, Aryeh
 

From: Aryeh Chen <aryeh.chen@...>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4020

Add PcdAcpiGpe1BlockLength of FADT Gpe1BlkLen register on
MinPlatformPkg for PlatformBoardpkg to update platform setting.

Signed-off-by: Aryeh Chen <aryeh.chen@...>
Cc: Chasel Chiu <chasel.chiu@...>
Cc: Nate DeSimone <nathaniel.l.desimone@...>
Cc: Isaac Oram <isaac.w.oram@...>
Cc: Liming Gao <gaoliming@...>
Cc: Eric Dong <eric.dong@...>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 ++-
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b=
/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index f134c8a58f..6e57b638e0 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -88,7 +88,7 @@ EFI_STATUS
AppendCpuMapTableEntry (=0D
IN VOID *ApicPtr,=0D
IN UINT32 LocalApicCounter,=0D
- IN EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable =0D
+ IN EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable=0D
)=0D
{=0D
EFI_STATUS Status;=0D
@@ -1111,6 +1111,7 @@ PlatformUpdateTables (
FadtHeader->Gpe0Blk =3D PcdGet16 (PcdAcpiGpe=
0BlockAddress);=0D
FadtHeader->Gpe0BlkLen =3D PcdGet8 (PcdAcpiGpe0=
BlockLength);=0D
FadtHeader->Gpe1Blk =3D PcdGet16 (PcdAcpiGpe=
1BlockAddress);=0D
+ FadtHeader->Gpe1BlkLen =3D PcdGet8 (PcdAcpiGpe1=
BlockLength);=0D
FadtHeader->Gpe1Base =3D PcdGet8 (PcdAcpiGpe1=
Base);=0D
=0D
FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 (PcdAcpiPm1=
AEventBlockAddress);=0D
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf=
b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 89350828d6..451034fb8a 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -84,6 +84,7 @@
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress=0D
+ gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockLength=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize=0D
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/In=
tel/MinPlatformPkg/MinPlatformPkg.dec
index db0a19066f..8e603b7bf9 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -123,6 +123,7 @@
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x00=
01003B=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x000100=
3C=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT16|0x00=
01003D=0D
+ gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockLength|0x00|UINT8|0x000100=
3E=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x00010040=0D
gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize|0x00|UINT8|=
0x00010042=0D
=0D
--=20
2.26.2.windows.1


Chiu, Chasel
 

-----Original Message-----
From: Chen, Aryeh <aryeh.chen@...>
Sent: Monday, August 15, 2022 1:36 AM
To: devel@edk2.groups.io
Cc: Chen, Aryeh <aryeh.chen@...>; Chiu, Chasel
<chasel.chiu@...>; Desimone, Nathaniel L
<nathaniel.l.desimone@...>; Oram, Isaac W <isaac.w.oram@...>;
Gao, Liming <gaoliming@...>; Dong, Eric <eric.dong@...>
Subject: [PATCH v1] MinPlatformPkg: Add PcdAcpiGpe1BlockLength for FADT
from board package

From: Aryeh Chen <aryeh.chen@...>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4020

Add PcdAcpiGpe1BlockLength of FADT Gpe1BlkLen register on MinPlatformPkg
for PlatformBoardpkg to update platform setting.

Signed-off-by: Aryeh Chen <aryeh.chen@...>
Cc: Chasel Chiu <chasel.chiu@...>
Cc: Nate DeSimone <nathaniel.l.desimone@...>
Cc: Isaac Oram <isaac.w.oram@...>
Cc: Liming Gao <gaoliming@...>
Cc: Eric Dong <eric.dong@...>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 ++-
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index f134c8a58f..6e57b638e0 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -88,7 +88,7 @@ EFI_STATUS
AppendCpuMapTableEntry ( IN VOID *ApicPtr, IN UINT32
LocalApicCounter,- IN EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable + IN
EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable ) { EFI_STATUS Status;@@
-1111,6 +1111,7 @@ PlatformUpdateTables (
FadtHeader->Gpe0Blk = PcdGet16 (PcdAcpiGpe0BlockAddress);
FadtHeader->Gpe0BlkLen = PcdGet8 (PcdAcpiGpe0BlockLength);
FadtHeader->Gpe1Blk = PcdGet16 (PcdAcpiGpe1BlockAddress);+
FadtHeader->Gpe1BlkLen = PcdGet8 (PcdAcpiGpe1BlockLength);
FadtHeader->Gpe1Base = PcdGet8 (PcdAcpiGpe1Base);
FadtHeader->XPm1aEvtBlk.Address = PcdGet16
(PcdAcpiPm1AEventBlockAddress);diff --git
a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 89350828d6..451034fb8a 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -84,6 +84,7 @@
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress+
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockLength
gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize
gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSizediff --git
a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
index db0a19066f..8e603b7bf9 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -123,6 +123,7 @@

gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0
x0001003B
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x000
1003C
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT16|0
x0001003D+
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockLength|0x00|UINT8|0x000
1003E
gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x00010040
gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegisterAccessSize|0x00|UINT8
|0x00010042 --
2.26.2.windows.1