[PATCH v1 1/1] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments


Dimitrije Pavlov
 

The current implementation does not check if Language or DriverName
are NULL. This causes the SCT test suite to crash.

Add a check to return EFI_INVALID_PARAMETER if any of these pointers
are NULL.

Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Sunny Wang <Sunny.Wang@...>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@...>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>

Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@...>
---
OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/DriverBinding.c
index 86eb9cf0ba51..3d80ff0f91f5 100644
--- a/OvmfPkg/VirtioFsDxe/DriverBinding.c
+++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c
@@ -218,6 +218,10 @@ VirtioFsGetDriverName (
OUT CHAR16 **DriverName
)
{
+ if (Language == NULL || DriverName == NULL) {
+ return EFI_INVALID_PARAMETER;
+ }
+
if (AsciiStrCmp (Language, "en") != 0) {
return EFI_UNSUPPORTED;
}
--
2.37.1


Ard Biesheuvel
 

On Mon, 15 Aug 2022 at 16:59, Dimitrije Pavlov <Dimitrije.Pavlov@...> wrote:

The current implementation does not check if Language or DriverName
are NULL. This causes the SCT test suite to crash.

Add a check to return EFI_INVALID_PARAMETER if any of these pointers
are NULL.

Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Sunny Wang <Sunny.Wang@...>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@...>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>

Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@...>
Hello Dimitrije,

These patches look corrupted again. Can you please double check your
setup, and maybe compare notes with colleagues how to send patches to
the list in a way that doesn't corrupt them?

And when you resubmit, please cc liming gao as well - he is in charge
of the stable tag release process, and these are all bug fixes that
should be included in the tag. Also, please turn these individual
patches into a single series.


---
OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/DriverBinding.c
index 86eb9cf0ba51..3d80ff0f91f5 100644
--- a/OvmfPkg/VirtioFsDxe/DriverBinding.c
+++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c
@@ -218,6 +218,10 @@ VirtioFsGetDriverName (
OUT CHAR16 **DriverName
)
{
+ if (Language NULL || DriverName NULL) {
+ return EFI_INVALID_PARAMETER;
+ }
+
if (AsciiStrCmp (Language, "en") ! 0) {
return EFI_UNSUPPORTED;
}
--
2.37.1



------------
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92434): https://edk2.groups.io/g/devel/message/92434
Mute This Topic: https://groups.io/mt/93038111/5717338
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@...]
------------