[PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL


Kavya
 

Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration
to FALSE when root bridge count is zero.

Cc: Guo Dong <guo.dong@...>
Cc: Ray Ni <ray.ni@...>
Cc: Sean Rhodes <sean@...>
Cc: Gua Guo <gua.guo@...>
Signed-off-by: Kavya <k.kavyax.sravanthi@...>
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
index e1faa24ae7..fb76853072 100644
--- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
+++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
@@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob (
}

if (PciRootBridgeInfo->Count == 0) {
+ PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
return NULL;
}

@@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob (
if (PciRootBridgeInfo->ResourceAssigned) {
PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE);
} else {
- DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is FALSE\n"));
+ DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is FALSE\n"));
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
- return NULL;
}

return PciRootBridges;
--
2.30.2.windows.1


Guo, Gua <gua.guo@...>
 

Reviewd-by: Gua Guo <gua.guo@...>

-----Original Message-----
From: Sravanthi, K KavyaX <k.kavyax.sravanthi@...>
Sent: Thursday, August 11, 2022 3:08 PM
To: devel@edk2.groups.io
Cc: Sravanthi, K KavyaX <k.kavyax.sravanthi@...>; Dong, Guo <guo.dong@...>; Ni, Ray <ray.ni@...>; Rhodes, Sean <sean@...>; Guo, Gua <gua.guo@...>
Subject: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL

Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration to FALSE when root bridge count is zero.

Cc: Guo Dong <guo.dong@...>
Cc: Ray Ni <ray.ni@...>
Cc: Sean Rhodes <sean@...>
Cc: Gua Guo <gua.guo@...>
Signed-off-by: Kavya <k.kavyax.sravanthi@...>
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
index e1faa24ae7..fb76853072 100644
--- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
+++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
@@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob (
}

if (PciRootBridgeInfo->Count == 0) {
+ PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
return NULL;
}

@@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob (
if (PciRootBridgeInfo->ResourceAssigned) {
PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE);
} else {
- DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is FALSE\n"));
+ DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is
+ FALSE\n"));
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
- return NULL;
}

return PciRootBridges;
--
2.30.2.windows.1


Guo Dong
 

Reviewed-by: Guo Dong <guo.dong@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of kavya
Sent: Thursday, August 11, 2022 12:08 AM
To: devel@edk2.groups.io
Cc: Sravanthi, K KavyaX <k.kavyax.sravanthi@...>; Dong, Guo <guo.dong@...>; Ni, Ray <ray.ni@...>; Rhodes, Sean <sean@...>; Guo, Gua <gua.guo@...>
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL

Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration to FALSE when root bridge count is zero.

Cc: Guo Dong <guo.dong@...>
Cc: Ray Ni <ray.ni@...>
Cc: Sean Rhodes <sean@...>
Cc: Gua Guo <gua.guo@...>
Signed-off-by: Kavya <k.kavyax.sravanthi@...>
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
index e1faa24ae7..fb76853072 100644
--- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
+++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
@@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob (
}

if (PciRootBridgeInfo->Count == 0) {
+ PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
return NULL;
}

@@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob (
if (PciRootBridgeInfo->ResourceAssigned) {
PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE);
} else {
- DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is FALSE\n"));
+ DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is
+ FALSE\n"));
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
- return NULL;
}

return PciRootBridges;
--
2.30.2.windows.1