devel@edk2.groups.io | [PATCH] UefiCpuPkg/Test: Disable random test cases

Home Messages Hashtags Subgroups Calendar

Date Date 1 - 8 of 8

[PATCH] UefiCpuPkg/Test: Disable random test cases

Ni, Ray #102326 The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni <ray.ni@...> --- .../UnitTest/CpuPageTableLibUnitTestHost.c \| 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUni= tTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUn= itTestHost.c index 547f6c2e50..745b774c66 100644 --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHo= st.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHo= st.c @@ -881,11 +881,11 @@ UefiTestMain ( goto EXIT;=0D }=0D =0D - AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Tes= t Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);=0D - AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random T= est Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB= );=0D - AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Tes= t Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);=0D - AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random T= est Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB= );=0D - AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test C= ase5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);=0D + // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random = Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level);= =0D + // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Rando= m Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level= 1GB);=0D + // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random = Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level);= =0D + // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Rando= m Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level= 1GB);=0D + // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Tes= t Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae);=0D =0D //=0D // Execute the tests.=0D --=20 2.39.1.windows.1
More All Messages By This Member
Ni, Ray #102327 toggle quoted message Show quoted text -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray Sent: Saturday, April 1, 2023 2:22 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni <ray.ni@...> --- .../UnitTest/CpuPageTableLibUnitTestHost.c \| 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest Host.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest Host.c index 547f6c2e50..745b774c66 100644 --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest Host.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest Host.c @@ -881,11 +881,11 @@ UefiTestMain ( goto EXIT; } - AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); - AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); - AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); - AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); - AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); + // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); // // Execute the tests. -- 2.39.1.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102326): https://edk2.groups.io/g/devel/message/102326 Mute This Topic: https://groups.io/mt/97979483/1712937 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3759105/1712937/893644498/xyzzy [ray.ni@...] -=-=-=-=-=-=
More All Messages By This Member
Michael Kubacki #102329 Reviewed-by: Michael Kubacki <michael.kubacki@...> toggle quoted message Show quoted text On 3/31/2023 2:22 PM, Ni, Ray wrote: The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni <ray.ni@...> --- .../UnitTest/CpuPageTableLibUnitTestHost.c \| 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c index 547f6c2e50..745b774c66 100644 --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c @@ -881,11 +881,11 @@ UefiTestMain ( goto EXIT; } - AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); - AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); - AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); - AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); - AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); + // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); // // Execute the tests.
More All Messages By This Member
Sean #102330 Thanks Ray. Lets discuss this style of testing next week at the tools and CI meeting. Reviewed-by: Sean Brogan <sean.brogan@...> toggle quoted message Show quoted text On 3/31/2023 11:22 AM, Ni, Ray wrote: The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni <ray.ni@...> --- .../UnitTest/CpuPageTableLibUnitTestHost.c \| 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c index 547f6c2e50..745b774c66 100644 --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c @@ -881,11 +881,11 @@ UefiTestMain ( goto EXIT; } - AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); - AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); - AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); - AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); - AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); + // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); // // Execute the tests.
More All Messages By This Member
Rebecca Cran #102333 I've been wondering, is it possible to increase the parallelism or add more resources to the CI runner pool? -- Rebecca Cran toggle quoted message Show quoted text On 3/31/23 12:22 PM, Ni, Ray wrote: The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni <ray.ni@...> --- .../UnitTest/CpuPageTableLibUnitTestHost.c \| 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c index 547f6c2e50..745b774c66 100644 --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c @@ -881,11 +881,11 @@ UefiTestMain ( goto EXIT; } - AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); - AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); - AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); - AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); - AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random Test Case1", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level); + // AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", "Random Test Case2", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging4Level1GB); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random Test Case3", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level); + // AddTestCase (RandomTestCase, "Random Test for Paging5Level1G", "Random Test Case4", TestCaseforRandomTest, NULL, NULL, &mTestContextPaging5Level1GB); + // AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random Test Case5", TestCaseforRandomTest, NULL, NULL, &mTestContextPagingPae); // // Execute the tests.
More All Messages By This Member
Michael Kubacki #102335 I'm not sure about the availability of more resources but something like merge queue might be able to help. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue This presentation has an overview - https://www.youtube.com/watch?v=04TTRJArpVw. toggle quoted message Show quoted text On 3/31/2023 6:08 PM, Rebecca Cran wrote: I've been wondering, is it possible to increase the parallelism or add more resources to the CI runner pool?
More All Messages By This Member
Michael D Kinney #102336 Michael, I see older PRs from dependabot still running jobs. Is there a way to configure how often those checks are made? Mike toggle quoted message Show quoted text -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki Sent: Friday, March 31, 2023 4:00 PM To: devel@edk2.groups.io; rebecca@...; Ni, Ray <ray.ni@...> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases I'm not sure about the availability of more resources but something like merge queue might be able to help. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request- merges/managing-a-merge-queue This presentation has an overview - https://www.youtube.com/watch?v=04TTRJArpVw. On 3/31/2023 6:08 PM, Rebecca Cran wrote: I've been wondering, is it possible to increase the parallelism or add more resources to the CI runner pool?
More All Messages By This Member
Michael Kubacki #102340 Since we use those PRs for reference only. I think we can let the initial CI run, keep that for reference, and prevent future automated rebases in the dependabot PR. Future CI will occur in the PR created by the patch that contains the update. With that in mind, I sent a patch to disable automatic rebasing in dependabot PRs. https://edk2.groups.io/g/devel/message/102338 Thanks, Michael toggle quoted message Show quoted text On 3/31/2023 7:14 PM, Kinney, Michael D wrote: Michael, I see older PRs from dependabot still running jobs. Is there a way to configure how often those checks are made? Mike -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki Sent: Friday, March 31, 2023 4:00 PM To: devel@edk2.groups.io; rebecca@...; Ni, Ray <ray.ni@...> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases I'm not sure about the availability of more resources but something like merge queue might be able to help. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request- merges/managing-a-merge-queue This presentation has an overview - https://www.youtube.com/watch?v=04TTRJArpVw. On 3/31/2023 6:08 PM, Rebecca Cran wrote: I've been wondering, is it possible to increase the parallelism or add more resources to the CI runner pool?
More All Messages By This Member

1 - 8 of 8

1

Previous Topic Next Topic

Home Hashtags Subgroups Calendar About Features Pricing Updates Terms Help Twitter