Topics

[PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

KrishnadasX Veliyathuparambil Prakashan <krishnadasx.veliyathuparambil.prakashan@...>
 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch
custom boot option or application for recovering the failed
hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan <krishnadasx.veliyat=
huparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePk=
g/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.=0D
=0D
Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.=0D
-Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.<BR>=0D
+Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>=0D
(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>=0D
SPDX-License-Identifier: BSD-2-Clause-Patent=0D
=0D
@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);=0D
}=0D
//=0D
- // Report Status Code with the failure status to indicate that the f=
ailure to load boot option=0D
- //=0D
- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status=
);=0D
- BootOption->Status =3D Status;=0D
- //=0D
// Destroy the RAM disk=0D
//=0D
if (RamDiskDevicePath !=3D NULL) {=0D
BmDestroyRamDisk (RamDiskDevicePath);=0D
FreePool (RamDiskDevicePath);=0D
}=0D
+ //=0D
+ // Report Status Code with the failure status to indicate that the f=
ailure to load boot option=0D
+ //=0D
+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status=
);=0D
+ BootOption->Status =3D Status;=0D
return;=0D
}=0D
}=0D
@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status =3D gBS->StartImage (ImageHandle, &BootOption->ExitDataSize, &Boo=
tOption->ExitData);=0D
DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status =3D %r\n", Status)=
);=0D
BootOption->Status =3D Status;=0D
- if (EFI_ERROR (Status)) {=0D
- //=0D
- // Report Status Code with the failure status to indicate that boot fa=
ilure=0D
- //=0D
- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);=0D
- }=0D
- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber)=
;=0D
=0D
//=0D
// Destroy the RAM disk=0D
@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);=0D
}=0D
=0D
+ if (EFI_ERROR (Status)) {=0D
+ //=0D
+ // Report Status Code with the failure status to indicate that boot fa=
ilure=0D
+ //=0D
+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);=0D
+ }=0D
+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber)=
;=0D
+=0D
+=0D
//=0D
// Clear the Watchdog Timer after the image returns=0D
//=0D
--=20
2.27.0.windows.1

Wang, Sunny (HPS SW)
 

Looks good to me. Not sure if there was a reason to call BmDestroyRamDisk before ReportStatusCode.
By the way, it is an interesting case that there is a custom boot option or application that needs the memory that was occupied by the RAM disk. It looks to me like the custom boot option or application would like to create the other RAM disk with allocating large memory for recovering the failed boot option.

Reviewed-by: Sunny Wang <sunnywang@...>

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the failure status, so that OEMs can use RSC Listener to launch custom boot option or application for recovering the failed hard drive.

This change will help to ensure that the allocated pool of memory for the failed boot option is freed before executing OEM's RSC listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan <krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.

Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
-Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);
}
//
- // Report Status Code with the failure status to indicate that the failure to load boot option
- //
- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);
- BootOption->Status = Status;
- //
// Destroy the RAM disk
//
if (RamDiskDevicePath != NULL) {
BmDestroyRamDisk (RamDiskDevicePath);
FreePool (RamDiskDevicePath);
}
+ //
+ // Report Status Code with the failure status to indicate that the failure to load boot option
+ //
+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);
+ BootOption->Status = Status;
return;
}
}
@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize, &BootOption->ExitData);
DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n", Status));
BootOption->Status = Status;
- if (EFI_ERROR (Status)) {
- //
- // Report Status Code with the failure status to indicate that boot failure
- //
- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);
- }
- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber);

//
// Destroy the RAM disk
@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);
}

+ if (EFI_ERROR (Status)) {
+ //
+ // Report Status Code with the failure status to indicate that boot failure
+ //
+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);
+ } PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
+ OptionNumber);
+
+
//
// Clear the Watchdog Timer after the image returns
//
--
2.27.0.windows.1

Liming Gao
 

Signed-off-by line is too long and exceeds 80 characters requirement. But, it is valid.

So, I suggest to enhance PatchCheck.py and skip the check for the lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.

Thanks
Liming

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch
custom boot option or application for recovering the failed
hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan <krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure to load boot option

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate that the failure to load boot option

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize, &BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n", Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate that boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517): https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@...]
-=-=-=-=-=-=

Veliyathuparambil Prakashan, KrishnadasX <krishnadasx.veliyathuparambil.prakashan@...>
 

Thank you very much Liming and Zhichao for your time to discuss this case.

Hello Liming,

As discussed, please help to raise the BZ to enhance PatchCheck.py and kindly help to submit our Edk2 patch to Edk2 Repo.
[EDK2 Change BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2818]

Also, please give us an update on next week regarding the ETA , as per our discussion.

Thanks,
Krishnadas

-----Original Message-----
From: Gao, Liming <liming.gao@...>
Sent: Friday, July 3, 2020 11:32 AM
To: devel@edk2.groups.io; Veliyathuparambil Prakashan, KrishnadasX
<krishnadasx.veliyathuparambil.prakashan@...>; leif@...;
Laszlo Ersek <lersek@...>; afish@...; Kinney, Michael D
<michael.d.kinney@...>
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

Signed-off-by line is too long and exceeds 80 characters requirement. But, it is
valid.

So, I suggest to enhance PatchCheck.py and skip the check for the lines with
Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the failure
status, so that OEMs can use RSC Listener to launch custom boot option
or application for recovering the failed hard drive.

This change will help to ensure that the allocated pool of memory for
the failed boot option is freed before executing OEM's RSC listener
callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan
<krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights
reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights
+reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure to
load boot option

- //

- BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate that
+ the failure to load boot option

+ //

+ BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR,
+ Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize,
&BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n",
Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate that
+ boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
+ Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
+ OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517):
https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[liming.gao@...] -=-=-=-=-=-=

Leif Lindholm
 

On Fri, Jul 03, 2020 at 06:02:12 +0000, Gao, Liming wrote:
Signed-off-by line is too long and exceeds 80 characters requirement. But, it is valid.

So, I suggest to enhance PatchCheck.py and skip the check for the lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.
Acked-by, not Ack-by, but yes, I completely agree. Restricting the
lenght of these tag lines is not correct.
We may want to consider adding "Cc:" to the list also.

Regards,

Leif

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch
custom boot option or application for recovering the failed
hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan <krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure to load boot option

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate that the failure to load boot option

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize, &BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n", Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate that boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517): https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@...]
-=-=-=-=-=-=

Liming Gao
 

BZ to enhance PatchCheck is submitted. https://bugzilla.tianocore.org/show_bug.cgi?id=2836

Thanks
Liming

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif Lindholm
Sent: Friday, July 3, 2020 6:43 PM
To: Gao, Liming <liming.gao@...>
Cc: devel@edk2.groups.io; Veliyathuparambil Prakashan, KrishnadasX <krishnadasx.veliyathuparambil.prakashan@...>; Laszlo
Ersek <lersek@...>; afish@...; Kinney, Michael D <michael.d.kinney@...>; Gao, Zhichao
<zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

On Fri, Jul 03, 2020 at 06:02:12 +0000, Gao, Liming wrote:
Signed-off-by line is too long and exceeds 80 characters requirement. But, it is valid.

So, I suggest to enhance PatchCheck.py and skip the check for the lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.
Acked-by, not Ack-by, but yes, I completely agree. Restricting the
lenght of these tag lines is not correct.
We may want to consider adding "Cc:" to the list also.

Regards,

Leif

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch
custom boot option or application for recovering the failed
hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan <krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure to load boot option

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate that the failure to load boot option

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize, &BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n", Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate that boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED, Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32) OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517): https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@...]
-=-=-=-=-=-=

Gao, Zhichao
 

With the patchcheck issue fixed. Reviewed-by: Zhichao Gao <zhichao.gao@...>

Thanks,
Zhichao

-----Original Message-----
From: Veliyathuparambil Prakashan, KrishnadasX
<krishnadasx.veliyathuparambil.prakashan@...>
Sent: Friday, July 17, 2020 12:09 PM
To: Gao, Liming <liming.gao@...>; Gao, Zhichao <zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy
<krishnamoorthy.t.v@...>; devel@edk2.groups.io; Kinney, Michael D
<michael.d.kinney@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

Hello Liming,

Gentle Reminder.
As discussed before, please let us know when we can expect our changes (below
BZ) to get pushed in to Edk2Repo.
Please help to give an ETA.

BZ Details:
[edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk
memory before RSC
https://bugzilla.tianocore.org/show_bug.cgi?id=2818

Dependency : https://bugzilla.tianocore.org/show_bug.cgi?id=2836

Thanks,
Krishnadas

-----Original Message-----
From: Veliyathuparambil Prakashan, KrishnadasX
Sent: Friday, July 3, 2020 3:00 PM
To: Gao, Liming <liming.gao@...>; Gao, Zhichao
<zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy
<Krishnamoorthy.T.V@...>; devel@edk2.groups.io;
leif@...; Laszlo Ersek <lersek@...>; afish@...;
Kinney, Michael D <michael.d.kinney@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption
failure, Destroy RamDisk memory before RSC.

Thank you very much Liming and Zhichao for your time to discuss this case.

Hello Liming,

As discussed, please help to raise the BZ to enhance PatchCheck.py and
kindly help to submit our Edk2 patch to Edk2 Repo.
[EDK2 Change BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2818]

Also, please give us an update on next week regarding the ETA , as per
our discussion.

Thanks,
Krishnadas

-----Original Message-----
From: Gao, Liming <liming.gao@...>
Sent: Friday, July 3, 2020 11:32 AM
To: devel@edk2.groups.io; Veliyathuparambil Prakashan, KrishnadasX
<krishnadasx.veliyathuparambil.prakashan@...>;
leif@...; Laszlo Ersek <lersek@...>;
afish@...; Kinney, Michael D <michael.d.kinney@...>
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption
failure, Destroy RamDisk memory before RSC.

Signed-off-by line is too long and exceeds 80 characters requirement.
But, it is valid.

So, I suggest to enhance PatchCheck.py and skip the check for the
lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray
<ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption
failure,
Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch custom
boot option or application for recovering the failed hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan
<krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights
reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights
+reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development
LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure
to
load boot option

- //

- BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate
+ that the failure to load boot option

+ //

+ BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR,
+ Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle,
&BootOption->ExitDataSize, &BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n",
Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate
+ that boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
+ Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
+ OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517):
https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[liming.gao@...] -=-=-=-=-=-=

Liming Gao
 

Krishnadas:
The patch for BZ 2836 has passed reviewed. It will be merged early next week. Then, your patch will also be merged next week.

Thanks
Liming

-----Original Message-----
From: Veliyathuparambil Prakashan, KrishnadasX <krishnadasx.veliyathuparambil.prakashan@...>
Sent: Friday, July 17, 2020 12:09 PM
To: Gao, Liming <liming.gao@...>; Gao, Zhichao <zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy <krishnamoorthy.t.v@...>; devel@edk2.groups.io; Kinney, Michael D
<michael.d.kinney@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

Hello Liming,

Gentle Reminder.
As discussed before, please let us know when we can expect our changes (below BZ) to get pushed in to Edk2Repo.
Please help to give an ETA.

BZ Details:
[edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC
https://bugzilla.tianocore.org/show_bug.cgi?id=2818

Dependency : https://bugzilla.tianocore.org/show_bug.cgi?id=2836

Thanks,
Krishnadas

-----Original Message-----
From: Veliyathuparambil Prakashan, KrishnadasX
Sent: Friday, July 3, 2020 3:00 PM
To: Gao, Liming <liming.gao@...>; Gao, Zhichao
<zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy
<Krishnamoorthy.T.V@...>; devel@edk2.groups.io; leif@...;
Laszlo Ersek <lersek@...>; afish@...; Kinney, Michael D
<michael.d.kinney@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

Thank you very much Liming and Zhichao for your time to discuss this case.

Hello Liming,

As discussed, please help to raise the BZ to enhance PatchCheck.py and kindly
help to submit our Edk2 patch to Edk2 Repo.
[EDK2 Change BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2818]

Also, please give us an update on next week regarding the ETA , as per our
discussion.

Thanks,
Krishnadas

-----Original Message-----
From: Gao, Liming <liming.gao@...>
Sent: Friday, July 3, 2020 11:32 AM
To: devel@edk2.groups.io; Veliyathuparambil Prakashan, KrishnadasX
<krishnadasx.veliyathuparambil.prakashan@...>;
leif@...; Laszlo Ersek <lersek@...>; afish@...;
Kinney, Michael D <michael.d.kinney@...>
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption
failure, Destroy RamDisk memory before RSC.

Signed-off-by line is too long and exceeds 80 characters requirement.
But, it is valid.

So, I suggest to enhance PatchCheck.py and skip the check for the
lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch custom
boot option or application for recovering the failed hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan
<krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights
reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights
+reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development
LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure
to
load boot option

- //

- BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate
+ that the failure to load boot option

+ //

+ BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR,
+ Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize,
&BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n",
Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate that
+ boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
+ Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
+ OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517):
https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[liming.gao@...] -=-=-=-=-=-=

Veliyathuparambil Prakashan, KrishnadasX <krishnadasx.veliyathuparambil.prakashan@...>
 

Hello Liming,

Gentle Reminder.
As discussed before, please let us know when we can expect our changes (below BZ) to get pushed in to Edk2Repo.
Please help to give an ETA.

BZ Details:
[edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC
https://bugzilla.tianocore.org/show_bug.cgi?id=2818

Dependency : https://bugzilla.tianocore.org/show_bug.cgi?id=2836

Thanks,
Krishnadas

-----Original Message-----
From: Veliyathuparambil Prakashan, KrishnadasX
Sent: Friday, July 3, 2020 3:00 PM
To: Gao, Liming <liming.gao@...>; Gao, Zhichao
<zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy
<Krishnamoorthy.T.V@...>; devel@edk2.groups.io; leif@...;
Laszlo Ersek <lersek@...>; afish@...; Kinney, Michael D
<michael.d.kinney@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

Thank you very much Liming and Zhichao for your time to discuss this case.

Hello Liming,

As discussed, please help to raise the BZ to enhance PatchCheck.py and kindly
help to submit our Edk2 patch to Edk2 Repo.
[EDK2 Change BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2818]

Also, please give us an update on next week regarding the ETA , as per our
discussion.

Thanks,
Krishnadas

-----Original Message-----
From: Gao, Liming <liming.gao@...>
Sent: Friday, July 3, 2020 11:32 AM
To: devel@edk2.groups.io; Veliyathuparambil Prakashan, KrishnadasX
<krishnadasx.veliyathuparambil.prakashan@...>;
leif@...; Laszlo Ersek <lersek@...>; afish@...;
Kinney, Michael D <michael.d.kinney@...>
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption
failure, Destroy RamDisk memory before RSC.

Signed-off-by line is too long and exceeds 80 characters requirement.
But, it is valid.

So, I suggest to enhance PatchCheck.py and skip the check for the
lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch custom
boot option or application for recovering the failed hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan
<krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights
reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights
+reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development
LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure
to
load boot option

- //

- BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate
+ that the failure to load boot option

+ //

+ BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR,
+ Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize,
&BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n",
Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate that
+ boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
+ Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
+ OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517):
https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[liming.gao@...] -=-=-=-=-=-=

Liming Gao
 

This patch has been merged @ cb38ace647231076acfc0c5bdd21d3aff43e4f83.

Thanks
Liming

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
Sent: Friday, July 17, 2020 11:07 PM
To: Veliyathuparambil Prakashan, KrishnadasX <krishnadasx.veliyathuparambil.prakashan@...>; Gao, Zhichao
<zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy <krishnamoorthy.t.v@...>; devel@edk2.groups.io; Kinney, Michael D
<michael.d.kinney@...>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

Krishnadas:
The patch for BZ 2836 has passed reviewed. It will be merged early next week. Then, your patch will also be merged next week.

Thanks
Liming
-----Original Message-----
From: Veliyathuparambil Prakashan, KrishnadasX <krishnadasx.veliyathuparambil.prakashan@...>
Sent: Friday, July 17, 2020 12:09 PM
To: Gao, Liming <liming.gao@...>; Gao, Zhichao <zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy <krishnamoorthy.t.v@...>; devel@edk2.groups.io; Kinney, Michael D
<michael.d.kinney@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

Hello Liming,

Gentle Reminder.
As discussed before, please let us know when we can expect our changes (below BZ) to get pushed in to Edk2Repo.
Please help to give an ETA.

BZ Details:
[edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC
https://bugzilla.tianocore.org/show_bug.cgi?id=2818

Dependency : https://bugzilla.tianocore.org/show_bug.cgi?id=2836

Thanks,
Krishnadas

-----Original Message-----
From: Veliyathuparambil Prakashan, KrishnadasX
Sent: Friday, July 3, 2020 3:00 PM
To: Gao, Liming <liming.gao@...>; Gao, Zhichao
<zhichao.gao@...>
Cc: Ni, Ray <ray.ni@...>; T V, Krishnamoorthy
<Krishnamoorthy.T.V@...>; devel@edk2.groups.io; leif@...;
Laszlo Ersek <lersek@...>; afish@...; Kinney, Michael D
<michael.d.kinney@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

Thank you very much Liming and Zhichao for your time to discuss this case.

Hello Liming,

As discussed, please help to raise the BZ to enhance PatchCheck.py and kindly
help to submit our Edk2 patch to Edk2 Repo.
[EDK2 Change BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2818]

Also, please give us an update on next week regarding the ETA , as per our
discussion.

Thanks,
Krishnadas

-----Original Message-----
From: Gao, Liming <liming.gao@...>
Sent: Friday, July 3, 2020 11:32 AM
To: devel@edk2.groups.io; Veliyathuparambil Prakashan, KrishnadasX
<krishnadasx.veliyathuparambil.prakashan@...>;
leif@...; Laszlo Ersek <lersek@...>; afish@...;
Kinney, Michael D <michael.d.kinney@...>
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption
failure, Destroy RamDisk memory before RSC.

Signed-off-by line is too long and exceeds 80 characters requirement.
But, it is valid.

So, I suggest to enhance PatchCheck.py and skip the check for the
lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:.

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
KrishnadasX Veliyathuparambil Prakashan
Sent: Friday, June 19, 2020 10:40 AM
To: devel@edk2.groups.io
Cc: Gao, Zhichao <zhichao.gao@...>; Ni, Ray <ray.ni@...>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure,
Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818

For better memory management, re-ordered the DestroyRamDisk and
ReportStatusCode calls inside the EfiBootManagerBoot() function.

This will help to clean the unused memory before reporting the
failure status, so that OEMs can use RSC Listener to launch custom
boot option or application for recovering the failed hard drive.

This change will help to ensure that the allocated pool of memory
for the failed boot option is freed before executing OEM's RSC
listener callback to handle every boot option failure.

Signed-off-by: KrishnadasX Veliyathuparambil Prakashan
<krishnadasx.veliyathuparambil.prakashan@...>
Cc: "Gao, Zhichao" <zhichao.gao@...>
Cc: "Ni, Ray" <ray.ni@...>
---
.../Library/UefiBootManagerLib/BmBoot.c | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 540d169ec1..aff620ad52 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2,7 +2,7 @@
Library functions which relates with booting.



Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.

-Copyright (c) 2011 - 2019, Intel Corporation. All rights
reserved.<BR>

+Copyright (c) 2011 - 2020, Intel Corporation. All rights
+reserved.<BR>

(C) Copyright 2015-2016 Hewlett Packard Enterprise Development
LP<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -1903,17 +1903,17 @@ EfiBootManagerBoot (
gBS->UnloadImage (ImageHandle);

}

//

- // Report Status Code with the failure status to indicate that the failure
to
load boot option

- //

- BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR, Status);

- BootOption->Status = Status;

- //

// Destroy the RAM disk

//

if (RamDiskDevicePath != NULL) {

BmDestroyRamDisk (RamDiskDevicePath);

FreePool (RamDiskDevicePath);

}

+ //

+ // Report Status Code with the failure status to indicate
+ that the failure to load boot option

+ //

+ BmReportLoadFailure
(EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR,
+ Status);

+ BootOption->Status = Status;

return;

}

}

@@ -1982,13 +1982,6 @@ EfiBootManagerBoot (
Status = gBS->StartImage (ImageHandle, &BootOption->ExitDataSize,
&BootOption->ExitData);

DEBUG ((DEBUG_INFO | DEBUG_LOAD, "Image Return Status = %r\n",
Status));

BootOption->Status = Status;

- if (EFI_ERROR (Status)) {

- //

- // Report Status Code with the failure status to indicate that boot failure

- //

- BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
Status);

- }

- PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
OptionNumber);



//

// Destroy the RAM disk

@@ -1998,6 +1991,15 @@ EfiBootManagerBoot (
FreePool (RamDiskDevicePath);

}



+ if (EFI_ERROR (Status)) {

+ //

+ // Report Status Code with the failure status to indicate that
+ boot failure

+ //

+ BmReportLoadFailure (EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED,
+ Status);

+ }

+ PERF_END_EX (gImageHandle, "BdsAttempt", NULL, 0, (UINT32)
+ OptionNumber);

+

+

//

// Clear the Watchdog Timer after the image returns

//

--
2.27.0.windows.1


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61517):
https://edk2.groups.io/g/devel/message/61517
Mute This Topic: https://groups.io/mt/74978785/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[liming.gao@...] -=-=-=-=-=-=