[PATCH] EmulatorPkg: Remove unnecessary dependency on EmbeddedPkg


Zhiguang Liu
 

EmulatorPkg doesn't need depend on EmbeddedPkg, so remove the dependency.

Cc: Andrew Fish <afish@...>
Cc: Ray Ni <ray.ni@...>
Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
---
EmulatorPkg/EmulatorPkg.ci.yaml | 3 +--
.../Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf | 3 +--
.../Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf | 3 +--
3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml b/EmulatorPkg/EmulatorPkg.ci.yaml
index 338d5fc2d3..6e9b2857cb 100644
--- a/EmulatorPkg/EmulatorPkg.ci.yaml
+++ b/EmulatorPkg/EmulatorPkg.ci.yaml
@@ -5,7 +5,7 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -55,7 +55,6 @@
"EmulatorPkg/EmulatorPkg.dec",
"NetworkPkg/NetworkPkg.dec",
"RedfishPkg/RedfishPkg.dec",
- "EmbeddedPkg/EmbeddedPkg.dec", ## is this one OK??
],
# For host based unit tests
"AcceptableDependencies-HOST_APPLICATION":[
diff --git a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf
index d91f7de181..dfdabde22a 100644
--- a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf
+++ b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf
@@ -1,7 +1,7 @@
## @file
# Write only instance of Serial Port Library with empty functions.
#
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
# Portions copyright (c) 2011, Apple Inc. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -25,7 +25,6 @@
[Packages]
MdePkg/MdePkg.dec
EmulatorPkg/EmulatorPkg.dec
- EmbeddedPkg/EmbeddedPkg.dec

[LibraryClasses]
EmuThunkLib
diff --git a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
index 2f5e656fd7..7ef3e3baaf 100644
--- a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
+++ b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
@@ -1,7 +1,7 @@
## @file
# Write only instance of Serial Port Library with empty functions.
#
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
# Portions copyright (c) 2011, Apple Inc. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -28,7 +28,6 @@
[Packages]
MdePkg/MdePkg.dec
EmulatorPkg/EmulatorPkg.dec
- EmbeddedPkg/EmbeddedPkg.dec

[LibraryClasses]
PeiServicesLib
--
2.31.1.windows.1


Ni, Ray
 

Thanks for the cleaning up.
Reviewed-by: Ray Ni <ray.ni@...>

-----Original Message-----
From: Liu, Zhiguang <zhiguang.liu@...>
Sent: Tuesday, December 6, 2022 1:30 PM
To: devel@edk2.groups.io
Cc: Liu, Zhiguang <zhiguang.liu@...>; Andrew Fish <afish@...>;
Ni, Ray <ray.ni@...>
Subject: [PATCH] EmulatorPkg: Remove unnecessary dependency on
EmbeddedPkg

EmulatorPkg doesn't need depend on EmbeddedPkg, so remove the
dependency.

Cc: Andrew Fish <afish@...>
Cc: Ray Ni <ray.ni@...>
Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
---
EmulatorPkg/EmulatorPkg.ci.yaml | 3 +--
.../Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf | 3 +--
.../Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf | 3 +--
3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/EmulatorPkg/EmulatorPkg.ci.yaml
b/EmulatorPkg/EmulatorPkg.ci.yaml
index 338d5fc2d3..6e9b2857cb 100644
--- a/EmulatorPkg/EmulatorPkg.ci.yaml
+++ b/EmulatorPkg/EmulatorPkg.ci.yaml
@@ -5,7 +5,7 @@
# used for code analysis.
#
# Copyright (c) Microsoft Corporation
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -55,7 +55,6 @@
"EmulatorPkg/EmulatorPkg.dec",
"NetworkPkg/NetworkPkg.dec",
"RedfishPkg/RedfishPkg.dec",
- "EmbeddedPkg/EmbeddedPkg.dec", ## is this one OK??
],
# For host based unit tests
"AcceptableDependencies-HOST_APPLICATION":[
diff --git
a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf
b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf
index d91f7de181..dfdabde22a 100644
--- a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf
+++ b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.inf
@@ -1,7 +1,7 @@
## @file
# Write only instance of Serial Port Library with empty functions.
#
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
# Portions copyright (c) 2011, Apple Inc. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -25,7 +25,6 @@
[Packages]
MdePkg/MdePkg.dec
EmulatorPkg/EmulatorPkg.dec
- EmbeddedPkg/EmbeddedPkg.dec

[LibraryClasses]
EmuThunkLib
diff --git a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
index 2f5e656fd7..7ef3e3baaf 100644
--- a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
+++ b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.inf
@@ -1,7 +1,7 @@
## @file
# Write only instance of Serial Port Library with empty functions.
#
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
# Portions copyright (c) 2011, Apple Inc. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -28,7 +28,6 @@
[Packages]
MdePkg/MdePkg.dec
EmulatorPkg/EmulatorPkg.dec
- EmbeddedPkg/EmbeddedPkg.dec

[LibraryClasses]
PeiServicesLib
--
2.31.1.windows.1