devel@edk2.groups.io | [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Home Messages Hashtags Subgroups Calendar

Date Date 1 - 9 of 9

[PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Jianyong Wu #100300 commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@...> --- ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf \| 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf index 7cad40e11f..6ff80b24d0 100644 --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf @@ -23,6 +23,7 @@ EmbeddedPkg/EmbeddedPkg.dec MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec [LibraryClasses] BaseLib -- 2.17.1
More All Messages By This Member
Jianyong Wu #102001 Add Ard Biesheuvel <ardb@...> and Sunil V L <sunilvl@...> to cc list. toggle quoted message Show quoted text -----Original Message----- From: Jianyong Wu <jianyong.wu@...> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@...> Cc: Jianyong Wu <Jianyong.Wu@...> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@...> --- ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf \| 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf index 7cad40e11f..6ff80b24d0 100644 --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf @@ -23,6 +23,7 @@ EmbeddedPkg/EmbeddedPkg.dec MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec [LibraryClasses] BaseLib -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
More All Messages By This Member
Sunil V L #102002 On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: Add Ard Biesheuvel <ardb@...> and Sunil V L <sunilvl@...> to cc list. -----Original Message----- From: Jianyong Wu <jianyong.wu@...> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@...> Cc: Jianyong Wu <Jianyong.Wu@...> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@...> --- ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf \| 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf index 7cad40e11f..6ff80b24d0 100644 --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf @@ -23,6 +23,7 @@ EmbeddedPkg/EmbeddedPkg.dec MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec Hi Jianyong, Thanks for fixing this!. Sorry that I missed this in the first place. Reviewed-by: Sunil V L <sunilvl@...>
More All Messages By This Member
Sunil V L #102003 On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: Add Ard Biesheuvel <ardb@...> and Sunil V L <sunilvl@...> to cc list. -----Original Message----- From: Jianyong Wu <jianyong.wu@...> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@...> Cc: Jianyong Wu <Jianyong.Wu@...> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@...> --- Hi Jianyong, Any reason why this platform is not built as part of CI? I think it will be good to add so that we don't break by some changes like this. Thanks, Sunil
More All Messages By This Member
Sami Mujawar #102015 Hi Jianyong, Thank you for this fix. The subject line should have the package name as prefix followed by the short description for the patch e.g. "ArmVirtPkg: xxx". Other than that, this change looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar On 28/03/2023, 04:28, "Jianyong Wu" <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> wrote: Add Ard Biesheuvel <ardb@... <mailto:ardb@...>> and Sunil V L <sunilvl@... <mailto:sunilvl@...>> to cc list. toggle quoted message Show quoted text -----Original Message----- From: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...>> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@... <mailto:Sami.Mujawar@...>> Cc: Jianyong Wu <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...>> --- ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf \| 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf index 7cad40e11f..6ff80b24d0 100644 --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf @@ -23,6 +23,7 @@ EmbeddedPkg/EmbeddedPkg.dec MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec [LibraryClasses] BaseLib -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
More All Messages By This Member
Sami Mujawar #102016 Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 08:45, "Sunil V L" <sunilvl@... <mailto:sunilvl@...>> wrote: On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: Add Ard Biesheuvel <ardb@... <mailto:ardb@...>> and Sunil V L <sunilvl@... <mailto:sunilvl@...>> to cc list. -----Original Message----- From: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...>> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@... <mailto:Sami.Mujawar@...>> Cc: Jianyong Wu <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...>> --- Hi Jianyong, Any reason why this platform is not built as part of CI? I think it will be good to add so that we don't break by some changes like this. [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please see the change at https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd10e89d8b8cc4. Thanks, Sunil IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
More All Messages By This Member
Jianyong Wu #102017 Hi Sami, I have never added CI for CloudHv. So, should I add it? Also, I will update this patch based on your comment and send the second version. Thanks, Jianyong toggle quoted message Show quoted text -----Original Message----- From: Sami Mujawar <Sami.Mujawar@...> Sent: 2023年3月28日 15:52 To: Sunil V L <sunilvl@...>; Jianyong Wu <Jianyong.Wu@...> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb@...> Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 08:45, "Sunil V L" <sunilvl@... <mailto:sunilvl@...>> wrote: On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: Add Ard Biesheuvel <ardb@... <mailto:ardb@...>> and Sunil V L <sunilvl@... <mailto:sunilvl@...>> to cc list. -----Original Message----- From: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...>> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@... <mailto:Sami.Mujawar@...>> Cc: Jianyong Wu <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...>> --- Hi Jianyong, Any reason why this platform is not built as part of CI? I think it will be good to add so that we don't break by some changes like this. [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please see the change at https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd 10e89d8b8cc4. Thanks, Sunil IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
More All Messages By This Member
Sami Mujawar #102018 Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 09:17, "Jianyong Wu" <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> wrote: Hi Sami, I have never added CI for CloudHv. So, should I add it? [SAMI] I think you can prepare the patch that adds the CI support and push your changes to your private github branch. You should then be able to generate a draft pull request to test that the CI patch works. Also, I will update this patch based on your comment and send the second version. [SAMI] Please also update the commit message with the r-b received so far. Thanks, Jianyong toggle quoted message Show quoted text -----Original Message----- From: Sami Mujawar <Sami.Mujawar@... <mailto:Sami.Mujawar@...>> Sent: 2023年3月28日 15:52 To: Sunil V L <sunilvl@... <mailto:sunilvl@...>>; Jianyong Wu <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ard Biesheuvel <ardb@... <mailto:ardb@...>> Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 08:45, "Sunil V L" <sunilvl@... <mailto:sunilvl@...> <mailto:sunilvl@... <mailto:sunilvl@...>>> wrote: On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: Add Ard Biesheuvel <ardb@... <mailto:ardb@...> <mailto:ardb@... <mailto:ardb@...>>> and Sunil V L <sunilvl@... <mailto:sunilvl@...> <mailto:sunilvl@... <mailto:sunilvl@...>>> to cc list. -----Original Message----- From: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...> <mailto:jianyong.wu@... <mailto:jianyong.wu@...>>> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Sami Mujawar <Sami.Mujawar@... <mailto:Sami.Mujawar@...> <mailto:Sami.Mujawar@... <mailto:Sami.Mujawar@...>>> Cc: Jianyong Wu <Jianyong.Wu@... <mailto:Jianyong.Wu@...> <mailto:Jianyong.Wu@... <mailto:Jianyong.Wu@...>>> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...> <mailto:jianyong.wu@... <mailto:jianyong.wu@...>>> --- Hi Jianyong, Any reason why this platform is not built as part of CI? I think it will be good to add so that we don't break by some changes like this. [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please see the change at https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd <https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd> 10e89d8b8cc4. Thanks, Sunil IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
More All Messages By This Member
Jianyong Wu #102019 Hi Sami, Inline replay. toggle quoted message Show quoted text -----Original Message----- From: Sami Mujawar <Sami.Mujawar@...> Sent: 2023年3月28日 16:34 To: Jianyong Wu <Jianyong.Wu@...> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb@...>; sunilvl@... Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 09:17, "Jianyong Wu" <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> wrote: Hi Sami, I have never added CI for CloudHv. So, should I add it? [SAMI] I think you can prepare the patch that adds the CI support and push your changes to your private github branch. You should then be able to generate a draft pull request to test that the CI patch works. let me try it later. Also, I will update this patch based on your comment and send the second version. [SAMI] Please also update the commit message with the r-b received so far. OK. Thanks Jianyong Thanks, Jianyong -----Original Message----- From: Sami Mujawar <Sami.Mujawar@... <mailto:Sami.Mujawar@...>> Sent: 2023年3月28日 15:52 To: Sunil V L <sunilvl@... <mailto:sunilvl@...>>; Jianyong Wu <Jianyong.Wu@... <mailto:Jianyong.Wu@...>> Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ard Biesheuvel <ardb@... <mailto:ardb@...>> Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 08:45, "Sunil V L" <sunilvl@... <mailto:sunilvl@...> <mailto:sunilvl@... <mailto:sunilvl@...>>> wrote: On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: Add Ard Biesheuvel <ardb@... <mailto:ardb@...> <mailto:ardb@... <mailto:ardb@...>>> and Sunil V L <sunilvl@... <mailto:sunilvl@...> <mailto:sunilvl@... <mailto:sunilvl@...>>> to cc list. -----Original Message----- From: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...> <mailto:jianyong.wu@... <mailto:jianyong.wu@...>>> Sent: 2023年2月17日 14:48 To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Sami Mujawar <Sami.Mujawar@... <mailto:Sami.Mujawar@...> <mailto:Sami.Mujawar@... <mailto:Sami.Mujawar@...>>> Cc: Jianyong Wu <Jianyong.Wu@... <mailto:Jianyong.Wu@...> <mailto:Jianyong.Wu@... <mailto:Jianyong.Wu@...>>> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@... <mailto:jianyong.wu@...> <mailto:jianyong.wu@... <mailto:jianyong.wu@...>>> --- Hi Jianyong, Any reason why this platform is not built as part of CI? I think it will be good to add so that we don't break by some changes like this. [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please see the change at https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd <https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd 10e89d8b8cc4. Thanks, Sunil IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
More All Messages By This Member

1 - 9 of 9

1

Previous Topic Next Topic

Home Hashtags Subgroups Calendar About Features Pricing Updates Terms Help Twitter