[PATCH 1/9] OvmfPkg: Replace static struct initialization with ZeroMem call


Rebecca Cran
 

Replace the static struct initialization with a call to ZeroMem to avoid
generating a call to memset in certain build configurations.

Signed-off-by: Rebecca Cran <rebecca@...>
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
index 38cece9173e8..0bcdfb83721f 100644
--- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
+++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
@@ -608,10 +608,12 @@ PlatformAddressWidthFromCpuid (
{
UINT32 RegEax, RegEbx, RegEcx, RegEdx, Max;
UINT8 PhysBits;
- CHAR8 Signature[13] = { 0 };
+ CHAR8 Signature[13];
BOOLEAN Valid = FALSE;
BOOLEAN Page1GSupport = FALSE;

+ ZeroMem (Signature, sizeof (Signature));
+
AsmCpuid (0x80000000, &RegEax, &RegEbx, &RegEcx, &RegEdx);
*(UINT32 *)(Signature + 0) = RegEbx;
*(UINT32 *)(Signature + 4) = RegEdx;
--
2.34.1


Gerd Hoffmann
 

On Tue, Mar 21, 2023 at 07:30:32PM -0600, Rebecca Cran wrote:
Replace the static struct initialization with a call to ZeroMem to avoid
generating a call to memset in certain build configurations.

Signed-off-by: Rebecca Cran <rebecca@...>
Reviewed-by: Gerd Hoffmann <kraxel@...>