[PATCH 1/9] ArmVirtPkg: Add CpuPageTableLib required by DxeIpl in DSC


duntan
 

Add CpuPageTableLib instance required by DxeIpl in the
corresponding DSC files of ArmVirtPkg.

Signed-off-by: Dun Tan <dun.tan@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Leif Lindholm <quic_llindhol@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Gerd Hoffmann <kraxel@...>
Cc: Ray Ni <ray.ni@...>
---
ArmVirtPkg/ArmVirtCloudHv.dsc | 2 ++
ArmVirtPkg/ArmVirtQemu.dsc | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc
index c975e139a2..3e74c4d9f5 100644
--- a/ArmVirtPkg/ArmVirtCloudHv.dsc
+++ b/ArmVirtPkg/ArmVirtCloudHv.dsc
@@ -1,5 +1,6 @@
#
# Copyright (c) 2021, ARM Limited. All rights reserved.
+# Copyright (c) 2023, Intel Corporation. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -56,6 +57,7 @@

TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
TpmPlatformHierarchyLib|SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf
+ CpuPageTableLib|UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableLib.inf

!include MdePkg/MdeLibs.dsc.inc

diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index 449e73b9e1..62716af907 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -1,7 +1,7 @@
#
# Copyright (c) 2011-2015, ARM Limited. All rights reserved.
# Copyright (c) 2014, Linaro Limited. All rights reserved.
-# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2023, Intel Corporation. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -81,6 +81,7 @@
PciHostBridgeLib|OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
PeiHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf
+ CpuPageTableLib|UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableLib.inf

!if $(TPM2_ENABLE) == TRUE
Tpm2CommandLib|SecurityPkg/Library/Tpm2CommandLib/Tpm2CommandLib.inf
--
2.31.1.windows.1


Gerd Hoffmann
 

On Tue, Mar 28, 2023 at 10:42:54AM +0800, Dun Tan wrote:
Add CpuPageTableLib instance required by DxeIpl in the
corresponding DSC files of ArmVirtPkg.

Signed-off-by: Dun Tan <dun.tan@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Leif Lindholm <quic_llindhol@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Gerd Hoffmann <kraxel@...>
Cc: Ray Ni <ray.ni@...>
Hmm? CpuPageTableLib supports IA32 and X64. Why do we need it on ARM?

take care,
Gerd


duntan
 

My mistake... Pls ignore the patch set. I'll remove the patch of ArmVirtPkg in next version patch set.

Thanks,
Dun

-----Original Message-----
From: Gerd Hoffmann <kraxel@...>
Sent: Tuesday, March 28, 2023 2:54 PM
To: Tan, Dun <dun.tan@...>
Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@...>; Leif Lindholm <quic_llindhol@...>; Sami Mujawar <sami.mujawar@...>; Ni, Ray <ray.ni@...>
Subject: Re: [PATCH 1/9] ArmVirtPkg: Add CpuPageTableLib required by DxeIpl in DSC

On Tue, Mar 28, 2023 at 10:42:54AM +0800, Dun Tan wrote:
Add CpuPageTableLib instance required by DxeIpl in the corresponding
DSC files of ArmVirtPkg.

Signed-off-by: Dun Tan <dun.tan@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Leif Lindholm <quic_llindhol@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Gerd Hoffmann <kraxel@...>
Cc: Ray Ni <ray.ni@...>
Hmm? CpuPageTableLib supports IA32 and X64. Why do we need it on ARM?

take care,
Gerd