Date
1 - 10 of 10
[PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present
|
Sean Rhodes
From: Matt DeVillier <matt.devillier@...>
Only enumerate devices that have media present. Cc: Hao A Wu <hao.a.wu@...> Cc: Jian J Wang <jian.j.wang@...> Cc: Liming Gao <gaoliming@...> Cc: Zhichao Gao <zhichao.gao@...> Cc: Ray Ni <ray.ni@...> Reviewed-by: Sean Rhodes <sean@...> Signed-off-by: Matt DeVillier <matt.devillier@...> Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8 --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePk= g/Library/UefiBootManagerLib/BmBoot.c index 962892d38f..bde22fa659 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c @@ -2218,6 +2218,15 @@ BmEnumerateBootOptions ( continue;=0D }=0D =0D + //=0D + // Skip removable media if not present=0D + //=0D + if ((BlkIo->Media->RemovableMedia =3D=3D TRUE) &&=0D + (BlkIo->Media->MediaPresent =3D=3D FALSE))=0D + {=0D + continue;=0D + }=0D +=0D Description =3D BmGetBootDescription (Handles[Index]);=0D BootOptions =3D ReallocatePool (=0D sizeof (EFI_BOOT_MANAGER_LOAD_OPTION) * (*BootOption= Count),=0D --=20 2.37.2 |
|
|
|
Ni, Ray
Reviewed-by: Ray Ni <ray.ni@...>
toggle quoted message
Show quoted text
-----Original Message----- |
|
|
|
Sean Rhodes
Hi Ray Would it be possible to merge this? Thanks Sean On Fri, 16 Dec 2022, 09:03 Ni, Ray, <ray.ni@...> wrote: Reviewed-by: Ray Ni <ray.ni@...> |
|
|
|
Sheng Lean Tan
Hi Ray,
This patch has been hanging along since last year. Has it been merged? Thanks, Sheng |
|
|
|
Ni, Ray
thanks,
ray
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sheng Lean Tan <sheng.tan@...>
Sent: Monday, February 13, 2023 6:01:21 PM To: Rhodes, Sean <sean@...>; devel@edk2.groups.io <devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present Hi Ray,
This patch has been hanging along since last year. Has it been merged? Thanks, Sheng |
|
|
|
Sheng Lean Tan
Hi, A kind reminder - has this been merged? Best Regards, Lean Sheng Tan  9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar On Mon, 13 Feb 2023 at 12:57, Ni, Ray <ray.ni@...> wrote:
|
|
|
|
Sheng Lean Tan
@Jian J Wang Any update on this? Anything needs to be done from our side? Thanks. Best Regards, Lean Sheng Tan 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar On Fri, 17 Feb 2023 at 13:57, Sheng Lean Tan via groups.io <sheng.tan=9elements.com@groups.io> wrote:
|
|
|
|
Sheng Lean Tan
Another kind reminder, thanks.
|
|
|
|
Sheng Lean Tan
Seriously, what is the hold up here?
did Sean not following the process? Did he miss anything? it just doesn’t make sense to keep ignoring this patch for half year for no reason. Is there a way to voice up a about this? |
|
|
|
Ni, Ray
M: Jian J Wang jian.j.wang@... [jwang36] M: Liming Gao gaoliming@... [lgao4]
Jian and Liming are maintainers of MdeModulePkg. The patch passed my review. Either of them can help to merge the patch.
I guess Liming might not see this patch. I am sure he can help on merging it.
Thanks, Ray
From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of Sheng Lean Tan
Sent: Wednesday, March 8, 2023 4:55 PM To: Tan, Lean Sheng <sheng.tan@...>; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present
Seriously, what is the hold up here? |
|
|