[Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours


Michael D Kinney
 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750

Large patches that modify a large number of files(e.g uncrustify)
take longer to process through CI checks such as ECC. Increase
the max job time from 1 hour to 2 hours to accommodate larger patch
series.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index d5b16c127f58..244cffdbfaba 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -17,7 +17,7 @@ parameters:
jobs:

- job: Build_${{ parameters.tool_chain_tag }}
-
+ timeoutInMinutes: 120
#Use matrix to speed up the build process
strategy:
matrix:
--
2.32.0.windows.1


Michael Kubacki
 

Hi Mike,

Is the plan to keep it at a 2 hour limit indefinitely (not just for these large series currently outstanding)?

Thanks,
Michael

On 11/23/2021 7:44 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750
Large patches that modify a large number of files(e.g uncrustify)
take longer to process through CI checks such as ECC. Increase
the max job time from 1 hour to 2 hours to accommodate larger patch
series.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index d5b16c127f58..244cffdbfaba 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -17,7 +17,7 @@ parameters:
jobs:
- job: Build_${{ parameters.tool_chain_tag }}
-
+ timeoutInMinutes: 120
#Use matrix to speed up the build process
strategy:
matrix:


Michael D Kinney
 

Hi Michael,

I would like to see some optimization work applied to the ECC tool to see if
we can reduce the time that tool requires. If we find some easy improvements
that allow larger patch series to complete in 60 minutes, then I am in favor
of reducing back down to 60 minutes.

Unless we actually see jobs running more than 60 minutes or hitting the 120
minute timeout, I do not see this patch causing problems. We can do an audit
of PRs once is a while to see what the job execution times are.

If we do want to reduce, it will have to be a separate patch after uncrustify
set of PRs is applied.

Mike

-----Original Message-----
From: Michael Kubacki <mikuback@linux.microsoft.com>
Sent: Tuesday, November 23, 2021 4:49 PM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao
<gaoliming@byosoft.com.cn>; Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

Hi Mike,

Is the plan to keep it at a 2 hour limit indefinitely (not just for
these large series currently outstanding)?

Thanks,
Michael

On 11/23/2021 7:44 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750

Large patches that modify a large number of files(e.g uncrustify)
take longer to process through CI checks such as ECC. Increase
the max job time from 1 hour to 2 hours to accommodate larger patch
series.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index d5b16c127f58..244cffdbfaba 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -17,7 +17,7 @@ parameters:
jobs:

- job: Build_${{ parameters.tool_chain_tag }}
-
+ timeoutInMinutes: 120
#Use matrix to speed up the build process
strategy:
matrix:


Michael Kubacki
 

I wouldn't expect it to extend past 1 hour that often either. An occasional audit sounds good though.

Do you think a BZ could be filed to track the ECC optimization work? I didn't see anything obvious with a quick search.

Thanks,
Michael

On 11/23/2021 7:54 PM, Kinney, Michael D wrote:
Hi Michael,
I would like to see some optimization work applied to the ECC tool to see if
we can reduce the time that tool requires. If we find some easy improvements
that allow larger patch series to complete in 60 minutes, then I am in favor
of reducing back down to 60 minutes.
Unless we actually see jobs running more than 60 minutes or hitting the 120
minute timeout, I do not see this patch causing problems. We can do an audit
of PRs once is a while to see what the job execution times are.
If we do want to reduce, it will have to be a separate patch after uncrustify
set of PRs is applied.
Mike

-----Original Message-----
From: Michael Kubacki <mikuback@linux.microsoft.com>
Sent: Tuesday, November 23, 2021 4:49 PM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao
<gaoliming@byosoft.com.cn>; Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

Hi Mike,

Is the plan to keep it at a 2 hour limit indefinitely (not just for
these large series currently outstanding)?

Thanks,
Michael

On 11/23/2021 7:44 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750

Large patches that modify a large number of files(e.g uncrustify)
take longer to process through CI checks such as ECC. Increase
the max job time from 1 hour to 2 hours to accommodate larger patch
series.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index d5b16c127f58..244cffdbfaba 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -17,7 +17,7 @@ parameters:
jobs:

- job: Build_${{ parameters.tool_chain_tag }}
-
+ timeoutInMinutes: 120
#Use matrix to speed up the build process
strategy:
matrix:


Michael Kubacki
 

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 11/23/2021 7:44 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750
Large patches that modify a large number of files(e.g uncrustify)
take longer to process through CI checks such as ECC. Increase
the max job time from 1 hour to 2 hours to accommodate larger patch
series.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index d5b16c127f58..244cffdbfaba 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -17,7 +17,7 @@ parameters:
jobs:
- job: Build_${{ parameters.tool_chain_tag }}
-
+ timeoutInMinutes: 120
#Use matrix to speed up the build process
strategy:
matrix:


Sean
 

Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>

On 11/23/2021 4:44 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750
Large patches that modify a large number of files(e.g uncrustify)
take longer to process through CI checks such as ECC. Increase
the max job time from 1 hour to 2 hours to accommodate larger patch
series.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index d5b16c127f58..244cffdbfaba 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -17,7 +17,7 @@ parameters:
jobs:
- job: Build_${{ parameters.tool_chain_tag }}
-
+ timeoutInMinutes: 120
#Use matrix to speed up the build process
strategy:
matrix: