Topics

[PATCH 0/5] Make the MD5 disable as default setting


Gao, Zhichao
 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021

MD5 is deprecated, make it disable as default for security.
It required to set MD5 enable explicitly if the module is still
using MD5. List the modules that are still using it:
iSCSI, Hash2DxeCrypto, CryptoDxe(Pei, Smm) (with PACKAGE or ALL config).

This patch set would affact the platforms that are using iSCSI
function.

Cc: Jordan Justen <jordan.l.justen@...>
Cc: Laszlo Ersek <lersek@...>
Cc: Ard Biesheuvel <ard.biesheuvel@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Leif Lindholm <leif@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Kelly Steele <kelly.steele@...>
Cc: Zailiang Sun <zailiang.sun@...>
Cc: Yi Qian <yi.qian@...>
Cc: Liming Gao <gaoliming@...>
Cc: Maciej Rabeda <maciej.rabeda@...>
Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Roger Feng <roger.feng@...>
Signed-off-by: Zhichao Gao <zhichao.gao@...>

Zhichao Gao (5):
NetworkPkg/Defines: Make iSCSI disable as default
NetworkPkg: Enable MD5 while enable iSCSI
SecurityPkg/dsc: Explicitly enable MD5 for package build
CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5
CryptoPkg: Make the MD5 disable as default for security

CryptoPkg/CryptoPkg.dsc | 3 +++
CryptoPkg/Driver/Crypto.c | 4 ++--
CryptoPkg/Include/Library/BaseCryptLib.h | 2 +-
CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c | 2 +-
CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +-
NetworkPkg/Network.dsc.inc | 5 +++++
NetworkPkg/NetworkDefines.dsc.inc | 4 ++--
SecurityPkg/SecurityPkg.dsc | 2 +-
8 files changed, 16 insertions(+), 8 deletions(-)

--
2.21.0.windows.1


Yao, Jiewen
 

Thanks Zhichao.

Can we remove MD5 from Hash2DxeCrypto ?
I don't see a strong reason to include.
It should only be used by iSCSI.

Also, if possible, I prefer to remove SHA1 from Hash2DxeCrypto as well.

Thank you
Yao Jiewen

-----Original Message-----
From: Gao, Zhichao <zhichao.gao@...>
Sent: Monday, October 26, 2020 5:04 PM
To: devel@edk2.groups.io
Cc: Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek
<lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Sami
Mujawar <sami.mujawar@...>; Leif Lindholm <leif@...>;
Yao, Jiewen <jiewen.yao@...>; Wang, Jian J <jian.j.wang@...>;
Lu, XiaoyuX <xiaoyux.lu@...>; Jiang, Guomin
<guomin.jiang@...>; Kinney, Michael D <michael.d.kinney@...>;
Steele, Kelly <kelly.steele@...>; Sun, Zailiang
<zailiang.sun@...>; Qian, Yi <yi.qian@...>; Liming Gao
<gaoliming@...>; Maciej Rabeda
<maciej.rabeda@...>; Wu, Jiaxin <jiaxin.wu@...>; Fu,
Siyuan <@sfu5>; Feng, Roger <roger.feng@...>
Subject: [PATCH 0/5] Make the MD5 disable as default setting

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021

MD5 is deprecated, make it disable as default for security.
It required to set MD5 enable explicitly if the module is still
using MD5. List the modules that are still using it:
iSCSI, Hash2DxeCrypto, CryptoDxe(Pei, Smm) (with PACKAGE or ALL config).

This patch set would affact the platforms that are using iSCSI
function.

Cc: Jordan Justen <jordan.l.justen@...>
Cc: Laszlo Ersek <lersek@...>
Cc: Ard Biesheuvel <ard.biesheuvel@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Leif Lindholm <leif@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Kelly Steele <kelly.steele@...>
Cc: Zailiang Sun <zailiang.sun@...>
Cc: Yi Qian <yi.qian@...>
Cc: Liming Gao <gaoliming@...>
Cc: Maciej Rabeda <maciej.rabeda@...>
Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Roger Feng <roger.feng@...>
Signed-off-by: Zhichao Gao <zhichao.gao@...>

Zhichao Gao (5):
NetworkPkg/Defines: Make iSCSI disable as default
NetworkPkg: Enable MD5 while enable iSCSI
SecurityPkg/dsc: Explicitly enable MD5 for package build
CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5
CryptoPkg: Make the MD5 disable as default for security

CryptoPkg/CryptoPkg.dsc | 3 +++
CryptoPkg/Driver/Crypto.c | 4 ++--
CryptoPkg/Include/Library/BaseCryptLib.h | 2 +-
CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c | 2 +-
CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +-
NetworkPkg/Network.dsc.inc | 5 +++++
NetworkPkg/NetworkDefines.dsc.inc | 4 ++--
SecurityPkg/SecurityPkg.dsc | 2 +-
8 files changed, 16 insertions(+), 8 deletions(-)

--
2.21.0.windows.1


Gao, Zhichao
 

Let me prepare the V2 to remove them(MD5 and SHA1)。

Thanks,
Zhichao

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@...>
Sent: Monday, October 26, 2020 5:35 PM
To: Gao, Zhichao <zhichao.gao@...>; devel@edk2.groups.io
Cc: Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek
<lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Sami
Mujawar <sami.mujawar@...>; Leif Lindholm <leif@...>; Wang,
Jian J <jian.j.wang@...>; Lu, XiaoyuX <xiaoyux.lu@...>; Jiang,
Guomin <guomin.jiang@...>; Kinney, Michael D
<michael.d.kinney@...>; Steele, Kelly <kelly.steele@...>; Sun,
Zailiang <zailiang.sun@...>; Qian, Yi <yi.qian@...>; Liming Gao
<gaoliming@...>; Maciej Rabeda <maciej.rabeda@...>;
Wu, Jiaxin <jiaxin.wu@...>; Fu, Siyuan <@sfu5>; Feng,
Roger <roger.feng@...>
Subject: RE: [PATCH 0/5] Make the MD5 disable as default setting

Thanks Zhichao.

Can we remove MD5 from Hash2DxeCrypto ?
I don’t see a strong reason to include.
It should only be used by iSCSI.

Also, if possible, I prefer to remove SHA1 from Hash2DxeCrypto as well.

Thank you
Yao Jiewen


-----Original Message-----
From: Gao, Zhichao <zhichao.gao@...>
Sent: Monday, October 26, 2020 5:04 PM
To: devel@edk2.groups.io
Cc: Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek
<lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Sami
Mujawar <sami.mujawar@...>; Leif Lindholm <leif@...>;
Yao, Jiewen <jiewen.yao@...>; Wang, Jian J
<jian.j.wang@...>; Lu, XiaoyuX <xiaoyux.lu@...>; Jiang,
Guomin <guomin.jiang@...>; Kinney, Michael D
<michael.d.kinney@...>; Steele, Kelly <kelly.steele@...>;
Sun, Zailiang <zailiang.sun@...>; Qian, Yi <yi.qian@...>;
Liming Gao <gaoliming@...>; Maciej Rabeda
<maciej.rabeda@...>; Wu, Jiaxin <jiaxin.wu@...>; Fu,
Siyuan <@sfu5>; Feng, Roger <roger.feng@...>
Subject: [PATCH 0/5] Make the MD5 disable as default setting

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021

MD5 is deprecated, make it disable as default for security.
It required to set MD5 enable explicitly if the module is still using
MD5. List the modules that are still using it:
iSCSI, Hash2DxeCrypto, CryptoDxe(Pei, Smm) (with PACKAGE or ALL config).

This patch set would affact the platforms that are using iSCSI
function.

Cc: Jordan Justen <jordan.l.justen@...>
Cc: Laszlo Ersek <lersek@...>
Cc: Ard Biesheuvel <ard.biesheuvel@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Leif Lindholm <leif@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Kelly Steele <kelly.steele@...>
Cc: Zailiang Sun <zailiang.sun@...>
Cc: Yi Qian <yi.qian@...>
Cc: Liming Gao <gaoliming@...>
Cc: Maciej Rabeda <maciej.rabeda@...>
Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Roger Feng <roger.feng@...>
Signed-off-by: Zhichao Gao <zhichao.gao@...>

Zhichao Gao (5):
NetworkPkg/Defines: Make iSCSI disable as default
NetworkPkg: Enable MD5 while enable iSCSI
SecurityPkg/dsc: Explicitly enable MD5 for package build
CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5
CryptoPkg: Make the MD5 disable as default for security

CryptoPkg/CryptoPkg.dsc | 3 +++
CryptoPkg/Driver/Crypto.c | 4 ++--
CryptoPkg/Include/Library/BaseCryptLib.h | 2 +-
CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c | 2 +-
CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +-
NetworkPkg/Network.dsc.inc | 5 +++++
NetworkPkg/NetworkDefines.dsc.inc | 4 ++--
SecurityPkg/SecurityPkg.dsc | 2 +-
8 files changed, 16 insertions(+), 8 deletions(-)

--
2.21.0.windows.1


Feng, Roger <roger.feng@...>
 

+Qi for review

-----Original Message-----
From: Gao, Zhichao <zhichao.gao@...>
Sent: Tuesday, October 27, 2020 8:55 AM
To: Yao, Jiewen <jiewen.yao@...>; devel@edk2.groups.io
Cc: Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek <lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Sami Mujawar <sami.mujawar@...>; Leif Lindholm <leif@...>; Wang, Jian J <jian.j.wang@...>; Lu, XiaoyuX <xiaoyux.lu@...>; Jiang, Guomin <guomin.jiang@...>; Kinney, Michael D <michael.d.kinney@...>; Steele, Kelly <kelly.steele@...>; Sun, Zailiang <zailiang.sun@...>; Qian, Yi <yi.qian@...>; Liming Gao <gaoliming@...>; Maciej Rabeda <maciej.rabeda@...>; Wu, Jiaxin <jiaxin.wu@...>; Fu, Siyuan <@sfu5>; Feng, Roger <roger.feng@...>
Subject: RE: [PATCH 0/5] Make the MD5 disable as default setting

Let me prepare the V2 to remove them(MD5 and SHA1)。

Thanks,
Zhichao

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@...>
Sent: Monday, October 26, 2020 5:35 PM
To: Gao, Zhichao <zhichao.gao@...>; devel@edk2.groups.io
Cc: Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek
<lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Sami
Mujawar <sami.mujawar@...>; Leif Lindholm <leif@...>;
Wang, Jian J <jian.j.wang@...>; Lu, XiaoyuX
<xiaoyux.lu@...>; Jiang, Guomin <guomin.jiang@...>;
Kinney, Michael D <michael.d.kinney@...>; Steele, Kelly
<kelly.steele@...>; Sun, Zailiang <zailiang.sun@...>;
Qian, Yi <yi.qian@...>; Liming Gao <gaoliming@...>;
Maciej Rabeda <maciej.rabeda@...>; Wu, Jiaxin
<jiaxin.wu@...>; Fu, Siyuan <@sfu5>; Feng, Roger
<roger.feng@...>
Subject: RE: [PATCH 0/5] Make the MD5 disable as default setting

Thanks Zhichao.

Can we remove MD5 from Hash2DxeCrypto ?
I don’t see a strong reason to include.
It should only be used by iSCSI.

Also, if possible, I prefer to remove SHA1 from Hash2DxeCrypto as well.

Thank you
Yao Jiewen


-----Original Message-----
From: Gao, Zhichao <zhichao.gao@...>
Sent: Monday, October 26, 2020 5:04 PM
To: devel@edk2.groups.io
Cc: Justen, Jordan L <jordan.l.justen@...>; Laszlo Ersek
<lersek@...>; Ard Biesheuvel <ard.biesheuvel@...>; Sami
Mujawar <sami.mujawar@...>; Leif Lindholm <leif@...>;
Yao, Jiewen <jiewen.yao@...>; Wang, Jian J
<jian.j.wang@...>; Lu, XiaoyuX <xiaoyux.lu@...>; Jiang,
Guomin <guomin.jiang@...>; Kinney, Michael D
<michael.d.kinney@...>; Steele, Kelly
<kelly.steele@...>; Sun, Zailiang <zailiang.sun@...>;
Qian, Yi <yi.qian@...>; Liming Gao <gaoliming@...>;
Maciej Rabeda <maciej.rabeda@...>; Wu, Jiaxin
<jiaxin.wu@...>; Fu, Siyuan <@sfu5>; Feng, Roger
<roger.feng@...>
Subject: [PATCH 0/5] Make the MD5 disable as default setting

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021

MD5 is deprecated, make it disable as default for security.
It required to set MD5 enable explicitly if the module is still
using MD5. List the modules that are still using it:
iSCSI, Hash2DxeCrypto, CryptoDxe(Pei, Smm) (with PACKAGE or ALL config).

This patch set would affact the platforms that are using iSCSI
function.

Cc: Jordan Justen <jordan.l.justen@...>
Cc: Laszlo Ersek <lersek@...>
Cc: Ard Biesheuvel <ard.biesheuvel@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Leif Lindholm <leif@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Kelly Steele <kelly.steele@...>
Cc: Zailiang Sun <zailiang.sun@...>
Cc: Yi Qian <yi.qian@...>
Cc: Liming Gao <gaoliming@...>
Cc: Maciej Rabeda <maciej.rabeda@...>
Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Roger Feng <roger.feng@...>
Signed-off-by: Zhichao Gao <zhichao.gao@...>

Zhichao Gao (5):
NetworkPkg/Defines: Make iSCSI disable as default
NetworkPkg: Enable MD5 while enable iSCSI
SecurityPkg/dsc: Explicitly enable MD5 for package build
CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5
CryptoPkg: Make the MD5 disable as default for security

CryptoPkg/CryptoPkg.dsc | 3 +++
CryptoPkg/Driver/Crypto.c | 4 ++--
CryptoPkg/Include/Library/BaseCryptLib.h | 2 +-
CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c | 2 +-
CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +-
NetworkPkg/Network.dsc.inc | 5 +++++
NetworkPkg/NetworkDefines.dsc.inc | 4 ++--
SecurityPkg/SecurityPkg.dsc | 2 +-
8 files changed, 16 insertions(+), 8 deletions(-)

--
2.21.0.windows.1