one possible issue with ovmf fvb


Gerd Hoffmann
 

Hi,

PcdStatus = PcdSet64S (PcdFlashNvStorageVariableBase64, (UINT32)(UINTN) Ptr);
ASSERT_RETURN_ERROR (PcdStatus);
I guess you are referring to that UINT32 cast?
Not sure why it is there. I think you can just drop it.

Can uefi bios manage memory beyond 4G?
The X64 builds can do that just fine, although they usually store
everything below 4G, so issues like the one above go unnoticed.

HTH,
Gerd


maobibo
 

On 11/25/2021 06:38 PM, Gerd Hoffmann wrote:
Hi,

PcdStatus = PcdSet64S (PcdFlashNvStorageVariableBase64, (UINT32)(UINTN) Ptr);
ASSERT_RETURN_ERROR (PcdStatus);
I guess you are referring to that UINT32 cast?
Not sure why it is there. I think you can just drop it.
Yes, it is. There will be problem if the loongarch bios uses ovmf fvb dxe and
there is only one flat memory hob. UEFI bios memory may be allocated with 64bit
address, so there will be problem.

I will submit one patch to fix this in order to use these common code.

regards
bibo, mao


Can uefi bios manage memory beyond 4G?
The X64 builds can do that just fine, although they usually store
everything below 4G, so issues like the one above go unnoticed.

HTH,
Gerd