Topics

[EXTERNAL] [edk2-devel] [Redfish Discover Header File PATCH] RedfishPkg/Include: EFI Redfish Discover Protocol header file


Rebecca Cran
 

I think the header include guard should have a leading underscore - e.g. _EFI_REDFISH_DISCOVER_PROTOCOL_H_.

And it's nice if there's a comment on the #endif to say what it's for.


--
Rebecca Cran

On 10/12/20 10:33 PM, Abner Chang wrote:
diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h b/RedfishPkg/Include/Protocol/RedfishDiscover.h
new file mode 100644
index 0000000000..574d7a16a6
--- /dev/null
+++ b/RedfishPkg/Include/Protocol/RedfishDiscover.h
@@ -0,0 +1,198 @@
+/** @file
+ This file defines the EFI Redfish Discover Protocol interface.
+
+ (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef EFI_REDFISH_DISCOVER_PROTOCOL_H_
+#define EFI_REDFISH_DISCOVER_PROTOCOL_H_
+