Topics

[EFI Redfish Host Interface PATCH 5/5] RedfishPkg: Add RedfishHostInterfaceDxe to RedfishPkg


Abner Chang
 

Add RedfishHostInterfaceDxe and PlatformHostInterfaceLibNull to Redfish
package.

Signed-off-by: Abner Chang <abner.chang@...>

Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Fan Wang <fan.wang@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Nickle Wang <nickle.wang@...>
---
RedfishPkg/RedfishPkg.dsc | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
index 8acadddefc..be6996b203 100644
--- a/RedfishPkg/RedfishPkg.dsc
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -38,3 +38,9 @@
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
+ RedfishPlatformHostInterfaceLib|RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibNull.inf
+
+[Components]
+ RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibNull.inf
+
+ RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
--
2.17.1


Nickle Wang
 

Hi Abner,

Do we need to specify the library instance under [Components] section when they are specified in [LibraryClasses] already?

Thanks,
Nickle

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>
Sent: Tuesday, October 13, 2020 12:08 PM
To: devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@...>; Siyuan Fu <@sfu5>; Fan
Wang <fan.wang@...>; Jiewen Yao <jiewen.yao@...>; Wang,
Nickle (HPS SW) <nickle.wang@...>
Subject: [EFI Redfish Host Interface PATCH 5/5] RedfishPkg: Add
RedfishHostInterfaceDxe to RedfishPkg

Add RedfishHostInterfaceDxe and PlatformHostInterfaceLibNull to Redfish
package.

Signed-off-by: Abner Chang <abner.chang@...>

Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Fan Wang <fan.wang@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Nickle Wang <nickle.wang@...>
---
RedfishPkg/RedfishPkg.dsc | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
index 8acadddefc..be6996b203 100644
--- a/RedfishPkg/RedfishPkg.dsc
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -38,3 +38,9 @@

DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
eLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf

ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/Dx
eReportStatusCodeLib.inf
+
RedfishPlatformHostInterfaceLib|RedfishPkg/Library/PlatformHostInterface
LibNull/PlatformHostInterfaceLibNull.inf
+
+[Components]
+
RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibN
ull.inf
+
+ RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
--
2.17.1


Abner Chang
 

-----Original Message-----
From: Wang, Nickle (HPS SW)
Sent: Thursday, October 29, 2020 2:37 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>;
devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@...>; Siyuan Fu <@sfu5>; Fan
Wang <fan.wang@...>; Jiewen Yao <jiewen.yao@...>
Subject: RE: [EFI Redfish Host Interface PATCH 5/5] RedfishPkg: Add
RedfishHostInterfaceDxe to RedfishPkg

Hi Abner,

Do we need to specify the library instance under [Components] section
when they are specified in [LibraryClasses] already?
Yes, we have to list the library provided by this package in [Components] section, CI also checks this.

Thanks,
Nickle

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>
Sent: Tuesday, October 13, 2020 12:08 PM
To: devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@...>; Siyuan Fu <@sfu5>;
Fan Wang <fan.wang@...>; Jiewen Yao <jiewen.yao@...>;
Wang, Nickle (HPS SW) <nickle.wang@...>
Subject: [EFI Redfish Host Interface PATCH 5/5] RedfishPkg: Add
RedfishHostInterfaceDxe to RedfishPkg

Add RedfishHostInterfaceDxe and PlatformHostInterfaceLibNull to
Redfish package.

Signed-off-by: Abner Chang <abner.chang@...>

Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Fan Wang <fan.wang@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Nickle Wang <nickle.wang@...>
---
RedfishPkg/RedfishPkg.dsc | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
index 8acadddefc..be6996b203 100644
--- a/RedfishPkg/RedfishPkg.dsc
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -38,3 +38,9 @@

DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
eLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf

ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/Dx
eReportStatusCodeLib.inf
+
RedfishPlatformHostInterfaceLib|RedfishPkg/Library/PlatformHostInterfa
RedfishPlatformHostInterfaceLib|ce
LibNull/PlatformHostInterfaceLibNull.inf
+
+[Components]
+
RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceL
ibN
ull.inf
+
+ RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
--
2.17.1


Nickle Wang
 

Got it. Thanks.

Nickle

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>
Sent: Thursday, October 29, 2020 10:59 PM
To: Wang, Nickle (HPS SW) <nickle.wang@...>; devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@...>; Siyuan Fu <@sfu5>; Fan
Wang <fan.wang@...>; Jiewen Yao <jiewen.yao@...>
Subject: RE: [EFI Redfish Host Interface PATCH 5/5] RedfishPkg: Add
RedfishHostInterfaceDxe to RedfishPkg



-----Original Message-----
From: Wang, Nickle (HPS SW)
Sent: Thursday, October 29, 2020 2:37 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>;
devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@...>; Siyuan Fu <@sfu5>;
Fan Wang <fan.wang@...>; Jiewen Yao <jiewen.yao@...>
Subject: RE: [EFI Redfish Host Interface PATCH 5/5] RedfishPkg: Add
RedfishHostInterfaceDxe to RedfishPkg

Hi Abner,

Do we need to specify the library instance under [Components] section
when they are specified in [LibraryClasses] already?
Yes, we have to list the library provided by this package in [Components]
section, CI also checks this.

Thanks,
Nickle

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist)
<abner.chang@...>
Sent: Tuesday, October 13, 2020 12:08 PM
To: devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@...>; Siyuan Fu
<@sfu5>; Fan Wang <fan.wang@...>; Jiewen Yao
<jiewen.yao@...>; Wang, Nickle (HPS SW)
<nickle.wang@...>
Subject: [EFI Redfish Host Interface PATCH 5/5] RedfishPkg: Add
RedfishHostInterfaceDxe to RedfishPkg

Add RedfishHostInterfaceDxe and PlatformHostInterfaceLibNull to
Redfish package.

Signed-off-by: Abner Chang <abner.chang@...>

Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <@sfu5>
Cc: Fan Wang <fan.wang@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Nickle Wang <nickle.wang@...>
---
RedfishPkg/RedfishPkg.dsc | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
index 8acadddefc..be6996b203 100644
--- a/RedfishPkg/RedfishPkg.dsc
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -38,3 +38,9 @@

DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
eLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf

ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/Dx
eReportStatusCodeLib.inf
+
RedfishPlatformHostInterfaceLib|RedfishPkg/Library/PlatformHostInter
RedfishPlatformHostInterfaceLib|fa
RedfishPlatformHostInterfaceLib|ce
LibNull/PlatformHostInterfaceLibNull.inf
+
+[Components]
+
RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfac
eL
ibN
ull.inf
+
+ RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
--
2.17.1