REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076RiscVVirt is created to support EDK2 for RISC-V qemu virt machine platform. Add maintainer entries. Cc: Andrew Fish <afish@...> Cc: Leif Lindholm <quic_llindhol@...> Cc: Michael D Kinney <michael.d.kinney@...> Signed-off-by: Sunil V L <sunilvl@...> --- Maintainers.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 68f603b48398..fdb27c39b152 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -539,6 +539,10 @@ F: OvmfPkg/XenResetVector/ R: Anthony Perard <anthony.perard@...> [tperard] R: Julien Grall <julien@...> [jgrall] +OvmfPkg: RISC-V Qemu Virt Platform +F: OvmfPkg/RiscVVirt +R: Sunil V L <sunilvl@...> [vlsunil] + PcAtChipsetPkg F: PcAtChipsetPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg-- 2.38.0
|
|

Andrei Warkentin
Reviewed-by: Andrei Warkentin <andrei.warkentin@...>
toggle quoted message
Show quoted text
-----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sunil V L Sent: Saturday, January 28, 2023 1:18 PM To: devel@edk2.groups.io Cc: Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...>; Kinney, Michael D <michael.d.kinney@...> Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076RiscVVirt is created to support EDK2 for RISC-V qemu virt machine platform. Add maintainer entries. Cc: Andrew Fish <afish@...> Cc: Leif Lindholm <quic_llindhol@...> Cc: Michael D Kinney <michael.d.kinney@...> Signed-off-by: Sunil V L <sunilvl@...> --- Maintainers.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 68f603b48398..fdb27c39b152 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -539,6 +539,10 @@ F: OvmfPkg/XenResetVector/ R: Anthony Perard <anthony.perard@...> [tperard] R: Julien Grall <julien@...> [jgrall] +OvmfPkg: RISC-V Qemu Virt Platform +F: OvmfPkg/RiscVVirt +R: Sunil V L <sunilvl@...> [vlsunil] + PcAtChipsetPkg F: PcAtChipsetPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg-- 2.38.0
|
|
Reviewed-by: Michael D Kinney <michael.d.kinney@...>
toggle quoted message
Show quoted text
-----Original Message----- From: Sunil V L <sunilvl@...> Sent: Saturday, January 28, 2023 11:18 AM To: devel@edk2.groups.io Cc: Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...>; Kinney, Michael D <michael.d.kinney@...> Subject: [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RiscVVirt is created to support EDK2 for RISC-V qemu virt machine platform. Add maintainer entries.
Cc: Andrew Fish <afish@...> Cc: Leif Lindholm <quic_llindhol@...> Cc: Michael D Kinney <michael.d.kinney@...> Signed-off-by: Sunil V L <sunilvl@...> --- Maintainers.txt | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt index 68f603b48398..fdb27c39b152 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -539,6 +539,10 @@ F: OvmfPkg/XenResetVector/ R: Anthony Perard <anthony.perard@...> [tperard] R: Julien Grall <julien@...> [jgrall]
+OvmfPkg: RISC-V Qemu Virt Platform +F: OvmfPkg/RiscVVirt +R: Sunil V L <sunilvl@...> [vlsunil] + PcAtChipsetPkg F: PcAtChipsetPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg -- 2.38.0
|
|
Hello I have not tracked all discussion. Sorry for that. May I know if we have discussed the option to create RiscVVirtPkg ? similar to https://github.com/tianocore/edk2/tree/master/ArmVirtPkg . To me, that is more natural place. For the new content on RiscVVirt, I recommend to add one more reviewer/maintainer. I notice the patches are Acked-by: Abner Chang. Can we get his help on that? Thank you Yao, Jiewen
toggle quoted message
Show quoted text
-----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D Kinney Sent: Thursday, February 9, 2023 9:52 AM To: Sunil V L <sunilvl@...>; devel@edk2.groups.io Cc: Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...>; Kinney, Michael D <michael.d.kinney@...> Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
Reviewed-by: Michael D Kinney <michael.d.kinney@...>
-----Original Message----- From: Sunil V L <sunilvl@...> Sent: Saturday, January 28, 2023 11:18 AM To: devel@edk2.groups.io Cc: Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...>; Kinney, Michael D <michael.d.kinney@...>
Subject: [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RiscVVirt is created to support EDK2 for RISC-V qemu virt machine platform. Add maintainer entries.
Cc: Andrew Fish <afish@...> Cc: Leif Lindholm <quic_llindhol@...> Cc: Michael D Kinney <michael.d.kinney@...> Signed-off-by: Sunil V L <sunilvl@...> --- Maintainers.txt | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt index 68f603b48398..fdb27c39b152 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -539,6 +539,10 @@ F: OvmfPkg/XenResetVector/ R: Anthony Perard <anthony.perard@...> [tperard] R: Julien Grall <julien@...> [jgrall]
+OvmfPkg: RISC-V Qemu Virt Platform +F: OvmfPkg/RiscVVirt +R: Sunil V L <sunilvl@...> [vlsunil] + PcAtChipsetPkg F: PcAtChipsetPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg -- 2.38.0
|
|
Hi Jiewen, On Thu, Feb 09, 2023 at 03:32:20AM +0000, Yao, Jiewen wrote: Hello I have not tracked all discussion. Sorry for that. May I know if we have discussed the option to create RiscVVirtPkg ? similar to https://github.com/tianocore/edk2/tree/master/ArmVirtPkg . To me, that is more natural place.
Thanks for the feedback. Yes, this was discussed and recommendation was to add in OvmfPkg instead of creating RiscVVirtPkg.. https://edk2.groups.io/g/devel/message/85932 For the new content on RiscVVirt, I recommend to add one more reviewer/maintainer. I notice the patches are Acked-by: Abner Chang. Can we get his help on that?
Agree, that was in my plan to find out some one. Abner had given up RISC-V mandatory roles. He was helping me here since he was the original to start this. So, I didn't add him but I will be happy if Abner agrees. Will find out and add one more reviewer when I revise the series. Thanks! Sunil
|
|
Thanks.
I agree to add Sunil V L <sunilvl@...> to be a reviewer. Reviewed-by: Jiewen Yao <Jiewen.yao@...>
toggle quoted message
Show quoted text
-----Original Message----- From: Sunil V L <sunilvl@...> Sent: Thursday, February 9, 2023 12:34 PM To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...> Cc: Kinney, Michael D <michael.d.kinney@...>; abner.chang@...; Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...> Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
Hi Jiewen,
On Thu, Feb 09, 2023 at 03:32:20AM +0000, Yao, Jiewen wrote:
Hello I have not tracked all discussion. Sorry for that. May I know if we have discussed the option to create RiscVVirtPkg ? similar to https://github.com/tianocore/edk2/tree/master/ArmVirtPkg . To me, that is more natural place. Thanks for the feedback. Yes, this was discussed and recommendation was to add in OvmfPkg instead of creating RiscVVirtPkg.. https://edk2.groups.io/g/devel/message/85932
For the new content on RiscVVirt, I recommend to add one more reviewer/maintainer.
I notice the patches are Acked-by: Abner Chang. Can we get his help on that?
Agree, that was in my plan to find out some one. Abner had given up RISC-V mandatory roles. He was helping me here since he was the original to start this. So, I didn't add him but I will be happy if Abner agrees.
Will find out and add one more reviewer when I revise the series.
Thanks! Sunil
|
|
[AMD Official Use Only - General]
Hi Jiewen and Sunil, Sorry, I am not allowed to keep working on RISC-V stuff, at least at the moment. Maybe later in the future. 😊 Abner
toggle quoted message
Show quoted text
-----Original Message----- From: Yao, Jiewen <jiewen.yao@...> Sent: Thursday, February 9, 2023 1:07 PM To: Sunil V L <sunilvl@...>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@...>; Chang, Abner <Abner.Chang@...>; Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...> Subject: RE: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Thanks.
I agree to add Sunil V L <sunilvl@...> to be a reviewer. Reviewed-by: Jiewen Yao <Jiewen.yao@...>
-----Original Message----- From: Sunil V L <sunilvl@...> Sent: Thursday, February 9, 2023 12:34 PM To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...> Cc: Kinney, Michael D <michael.d.kinney@...>; abner.chang@...; Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...> Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
Hi Jiewen,
On Thu, Feb 09, 2023 at 03:32:20AM +0000, Yao, Jiewen wrote:
Hello I have not tracked all discussion. Sorry for that. May I know if we have discussed the option to create RiscVVirtPkg ? similar to https://github.com/tianocore/edk2/tree/master/ArmVirtPkg . To me, that is more natural place. Thanks for the feedback. Yes, this was discussed and recommendation was to add in OvmfPkg instead of creating RiscVVirtPkg.. https://edk2.groups.io/g/devel/message/85932
For the new content on RiscVVirt, I recommend to add one more reviewer/maintainer.
I notice the patches are Acked-by: Abner Chang. Can we get his help on that?
Agree, that was in my plan to find out some one. Abner had given up RISC-V mandatory roles. He was helping me here since he was the original to start this. So, I didn't add him but I will be happy if Abner agrees.
Will find out and add one more reviewer when I revise the series.
Thanks! Sunil
|
|
Hi Sunil I did not find any RiscV64QemuVirt related PR there. (I searched RiscV64QemuVirt)
May I know if you have tried the patch series in EDK2 CI?
Thank you Yao, Jiewen
toggle quoted message
Show quoted text
-----Original Message----- From: Yao, Jiewen Sent: Thursday, February 9, 2023 1:07 PM To: Sunil V L <sunilvl@...>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@...>; abner.chang@...; Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...> Subject: RE: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
Thanks.
I agree to add Sunil V L <sunilvl@...> to be a reviewer. Reviewed-by: Jiewen Yao <Jiewen.yao@...>
-----Original Message----- From: Sunil V L <sunilvl@...> Sent: Thursday, February 9, 2023 12:34 PM To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...> Cc: Kinney, Michael D <michael.d.kinney@...>; abner.chang@...; Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...> Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
Hi Jiewen,
On Thu, Feb 09, 2023 at 03:32:20AM +0000, Yao, Jiewen wrote:
Hello I have not tracked all discussion. Sorry for that. May I know if we have discussed the option to create RiscVVirtPkg ? similar to
https://github.com/tianocore/edk2/tree/master/ArmVirtPkg . To me, that is more natural place. Thanks for the feedback. Yes, this was discussed and recommendation was to add in OvmfPkg instead of creating RiscVVirtPkg.. https://edk2.groups.io/g/devel/message/85932
For the new content on RiscVVirt, I recommend to add one more reviewer/maintainer.
I notice the patches are Acked-by: Abner Chang. Can we get his help on that?
Agree, that was in my plan to find out some one. Abner had given up RISC-V mandatory roles. He was helping me here since he was the original to start this. So, I didn't add him but I will be happy if Abner agrees.
Will find out and add one more reviewer when I revise the series.
Thanks! Sunil
|
|
On Thu, Feb 09, 2023 at 02:05:34PM +0000, Yao, Jiewen wrote: Hi Sunil I did not find any RiscV64QemuVirt related PR there. (I searched RiscV64QemuVirt)
May I know if you have tried the patch series in EDK2 CI?
Thank you Yao, Jiewen
Hi Jiewen, Yes, https://github.com/tianocore/edk2/pull/3962 was the PR. Once it succeeded, I closed it since it will keep sending reminder when master branch changes while review is in progress. I am addressing feedback from Mike and Ray. Will raise a new CI Test PR and send the new version of the patch series once it passes. Thanks! Sunil
|
|
Sounds great. Thank you!
toggle quoted message
Show quoted text
-----Original Message----- From: Sunil V L <sunilvl@...> Sent: Thursday, February 9, 2023 11:20 PM To: Yao, Jiewen <jiewen.yao@...> Cc: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@...>; abner.chang@...; Andrew Fish <afish@...>; Leif Lindholm <quic_llindhol@...> Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 20/20] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt
On Thu, Feb 09, 2023 at 02:05:34PM +0000, Yao, Jiewen wrote:
Hi Sunil I did not find any RiscV64QemuVirt related PR there. (I searched RiscV64QemuVirt)
May I know if you have tried the patch series in EDK2 CI?
Thank you Yao, Jiewen
Hi Jiewen,
Yes, https://github.com/tianocore/edk2/pull/3962 was the PR. Once it succeeded, I closed it since it will keep sending reminder when master branch changes while review is in progress.
I am addressing feedback from Mike and Ray. Will raise a new CI Test PR and send the new version of the patch series once it passes.
Thanks! Sunil
|
|