[edk2-platforms][PATCH v4 4/6] Socionext: Platform Build: Resolving newly introduced dependency


Kun Qin
 

Hi Ard,

Could you please help review this patch? Any feedback in appreciated.

Regards,
Kun

On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Leif Lindholm <quic_llindhol@...>
Cc: Masami Hiramatsu <masami.hiramatsu@...>

Signed-off-by: Kun Qin <kuqin12@...>
---

Notes:
v2:
- No review, no change.
v4:
- Updated commit title.

Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
1 file changed, 1 insertion(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 8419c89318fb..917c1532fb3c 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -55,6 +55,7 @@ [LibraryClasses]
!if $(SECURE_BOOT_ENABLE) == TRUE

SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf

SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf

+ PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf

!endif


[LibraryClasses.common.SEC]


Ard Biesheuvel
 

On Thu, 11 Aug 2022 at 00:54, Kun Qin <kuqin12@...> wrote:

Hi Ard,

Could you please help review this patch? Any feedback in appreciated.
Thanks for the fix

Reviewed-by: Ard Biesheuvel <ardb@...>

Pushed as 01e3a8877180..9675047d7245
On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Leif Lindholm <quic_llindhol@...>
Cc: Masami Hiramatsu <masami.hiramatsu@...>

Signed-off-by: Kun Qin <kuqin12@...>
---

Notes:
v2:
- No review, no change.

v4:
- Updated commit title.

Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
1 file changed, 1 insertion(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 8419c89318fb..917c1532fb3c 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -55,6 +55,7 @@ [LibraryClasses]
!if $(SECURE_BOOT_ENABLE) == TRUE

SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf

SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf

+ PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf

!endif



[LibraryClasses.common.SEC]