[edk2-platforms PATCH v1 1/1] Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp


 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3511

The PCD PcdDebugLoadImageMethod, which is consumed by
PeCoffExtraActionLibDebug.inf is only for the DEBUG build.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
index 41dc55a14d..fa41ae923d 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
@@ -148,7 +148,9 @@

gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F # Enable asserts, prints, code, clear memory, and deadloops on asserts.
gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047 # Built in messages: Error, MTRR, info, load, warn, init
+!if $(TARGET) == "DEBUG"
gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 # This is set to INT3 (0x2) for Simics source level debugging
+!endif

gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable|0
gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x0
--
2.25.1


Chiu, Chasel
 

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Takuto
Naito
Sent: Wednesday, July 28, 2021 11:43 PM
To: devel@edk2.groups.io
Cc: Takuto Naito <naitaku@gmail.com>; Oram, Isaac W
<isaac.w.oram@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1]
Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3511

The PCD PcdDebugLoadImageMethod, which is consumed by
PeCoffExtraActionLibDebug.inf is only for the DEBUG build.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
index 41dc55a14d..fa41ae923d 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
@@ -148,7 +148,9 @@

gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F # Enable
asserts, prints, code, clear memory, and deadloops on asserts.
gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047 #
Built in messages: Error, MTRR, info, load, warn, init
+!if $(TARGET) == "DEBUG"
gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2
# This is set to INT3 (0x2) for Simics source level debugging
+!endif

gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable|0
gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x0
--
2.25.1





Chiu, Chasel
 

Patch submitted: bee9efb7524dc06799ff65e6e056c7725a54c7e1

Thanks,
Chasel

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Takuto
Naito
Sent: Wednesday, July 28, 2021 11:43 PM
To: devel@edk2.groups.io
Cc: Takuto Naito <naitaku@gmail.com>; Oram, Isaac W
<isaac.w.oram@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1]
Platform/Intel/WhitleyOpenBoardPkg: Fix build error of WilsonCityRvp

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3511

The PCD PcdDebugLoadImageMethod, which is consumed by
PeCoffExtraActionLibDebug.inf is only for the DEBUG build.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
index 41dc55a14d..fa41ae923d 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
@@ -148,7 +148,9 @@

gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F # Enable
asserts, prints, code, clear memory, and deadloops on asserts.
gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047 #
Built in messages: Error, MTRR, info, load, warn, init
+!if $(TARGET) == "DEBUG"
gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2
# This is set to INT3 (0x2) for Simics source level debugging
+!endif

gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable|0
gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x0
--
2.25.1