[edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE


Benjamin Doron
 

While I am unable to test IPMI changes, this patch should ensure that
the ACPI table can be located.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf |=
2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Post=
Memory.fdf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Post=
Memory.fdf
index b5b37ddd9f5a..ba19a03baa8a 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.=
fdf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.=
fdf
@@ -7,7 +7,7 @@
#=0D
##=0D
=0D
- INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf=0D
+ INF RuleOverride =3D DRIVER_ACPITABLE OutOfBandManagement/IpmiFeaturePkg=
/BmcAcpi/BmcAcpi.inf=0D
INF OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf=0D
INF OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf=0D
INF OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf=0D
--=20
2.31.1


Nate DeSimone
 

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Benjamin Doron <benjamin.doron00@gmail.com>
Sent: Wednesday, August 4, 2021 1:43 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desimone@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>
Subject: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is
DRIVER_ACPITABLE

While I am unable to test IPMI changes, this patch should ensure that the
ACPI table can be located.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---

Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMem
ory.fdf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
mory.fdf
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
mory.fdf
index b5b37ddd9f5a..ba19a03baa8a 100644
---
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
mory.fdf
+++
b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
mo
+++ ry.fdf
@@ -7,7 +7,7 @@
# ## - INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf+
INF RuleOverride = DRIVER_ACPITABLE
OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf INF
OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf INF
OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf INF
OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf--
2.31.1


Benjamin Doron
 

It appears that this fix was already committed as part of commit 2333ea4. How do I drop this patch?


On Tue., Aug. 17, 2021, 1:59 p.m. Desimone, Nathaniel L, <nathaniel.l.desimone@...> wrote:
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

> -----Original Message-----
> From: Benjamin Doron <benjamin.doron00@...>
> Sent: Wednesday, August 4, 2021 1:43 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@...>; Desimone, Nathaniel L
> <nathaniel.l.desimone@...>; Liming Gao
> <gaoliming@...>
> Subject: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is
> DRIVER_ACPITABLE
>
> While I am unable to test IPMI changes, this patch should ensure that the
> ACPI table can be located.
>
> Cc: Isaac Oram <isaac.w.oram@...>
> Cc: Nate DeSimone <nathaniel.l.desimone@...>
> Cc: Liming Gao <gaoliming@...>
> Signed-off-by: Benjamin Doron <benjamin.doron00@...>
> ---
>
> Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMem
> ory.fdf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mory.fdf
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mory.fdf
> index b5b37ddd9f5a..ba19a03baa8a 100644
> ---
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mory.fdf
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mo
> +++ ry.fdf
> @@ -7,7 +7,7 @@
>  # ## -  INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf+
> INF RuleOverride = DRIVER_ACPITABLE
> OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf   INF
> OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf   INF
> OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf   INF
> OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf--
> 2.31.1


Nate DeSimone
 

Hi Benjamin,

 

I’ll just push the AcpiDebugFeaturePkg change.

 

Thanks,

Nate

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron
Sent: Tuesday, August 17, 2021 11:04 AM
To: Desimone, Nathaniel L <nathaniel.l.desimone@...>
Cc: devel@edk2.groups.io; Oram, Isaac W <isaac.w.oram@...>; Liming Gao <gaoliming@...>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE

 

It appears that this fix was already committed as part of commit 2333ea4. How do I drop this patch?

 

On Tue., Aug. 17, 2021, 1:59 p.m. Desimone, Nathaniel L, <nathaniel.l.desimone@...> wrote:

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

> -----Original Message-----
> From: Benjamin Doron <benjamin.doron00@...>
> Sent: Wednesday, August 4, 2021 1:43 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@...>; Desimone, Nathaniel L
> <nathaniel.l.desimone@...>; Liming Gao
> <gaoliming@...>
> Subject: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is
> DRIVER_ACPITABLE
>
> While I am unable to test IPMI changes, this patch should ensure that the
> ACPI table can be located.
>
> Cc: Isaac Oram <isaac.w.oram@...>
> Cc: Nate DeSimone <nathaniel.l.desimone@...>
> Cc: Liming Gao <gaoliming@...>
> Signed-off-by: Benjamin Doron <benjamin.doron00@...>
> ---
>
> Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMem
> ory.fdf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mory.fdf
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mory.fdf
> index b5b37ddd9f5a..ba19a03baa8a 100644
> ---
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mory.fdf
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe
> mo
> +++ ry.fdf
> @@ -7,7 +7,7 @@
>  # ## -  INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf+
> INF RuleOverride = DRIVER_ACPITABLE
> OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf   INF
> OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf   INF
> OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf   INF
> OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf--
> 2.31.1