[edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry


Benjamin Doron
 

In the case that there are too many EfiRuntimeServicesData entries, this
was incorrectly printing the number of EfiRuntimeServicesCode entries.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemor=
yMap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D=
xeCheckMemoryMap.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCh=
eckLib/DxeCheckMemoryMap.c
index fce44bf73e9d..b8ebac8fe304 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck=
MemoryMap.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck=
MemoryMap.c
@@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n", EntryCount=
[EfiRuntimeServicesCode]));=0D
}=0D
if (EntryCount[EfiRuntimeServicesData] > 1) {=0D
- DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount=
[EfiRuntimeServicesCode]));=0D
+ DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount=
[EfiRuntimeServicesData]));=0D
}=0D
if (EntryCount[EfiACPIMemoryNVS] > 1) {=0D
DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n", EntryCount[EfiAC=
PIMemoryNVS]));=0D
@@ -300,4 +300,4 @@ TestPointCheckUefiMemoryMap (
Done:=0D
DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckUefiMemoryMap - Exit\n")=
);=0D
return Status;=0D
-}
\ No newline at end of file
+}=0D
--=20
2.31.1


Chiu, Chasel
 

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

-----Original Message-----
From: Benjamin Doron <benjamin.doron00@gmail.com>
Sent: Tuesday, July 27, 2021 6:56 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib:
Correctly print memory map entry

In the case that there are too many EfiRuntimeServicesData entries, this was
incorrectly printing the number of EfiRuntimeServicesCode entries.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---

Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMem
oryMap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git
a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
moryMap.c
b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
moryMap.c
index fce44bf73e9d..b8ebac8fe304 100644
---
a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
moryMap.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
+++ eckMemoryMap.c
@@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n",
EntryCount[EfiRuntimeServicesCode])); } if
(EntryCount[EfiRuntimeServicesData] > 1) {- DEBUG ((DEBUG_ERROR,
"EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));+
DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n",
EntryCount[EfiRuntimeServicesData])); } if (EntryCount[EfiACPIMemoryNVS] >
1) { DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n",
EntryCount[EfiACPIMemoryNVS]));@@ -300,4 +300,4 @@
TestPointCheckUefiMemoryMap (
Done: DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap -
Exit\n")); return Status;-}
\ No newline at end of file
+}--
2.31.1


Nate DeSimone
 

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Benjamin Doron <benjamin.doron00@gmail.com>
Sent: Monday, July 26, 2021 3:56 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry

In the case that there are too many EfiRuntimeServicesData entries, this was incorrectly printing the number of EfiRuntimeServicesCode entries.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
index fce44bf73e9d..b8ebac8fe304 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
+++ eckMemoryMap.c
@@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n", EntryCount[EfiRuntimeServicesCode])); } if (EntryCount[EfiRuntimeServicesData] > 1) {- DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));+ DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesData])); } if (EntryCount[EfiACPIMemoryNVS] > 1) { DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n", EntryCount[EfiACPIMemoryNVS]));@@ -300,4 +300,4 @@ TestPointCheckUefiMemoryMap (
Done: DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap - Exit\n")); return Status;-}
\ No newline at end of file
+}--
2.31.1


Nate DeSimone
 

-----Original Message-----
From: Benjamin Doron <benjamin.doron00@gmail.com>
Sent: Monday, July 26, 2021 3:56 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry

In the case that there are too many EfiRuntimeServicesData entries, this was incorrectly printing the number of EfiRuntimeServicesCode entries.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
index fce44bf73e9d..b8ebac8fe304 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
+++ eckMemoryMap.c
@@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n", EntryCount[EfiRuntimeServicesCode])); } if (EntryCount[EfiRuntimeServicesData] > 1) {- DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));+ DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesData])); } if (EntryCount[EfiACPIMemoryNVS] > 1) { DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n", EntryCount[EfiACPIMemoryNVS]));@@ -300,4 +300,4 @@ TestPointCheckUefiMemoryMap (
Done: DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap - Exit\n")); return Status;-}
\ No newline at end of file
+}--
2.31.1