Topics

[edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove PlatformInitPreMem ReportFvLib dependency


Michael Kubacki
 

From: Michael Kubacki <michael.kubacki@...>

PlatformInitPreMem does not actually use the ReportFvLib API. This
change removes the library dependency in PlatformInitPreMem.inf so
platforms using this module with a custom BoardInitLib are not
forced to link a ReportFvLib.

Cc: Chasel Chiu <chasel.chiu@...>
Cc: Nate DeSimone <@natedesimone>
Cc: Liming Gao <gaoliming@...>
Cc: Eric Dong <eric.dong@...>
Signed-off-by: Michael Kubacki <michael.kubacki@...>
---
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | 1 -
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 1 -
2 files changed, 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
index 48cbe0dfbec2..6519fdd04259 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
@@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Library/TimerLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/PeiServicesLib.h>
-#include <Library/ReportFvLib.h>
#include <Ppi/ReadOnlyVariable2.h>
#include <Ppi/MemoryDiscovered.h>
#include <Ppi/FirmwareVolumeInfo.h>
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
index 8e828ff2ac4b..e37bcba56085 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
@@ -24,7 +24,6 @@ [LibraryClasses]
MemoryAllocationLib
PeimEntryPoint
PeiServicesLib
- ReportFvLib
TestPointCheckLib
TimerLib
SetCacheMtrrLib
--
2.28.0.windows.1


Nate DeSimone
 

Reviewed-by: Nate DeSimone <@natedesimone>

-----Original Message-----
From: @michael.kubacki <@michael.kubacki>
Sent: Monday, October 26, 2020 1:04 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@...>; Desimone, Nathaniel L
<@natedesimone>; Liming Gao
<gaoliming@...>; Dong, Eric <eric.dong@...>
Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove
PlatformInitPreMem ReportFvLib dependency

From: Michael Kubacki <michael.kubacki@...>

PlatformInitPreMem does not actually use the ReportFvLib API. This change
removes the library dependency in PlatformInitPreMem.inf so platforms
using this module with a custom BoardInitLib are not forced to link a
ReportFvLib.

Cc: Chasel Chiu <chasel.chiu@...>
Cc: Nate DeSimone <@natedesimone>
Cc: Liming Gao <gaoliming@...>
Cc: Eric Dong <eric.dong@...>
Signed-off-by: Michael Kubacki <michael.kubacki@...>
---

Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
Mem.c | 1 -

Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
Mem.inf | 1 -
2 files changed, 2 deletions(-)

diff --git
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.c
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.c
index 48cbe0dfbec2..6519fdd04259 100644
---
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
+++ mInitPreMem.c
@@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include
<Library/TimerLib.h> #include <Library/BaseMemoryLib.h> #include
<Library/PeiServicesLib.h> -#include <Library/ReportFvLib.h> #include
<Ppi/ReadOnlyVariable2.h> #include <Ppi/MemoryDiscovered.h> #include
<Ppi/FirmwareVolumeInfo.h> diff --git
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.inf
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.inf
index 8e828ff2ac4b..e37bcba56085 100644
---
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
+++ mInitPreMem.inf
@@ -24,7 +24,6 @@ [LibraryClasses]
MemoryAllocationLib
PeimEntryPoint
PeiServicesLib
- ReportFvLib
TestPointCheckLib
TimerLib
SetCacheMtrrLib
--
2.28.0.windows.1


Nate DeSimone
 

-----Original Message-----
From: @michael.kubacki <@michael.kubacki>
Sent: Monday, October 26, 2020 1:04 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@...>; Desimone, Nathaniel L
<@natedesimone>; Liming Gao
<gaoliming@...>; Dong, Eric <eric.dong@...>
Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Remove
PlatformInitPreMem ReportFvLib dependency

From: Michael Kubacki <michael.kubacki@...>

PlatformInitPreMem does not actually use the ReportFvLib API. This change
removes the library dependency in PlatformInitPreMem.inf so platforms
using this module with a custom BoardInitLib are not forced to link a
ReportFvLib.

Cc: Chasel Chiu <chasel.chiu@...>
Cc: Nate DeSimone <@natedesimone>
Cc: Liming Gao <gaoliming@...>
Cc: Eric Dong <eric.dong@...>
Signed-off-by: Michael Kubacki <michael.kubacki@...>
---

Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
Mem.c | 1 -

Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
Mem.inf | 1 -
2 files changed, 2 deletions(-)

diff --git
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.c
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.c
index 48cbe0dfbec2..6519fdd04259 100644
---
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
+++ mInitPreMem.c
@@ -15,7 +15,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include
<Library/TimerLib.h> #include <Library/BaseMemoryLib.h> #include
<Library/PeiServicesLib.h> -#include <Library/ReportFvLib.h> #include
<Ppi/ReadOnlyVariable2.h> #include <Ppi/MemoryDiscovered.h> #include
<Ppi/FirmwareVolumeInfo.h> diff --git
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.inf
b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.inf
index 8e828ff2ac4b..e37bcba56085 100644
---
a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
reMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor
+++ mInitPreMem.inf
@@ -24,7 +24,6 @@ [LibraryClasses]
MemoryAllocationLib
PeimEntryPoint
PeiServicesLib
- ReportFvLib
TestPointCheckLib
TimerLib
SetCacheMtrrLib
--
2.28.0.windows.1