回复: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg


gaoliming
 

Ray:

  I may suggest to always require BufferOneElement. The consumer code may not know ElementSize. To avoid the error, the consumer must allocate buffer for BufferOneElement. If so, BufferOneElement is the required parameter.

 

Thanks

Liming

发件人: Ni, Ray <ray.ni@...>
发送时间: 2021924 11:53
收件人: devel@edk2.groups.io; Ni, Ray <ray.ni@...>; Chan, Amy <amy.chan@...>; gaoliming <gaoliming@...>; 'Andrew Fish' <afish@...>
抄送: Kinney, Michael D <michael.d.kinney@...>; 'Gao, Liming' <liming.gao@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang, Jian J <jian.j.wang@...>; Gao, Zhichao <zhichao.gao@...>
主题: RE: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

 

More details on new QuickSort() API:

  The new API needs to carry additional parameter “BufferOneElement”.

  This parameter gives QuickSort() the temporary buffer for swapping in sorting.

  It’s to avoid BaseLib depends on MemoryAllocationLib.

 

@param [in] BufferOneElement  When ElementSize > 256, caller needs to provide a buffer whose size
                              equals to ElementSize. It’s used by QuickSort() for swapping in sorting.

                              When ElementSize <= 256, QuickSort() uses a local stack 256-byte buffer.

 

@retval EFI_INVALID_PARAMETER When (ElementSize > 256) and (BufferOneElement == NULL).

VOID

EFIAPI

QuickSort (

  IN OUT   VOID                         *BufferToSort,

  IN CONST UINTN                        ElementCount,

  IN CONST UINTN                        ElementSize,

  IN       SORT_COMPARE                 CompareFunction,

  IN       VOID                         *BufferOneElement OPTIONAL

  );

 

Any comments?

 

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
Sent: Wednesday, September 22, 2021 2:04 PM
To: Chan, Amy <amy.chan@...>; gaoliming <gaoliming@...>; 'Andrew Fish' <afish@...>; 'edk2-devel-groups-io' <devel@edk2.groups.io>
Cc: Kinney, Michael D <michael.d.kinney@...>; 'Gao, Liming' <liming.gao@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang, Jian J <jian.j.wang@...>; Gao, Zhichao <zhichao.gao@...>
Subject: Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

 

I don’t see objection so far.

So, the final solution is:

  1. Add QuickSort() API to BaseLib in MdePkg.
  2. Update existing MdeModulePkg/SortLib to use QuickSort() in the implementation (proposed by Andrew Fish and Liming Gao)
  3. Update UefiCpuPkg to use QuickSortLib to remove improper dependency on MdeModulePkg

Thanks,

Ray

 

From: Ni, Ray
Sent: Thursday, September 16, 2021 10:48 AM
To: Chan, Amy <amy.chan@...>; gaoliming <gaoliming@...>; 'Andrew Fish' <afish@...>; 'edk2-devel-groups-io' <devel@edk2.groups.io>
Cc: Kinney, Michael D <michael.d.kinney@...>; 'Gao, Liming' <liming.gao@...>; Liu, Zhiguang <Zhiguang.Liu@...>; Wang, Jian J <jian.j.wang@...>; Gao, Zhichao <zhichao.gao@...>
Subject: RE: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

 

Amy,

No. We only Add QuickSort() function API into BaseLib.h.

 

From: Chan, Amy <amy.chan@...>
Sent: Thursday, September 16, 2021 10:46 AM
To: gaoliming <gaoliming@...>; 'Andrew Fish' <afish@...>; 'edk2-devel-groups-io' <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>; 'Gao, Liming' <liming.gao@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang, Jian J <jian.j.wang@...>; Gao, Zhichao <zhichao.gao@...>
Subject: RE: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

 

Just to double confirm, will we have the null instance of QuickSort in MdePkg?

 

Regards,

Amy

 

From: gaoliming <gaoliming@...>
Sent: Thursday, September 16, 2021 10:23 AM
To: 'Andrew Fish' <afish@...>; 'edk2-devel-groups-io' <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>; 'Gao, Liming' <liming.gao@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang, Jian J <jian.j.wang@...>; Gao, Zhichao <zhichao.gao@...>; Chan, Amy <amy.chan@...>
Subject:
回复: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

 

Andrew:

 Thanks for your suggestion. I think your idea is better. We add new QuickSort() API to BaseLib, and update SortLib library instance to consume BaseLib QuickSort() API. This way has no change in current SortLib library class. It is the compatible solution.

 

Thanks

Liming

发件人: Andrew Fish <afish@...>
发送时间: 2021916 10:13
收件人: edk2-devel-groups-io <devel@edk2.groups.io>; Liming Gao <gaoliming@...>
抄送: Ni, Ray <ray.ni@...>; Mike Kinney <michael.d.kinney@...>; Gao, Liming <liming.gao@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang, Jian J <jian.j.wang@...>; Gao, Zhichao <zhichao.gao@...>; Chan, Amy <amy.chan@...>
主题: Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

 

 

 

On Sep 15, 2021, at 6:26 PM, gaoliming <gaoliming@...> wrote:

 

Ray:

 SortLib has been added since 2015. I would suggest to still keep this library class. To resolve the package dependency, my proposal is to move the library class header file SortLib.h from MdeModulePkg to MdePkg, and still keep the library instance in MdeModulePkg. This proposal has no impact on the existing platform. 

 

 

If we add QuickSort() API to the BaseLib can we not just port the existing MdeModulePkg/SortLib to use QuickSort() in the implementation? Or is there some other way to add the new thing in a backward compatible way.

 

Thanks,

 

Andrew Fish

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ni, Ray
发送时间: 2021914 14:15
收件人: Kinney, Michael D <michael.d.kinney@...>; Gao, Liming <liming.gao@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang, Jian J <jian.j.wang@...>; Gao, Zhichao <zhichao.gao@...>
抄送: devel@edk2.groups.io; Chan, Amy <amy.chan@...>
主题: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

 

Hi package maintainers of MdePkg, MdeModulePkg and ShellPkg, community,

 

A commit (UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array) to UefiCpuPkg let
UefiCpuPkg depend on MdeModulePkg because the SortLib class and instances are all in MdeModulePkg.

 

UefiCpuPkg depending on MdeModulePkg breaks the rule that “UefiCpuPkg should ONLY depend on MdePkg”.

 

To address this issue, there are two approaches:

  1. Duplicate the sort logic in UefiCpuPkg to not depend on MdeModulePkg/SortLib
  2. Add QuickSort() API to BaseLib in MdePkg.

 

Approach #2 (MdePkg/BaseLib/QuickSort) makes more sense because quick sort is a standard algorithm.

We encourage consumers to update their code to use the quick sort in MdePkg and gradually deprecate today’s MdeModulePkg/SortLib.

 

If you don’t have concerns, I plan to:

  1. “Add QuickSort() to BaseLib” and update all existing consumers to use this API instead.

VOID

EFIAPI

QuickSort (

  IN OUT VOID                   *BufferToSort,

  IN CONST UINTN                Count,

  IN CONST UINTN                ElementSize,

  IN       SORT_COMPARE         CompareFunction

  );

 

  1. “Add new ShellPkg/SortCompareLib”

Background: ShellPkg requires to sort devicepath/string so 3 APIs in UefiSortLib (DevicePathCompare, StringNoCaseCompare, StringCompare) are provided for Shell usage. we can move the 3 APIs to the SortCompareLib and update Shell code to use BaseLib/QuickSort directly, with the sort compare function from SortCompareLib.

 

Any concerns?

 

Thanks,

Ray