回复: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow


gaoliming
 

Create PR https://github.com/tianocore/edk2/pull/1728 for it.

This patch has been reviewed by Ray Ni.

Thanks
Liming

-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sumana
Venur
发送时间: 2021年6月12日 1:02
收件人: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
抄送: devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase
the width of the data read during oprom shadow

Hello Maintainers

This patch is for MdeModulePkg/Bus. Please review and help with merging to
master
It was sent a few months ago, might have been reviewed already. But due to
CI failures and low importance it was lost.

Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/

Thanks
Sumana

-----Original Message-----
From: Venur, Sumana <sumana.venur@intel.com>
Sent: Friday, June 11, 2021 9:38 AM
To: devel@edk2.groups.io
Cc: Venur, Sumana <sumana.venur@intel.com>
Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of
the data read during oprom shadow

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989

Long times spent on shadowing oprom from graphics card to system memory.
We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit reads to reduce the time for oprom
shadow

Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..a981f93f43 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,9 +521,9 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint32,
RomBar,
- (UINT32) RomImageSize,
+ (UINT32)
RomImageSize/sizeof(UINT32),
Image
);
RomInMemory = Image;
--
2.16.2.windows.1





Laszlo Ersek
 

On 06/17/21 03:33, gaoliming wrote:
Create PR https://github.com/tianocore/edk2/pull/1728 for it.

This patch has been reviewed by Ray Ni.
Yes, here:

https://edk2.groups.io/g/devel/message/70091
https://listman.redhat.com/archives/edk2-devel-archive/2021-January/msg00578.html

msgid
<CO1PR11MB493022CF646498C69E13B34A8CAC0@CO1PR11MB4930.namprd11.prod.outlook.com>

(FWIW, the repost should have included Ray's R-b.)

Thanks
Laszlo


Thanks
Liming
-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sumana
Venur
发送时间: 2021年6月12日 1:02
收件人: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
抄送: devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase
the width of the data read during oprom shadow

Hello Maintainers

This patch is for MdeModulePkg/Bus. Please review and help with merging to
master
It was sent a few months ago, might have been reviewed already. But due to
CI failures and low importance it was lost.

Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/

Thanks
Sumana

-----Original Message-----
From: Venur, Sumana <sumana.venur@intel.com>
Sent: Friday, June 11, 2021 9:38 AM
To: devel@edk2.groups.io
Cc: Venur, Sumana <sumana.venur@intel.com>
Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of
the data read during oprom shadow

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989

Long times spent on shadowing oprom from graphics card to system memory.
We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit reads to reduce the time for oprom
shadow

Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..a981f93f43 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,9 +521,9 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint32,
RomBar,
- (UINT32) RomImageSize,
+ (UINT32)
RomImageSize/sizeof(UINT32),
Image
);
RomInMemory = Image;
--
2.16.2.windows.1