[PATCH] MdeModulePkg: Correct memory type in PrePiDxeCis.h


Ard Biesheuvel
 

On Sun, 29 Jan 2023 at 06:16, gaoliming via groups.io
<gaoliming@...> wrote:

Reviewed-by: Liming Gao <gaoliming@...>

Merged as #3970

Thanks all


-----邮件原件-----
发件人: Dionna Amalie Glaze <dionnaglaze@...>
发送时间: 2023年1月28日 8:02
收件人: Xu, Min M <min.m.xu@...>
抄送: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...>; Kinney,
Michael D <michael.d.kinney@...>; Gao, Liming
<gaoliming@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang,
Jian J <jian.j.wang@...>
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in
PrePiDxeCis.h

BTW, you need to add below guys in the CC list because they're the
reviewers/maintainers of the pkgs.

MdePkg:
M: Michael D Kinney <michael.d.kinney@...> [mdkinney]
M: Liming Gao <gaoliming@...> [lgao4]
R: Zhiguang Liu <zhiguang.liu@...> [LiuZhiguang001]

MdeModulePkg
M: Jian J Wang <jian.j.wang@...> [jwang36]
M: Liming Gao <gaoliming@...> [lgao4]
CC'd, thanks.

--
-Dionna Glaze, PhD (she/her)






Michael D Kinney
 

Hi Ard,

Can you explain the process being followed here for content like this.

The EDK II Code First Process as detailed below requires all content to only
be added to edk2-staging repo and used from there before spec changes become
public. Content is only added to the edk2 repo until after the spec with the
change is public.

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process

This process was reviewed and approved by the community. If there is a need
for an alternate process, then that needs to be proposed, reviewed, and accepted.

Thanks,

Mike

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
Sent: Monday, January 30, 2023 6:01 AM
To: devel@edk2.groups.io; Gao, Liming <gaoliming@...>
Cc: Dionna Amalie Glaze <dionnaglaze@...>; Xu, Min M <min.m.xu@...>; Yao, Jiewen
<jiewen.yao@...>; Kinney, Michael D <michael.d.kinney@...>; Liu, Zhiguang <zhiguang.liu@...>;
Wang, Jian J <jian.j.wang@...>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in PrePiDxeCis.h

On Sun, 29 Jan 2023 at 06:16, gaoliming via groups.io
<gaoliming@...> wrote:

Reviewed-by: Liming Gao <gaoliming@...>

Merged as #3970

Thanks all


-----邮件原件-----
发件人: Dionna Amalie Glaze <dionnaglaze@...>
发送时间: 2023年1月28日 8:02
收件人: Xu, Min M <min.m.xu@...>
抄送: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...>; Kinney,
Michael D <michael.d.kinney@...>; Gao, Liming
<gaoliming@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang,
Jian J <jian.j.wang@...>
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in
PrePiDxeCis.h

BTW, you need to add below guys in the CC list because they're the
reviewers/maintainers of the pkgs.

MdePkg:
M: Michael D Kinney <michael.d.kinney@...> [mdkinney]
M: Liming Gao <gaoliming@...> [lgao4]
R: Zhiguang Liu <zhiguang.liu@...> [LiuZhiguang001]

MdeModulePkg
M: Jian J Wang <jian.j.wang@...> [jwang36]
M: Liming Gao <gaoliming@...> [lgao4]
CC'd, thanks.

--
-Dionna Glaze, PhD (she/her)








Ard Biesheuvel
 

On Mon, 30 Jan 2023 at 17:27, Kinney, Michael D
<michael.d.kinney@...> wrote:

Hi Ard,

Can you explain the process being followed here for content like this.

The EDK II Code First Process as detailed below requires all content to only
be added to edk2-staging repo and used from there before spec changes become
public. Content is only added to the edk2 repo until after the spec with the
change is public.

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process

This process was reviewed and approved by the community. If there is a need
for an alternate process, then that needs to be proposed, reviewed, and accepted.
Hello Mike,

I was not involved at all in the creation of these definitions. This
patch merely fixes the wrong index value that was introduced by

commit 502c01c5028038e4e6b4512e9c66be0ec4d11492
Author: Min M Xu <min.m.xu@...>
Date: Tue Nov 1 13:13:43 2022 +0800

MdePkg: Add UEFI Unaccepted memory definition

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937

Plase refer to:
UEFI Spec v2.9 Table 7-5 Memory Type Usage before ExitBootServices()

Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <gaoliming@...>
Cc: Zhiguang Liu <zhiguang.liu@...>
Cc: Erdem Aktas <erdemaktas@...>
Cc: Gerd Hoffmann <kraxel@...>
Cc: James Bottomley <jejb@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Tom Lendacky <thomas.lendacky@...>
Reviewed-by: Jiewen Yao <jiewen.yao@...>
Acked-by: Gerd Hoffmann <kraxel@...>
Reviewed-by: Liming Gao <gaoliming@...>
Signed-off-by: Min Xu <min.m.xu@...>


Michael D Kinney
 

Thanks for the pointer.

Mike

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
Sent: Monday, January 30, 2023 8:54 AM
To: Kinney, Michael D <michael.d.kinney@...>
Cc: devel@edk2.groups.io; Gao, Liming <gaoliming@...>; Dionna Amalie Glaze <dionnaglaze@...>; Xu,
Min M <min.m.xu@...>; Yao, Jiewen <jiewen.yao@...>; Liu, Zhiguang <zhiguang.liu@...>; Wang, Jian J
<jian.j.wang@...>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in PrePiDxeCis.h

On Mon, 30 Jan 2023 at 17:27, Kinney, Michael D
<michael.d.kinney@...> wrote:

Hi Ard,

Can you explain the process being followed here for content like this.

The EDK II Code First Process as detailed below requires all content to only
be added to edk2-staging repo and used from there before spec changes become
public. Content is only added to the edk2 repo until after the spec with the
change is public.

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process

This process was reviewed and approved by the community. If there is a need
for an alternate process, then that needs to be proposed, reviewed, and accepted.
Hello Mike,

I was not involved at all in the creation of these definitions. This
patch merely fixes the wrong index value that was introduced by

commit 502c01c5028038e4e6b4512e9c66be0ec4d11492
Author: Min M Xu <min.m.xu@...>
Date: Tue Nov 1 13:13:43 2022 +0800

MdePkg: Add UEFI Unaccepted memory definition

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937

Plase refer to:
UEFI Spec v2.9 Table 7-5 Memory Type Usage before ExitBootServices()

Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <gaoliming@...>
Cc: Zhiguang Liu <zhiguang.liu@...>
Cc: Erdem Aktas <erdemaktas@...>
Cc: Gerd Hoffmann <kraxel@...>
Cc: James Bottomley <jejb@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Tom Lendacky <thomas.lendacky@...>
Reviewed-by: Jiewen Yao <jiewen.yao@...>
Acked-by: Gerd Hoffmann <kraxel@...>
Reviewed-by: Liming Gao <gaoliming@...>
Signed-off-by: Min Xu <min.m.xu@...>