[edk2-platforms][PATCH V2 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID


Sami Mujawar
 

Hi Sahil,

Than you for this patch.
Can you add some explanation to the commit message, on why this change is required and what does this patch fix, please?

Regards,

Sami Mujawar


Samer El-Haj-Mahmoud
 

Acked-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of sahil via
groups.io
Sent: Wednesday, November 30, 2022 5:29 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@...>; Leif Lindholm
<leif@...>; Sami Mujawar <Sami.Mujawar@...>; Sahil
<Sahil@...>
Subject: [edk2-devel] [edk2-platforms][PATCH V2 1/1]
Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID

There is no need for a separate ID for CCIX host bridge,
therefore reusing PCIe PNP ID for CCIX.

Signed-off-by: sahil <sahil@...>
---

Notes:
v2:
- removed licence fix, to be pushed separately [Leif Lindholm]

Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4
++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git
a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
index 1f38f654a8ce..6a154d771126 100644
--- a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
+++ b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
@@ -65,8 +65,8 @@ STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH
mEfiPciRootBridgeDevicePath[ROOT_COMPLEX_
(UINT8)(sizeof (ACPI_HID_DEVICE_PATH) >> 8)

}

},

- EISA_PNP_ID(0x0A09), // CCIX

- 0

+ EISA_PNP_ID(0x0A08), // CCIX

+ 1

},

{

END_DEVICE_PATH_TYPE,

--
2.25.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96732): https://edk2.groups.io/g/devel/message/96732
Mute This Topic: https://groups.io/mt/95355253/1945644
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
mahmoud@...]
-=-=-=-=-=-=
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


sahil
 

There is no need for a separate ID for CCIX host bridge,
therefore reusing PCIe PNP ID for CCIX.

Signed-off-by: sahil <sahil@...>
---

Notes:
v2:
- removed licence fix, to be pushed separately [Leif Lindholm]

Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 =
++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBrid=
geLib.c b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeL=
ib.c
index 1f38f654a8ce..6a154d771126 100644
--- a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
+++ b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
@@ -65,8 +65,8 @@ STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRootBridgeD=
evicePath[ROOT_COMPLEX_
(UINT8)(sizeof (ACPI_HID_DEVICE_PATH) >> 8)=0D
}=0D
},=0D
- EISA_PNP_ID(0x0A09), // CCIX=0D
- 0=0D
+ EISA_PNP_ID(0x0A08), // CCIX=0D
+ 1=0D
},=0D
{=0D
END_DEVICE_PATH_TYPE,=0D
--=20
2.25.1