Date
1 - 3 of 3
[edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call
|
Isaac Oram
Pushed as ea2a520c83..60053f3077
toggle quoted message
Show quoted text
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oram, Isaac W Sent: Friday, August 5, 2022 1:40 PM To: mikuback@...; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@...>; Desimone, Nathaniel L <nathaniel.l.desimone@...>; Gao, Liming <gaoliming@...>; Dong, Eric <eric.dong@...> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Reviewed-by: Isaac Oram <isaac.w.oram@...> -----Original Message----- From: mikuback@... <mikuback@...> Sent: Friday, August 5, 2022 11:02 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@...>; Desimone, Nathaniel L <nathaniel.l.desimone@...>; Oram, Isaac W <isaac.w.oram@...>; Gao, Liming <gaoliming@...>; Dong, Eric <eric.dong@...> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call From: Michael Kubacki <michael.kubacki@...> The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu <chasel.chiu@...> Cc: Nate DeSimone <nathaniel.l.desimone@...> Cc: Isaac Oram <isaac.w.oram@...> Cc: Liming Gao <gaoliming@...> Cc: Eric Dong <eric.dong@...> Signed-off-by: Michael Kubacki <michael.kubacki@...> --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n")); CurrentMemoryTypeInformation = NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation != NULL) && (PreviousMemoryTypeInformation != NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemoryTypeInformation); } -- 2.28.0.windows.1 |
|
|
|
Isaac Oram
Reviewed-by: Isaac Oram <isaac.w.oram@...>
toggle quoted message
Show quoted text
-----Original Message-----
From: mikuback@... <mikuback@...> Sent: Friday, August 5, 2022 11:02 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@...>; Desimone, Nathaniel L <nathaniel.l.desimone@...>; Oram, Isaac W <isaac.w.oram@...>; Gao, Liming <gaoliming@...>; Dong, Eric <eric.dong@...> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call From: Michael Kubacki <michael.kubacki@...> The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu <chasel.chiu@...> Cc: Nate DeSimone <nathaniel.l.desimone@...> Cc: Isaac Oram <isaac.w.oram@...> Cc: Liming Gao <gaoliming@...> Cc: Eric Dong <eric.dong@...> Signed-off-by: Michael Kubacki <michael.kubacki@...> --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n")); CurrentMemoryTypeInformation = NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation != NULL) && (PreviousMemoryTypeInformation != NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemoryTypeInformation); } -- 2.28.0.windows.1 |
|
|
|
Michael Kubacki
From: Michael Kubacki <michael.kubacki@...>
The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu <chasel.chiu@...> Cc: Nate DeSimone <nathaniel.l.desimone@...> Cc: Isaac Oram <isaac.w.oram@...> Cc: Liming Gao <gaoliming@...> Cc: Eric Dong <eric.dong@...> Signed-off-by: Michael Kubacki <michael.kubacki@...> --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMem= oryTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Lib= rary/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckMemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; =20 DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckMemoryTypeInformation = - Enter\n")); CurrentMemoryTypeInformation =3D NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } =20 - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation !=3D NULL) && (PreviousMemoryTypeInf= ormation !=3D NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemo= ryTypeInformation); } --=20 2.28.0.windows.1 |
|
|