Date
1 - 14 of 14
[Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi
|
Michael D Kinney
The email addresses for the reviewers of the MptScsi and
PvScsi are no longer valid. Disable the MptScsi and PvScsi drivers in all DSC files until new maintainers/reviewers can be identified. Cc: Ard Biesheuvel <ardb+tianocore@...> Cc: Jiewen Yao <jiewen.yao@...> Cc: Jordan Justen <jordan.l.justen@...> Cc: Gerd Hoffmann <kraxel@...> Cc: Sebastien Boeuf <sebastien.boeuf@...> Cc: Brijesh Singh <brijesh.singh@...> Cc: Erdem Aktas <erdemaktas@...> Cc: James Bottomley <jejb@...> Cc: Jiewen Yao <jiewen.yao@...> Cc: Min Xu <min.m.xu@...> Cc: Tom Lendacky <thomas.lendacky@...> Signed-off-by: Michael D Kinney <michael.d.kinney@...> --- OvmfPkg/AmdSev/AmdSevX64.dsc | 4 ++-- OvmfPkg/CloudHv/CloudHvX64.dsc | 4 ++-- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 4 ++-- OvmfPkg/Microvm/MicrovmX64.dsc | 4 ++-- OvmfPkg/OvmfPkgIa32.dsc | 4 ++-- OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++-- OvmfPkg/OvmfPkgX64.dsc | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index 726521c94381..90e8a213ef77 100644 --- a/OvmfPkg/AmdSev/AmdSevX64.dsc +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc @@ -43,8 +43,8 @@ [Defines] # # Device drivers # - DEFINE PVSCSI_ENABLE = TRUE - DEFINE MPT_SCSI_ENABLE = TRUE + DEFINE PVSCSI_ENABLE = FALSE + DEFINE MPT_SCSI_ENABLE = FALSE DEFINE LSI_SCSI_ENABLE = FALSE # diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc index 0bfe542f8a88..f0d700f14477 100644 --- a/OvmfPkg/CloudHv/CloudHvX64.dsc +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc @@ -49,8 +49,8 @@ [Defines] # # Device drivers # - DEFINE PVSCSI_ENABLE = TRUE - DEFINE MPT_SCSI_ENABLE = TRUE + DEFINE PVSCSI_ENABLE = FALSE + DEFINE MPT_SCSI_ENABLE = FALSE DEFINE LSI_SCSI_ENABLE = FALSE # diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc index 144d50aa9dba..71b1cf8e7090 100644 --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc @@ -34,8 +34,8 @@ [Defines] # # Device drivers # - DEFINE PVSCSI_ENABLE = TRUE - DEFINE MPT_SCSI_ENABLE = TRUE + DEFINE PVSCSI_ENABLE = FALSE + DEFINE MPT_SCSI_ENABLE = FALSE DEFINE LSI_SCSI_ENABLE = FALSE # diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc index 61db9b6e4c83..52498bbe90a8 100644 --- a/OvmfPkg/Microvm/MicrovmX64.dsc +++ b/OvmfPkg/Microvm/MicrovmX64.dsc @@ -47,8 +47,8 @@ [Defines] # # Device drivers # - DEFINE PVSCSI_ENABLE = TRUE - DEFINE MPT_SCSI_ENABLE = TRUE + DEFINE PVSCSI_ENABLE = FALSE + DEFINE MPT_SCSI_ENABLE = FALSE DEFINE LSI_SCSI_ENABLE = FALSE # diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index e708411076ca..725a01ae9a20 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc +++ b/OvmfPkg/OvmfPkgIa32.dsc @@ -50,8 +50,8 @@ [Defines] # # Device drivers # - DEFINE PVSCSI_ENABLE = TRUE - DEFINE MPT_SCSI_ENABLE = TRUE + DEFINE PVSCSI_ENABLE = FALSE + DEFINE MPT_SCSI_ENABLE = FALSE DEFINE LSI_SCSI_ENABLE = FALSE # diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index 0b036d8bb53f..adc813ba2e1e 100644 --- a/OvmfPkg/OvmfPkgIa32X64.dsc +++ b/OvmfPkg/OvmfPkgIa32X64.dsc @@ -49,8 +49,8 @@ [Defines] # # Device drivers # - DEFINE PVSCSI_ENABLE = TRUE - DEFINE MPT_SCSI_ENABLE = TRUE + DEFINE PVSCSI_ENABLE = FALSE + DEFINE MPT_SCSI_ENABLE = FALSE DEFINE LSI_SCSI_ENABLE = FALSE # diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 8ad04b50f74f..6e68f60dc90f 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -49,8 +49,8 @@ [Defines] # # Device drivers # - DEFINE PVSCSI_ENABLE = TRUE - DEFINE MPT_SCSI_ENABLE = TRUE + DEFINE PVSCSI_ENABLE = FALSE + DEFINE MPT_SCSI_ENABLE = FALSE DEFINE LSI_SCSI_ENABLE = FALSE # -- 2.32.0.windows.1 |
|
|
|
dann frazier
On Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote:
The email addresses for the reviewers of the MptScsi andHi Michael, This seems likely to be the reason for the following regression report in Debian: https://bugs.debian.org/1016359 I'm trying to decide whether or not this is something we should force back on for our users to avoid the regression, and/or if we need to actively move users off of it (mark it deprecated, etc). Do you know if there are known issues with this code, other than the lack of reviewers? Is there a plan to remove this code at some point? -dann Cc: Ard Biesheuvel <ardb+tianocore@...> |
|
|
|
Michael D Kinney
Hi Dann,
toggle quoted message
Show quoted text
The purpose of this first step was due to lack of support/maintainers/reviewers. If there are issues, then we need to find maintainers/reviewers starting with those that are using and depend on these features. If there are no issues from disabling these by default, then the 2nd step would be deleting the code and the flags. Are these features actually being used? Thanks, Mike -----Original Message----- |
|
|
|
dann frazier
On Mon, Dec 5, 2022 at 6:25 PM Kinney, Michael D
<michael.d.kinney@...> wrote: Apparently - assuming I've correctly connected the dots: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016359 |
|
|
|
Gerd Hoffmann
On Mon, Dec 05, 2022 at 04:36:15PM -0700, dann frazier wrote:
On Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote:I'm not so sure about that.The email addresses for the reviewers of the MptScsi andHi Michael, The bug report talks about lsilogic and virtio-scsi.- DEFINE PVSCSI_ENABLE = TRUE lsilogic was already disabled by default before this patch. virtio-scsi support is included and there are no plans to change that because it is a rather essential driver. It works just fine upstream, and there isn't even a config switch to disable it. take care, Gerd |
|
|
|
dann frazier
On Tue, Dec 06, 2022 at 06:56:49AM +0100, Gerd Hoffmann wrote:
On Mon, Dec 05, 2022 at 04:36:15PM -0700, dann frazier wrote:Thanks Gerd - I'll work with the users to clarify via the bug (thanksOn Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote:I'm not so sure about that.The email addresses for the reviewers of the MptScsi andHi Michael, for responding there as well btw). -dann |
|
|
|
Mike Maslenkin
Greetings All!
toggle quoted message
Show quoted text
As I can see LSI_SCSI_ENABLE related to LSI LSI_53C895A_PCI_DEVICE_ID Vid/Did 0x1000:0x0012. I guess it is some old Megaraid adapter. A patch mentioned above set MPT_SCSI_ENABLE=FALSE, that removed support for LSI 53C1030 and SAS1068. These SCSI controllers were emulated by VMware, Parallels and I guess VitualBox. This is generic setup for VMware VMs, as far as I remember. So the booting of such VMs (probably migrated from VMware and others) was definitely broken. Regards, Mike. On Tue, Dec 6, 2022 at 5:38 PM dann frazier <dann.frazier@...> wrote:
|
|
|
|
Gerd Hoffmann
Hi,
A patch mentioned above set MPT_SCSI_ENABLE=FALSE, that removedYes. Problem is there is no maintainer for the driver. There used to be one, but the email address started bouncing. So we updated Maintainers.txt and flipped the switch to not build the unmaintained drivers by default. If debian is fine with shipping unmaintained software to its users you can flip the config switches of course, at least as long as the drivers are still in the tree. The drivers are at risk of being removed though in case we don't find a new maintainer within a year or two. take care, Gerd |
|
|
|
Ard Biesheuvel
On Wed, 7 Dec 2022 at 08:41, Gerd Hoffmann <kraxel@...> wrote:
Indeed. These options can be set from the command line when building the image, so the distro wrapper scripts can just en/disable the features they desire. As for maintenance: indeed, lack of maintainership generally also means lack of testing coverage, and if something breaks, we won't notice, and if we do, we may not be able to fix it without running the risk of breaking something else. So at some point, these drivers will be removed rather than kept alive by the core team unless someone steps up. |
|
|
|
James Bottomley
On Wed, 2022-12-07 at 15:09 +0100, Ard Biesheuvel wrote:
So at some point, these drivers will be removed rather than keptHow important is keeping them alive? I can volunteer to "maintain" them which I anticipate won't be much effort (plus I'm used to looking after obsolete SCSI equipment). The hardware is obsolete, so the mechanics of their emulation isn't going to change, the only potential risk is changes in the guest to host transmission layer that breaks something. On the other hand, I've got to say I use virtio-scsi in all my VM testing environments, so the maintenance will likely only be reacting when someone else reports a problem. James |
|
|
|
Gerd Hoffmann
On Wed, Dec 07, 2022 at 09:14:39AM -0500, James Bottomley wrote:
On Wed, 2022-12-07 at 15:09 +0100, Ard Biesheuvel wrote:Most common use case is probably bootimg images created on otherSo at some point, these drivers will be removed rather than keptHow important is keeping them alive? hypervisors on qemu. Otherwise there is little reason to use something which is not virtio-scsi. I can volunteer to "maintain"Yes, I don't expect it being much effort, but knowing oldish scsi stuff certainly helps understanding the driver code if needed. If you want step up sent a patch updating Maintainers.txt accordingly. On the other hand, I've got to say I use virtio-scsi in allSame here ;) take care, Gerd |
|
|
|
Ard Biesheuvel
On Wed, 7 Dec 2022 at 17:02, Gerd Hoffmann <kraxel@...> wrote:
Thanks James, that would be very helpful. Yes, I don't expect it being much effort, but knowing oldish scsi stuffHaving the informed opinion of a domain expert should allow us to diagnose issued related to these drivers with more confidence, and also give us insight in how obsolete those drivers actually are. I can send the patch if you prefer. On the other hand, I've got to say I use virtio-scsi in allSame here ;) |
|
|
|
James Bottomley
On Wed, 2022-12-07 at 17:04 +0100, Ard Biesheuvel wrote:
On Wed, 7 Dec 2022 at 17:02, Gerd Hoffmann <kraxel@...> wrote:Sure, who can resist someone else doing all the work.Thanks James, that would be very helpful. I note we do have a maintained LSI driver: OvmfPkg/LsiScsiDxe. It seems to be based on the 53c896 which is really only a marginal subset of the 1030 ... if I'm remembering correctly the 1030 did Low Voltage Differential (so a faster SCSI Parallel bus), but since that's a SCSI Bus protocol, it should have no real impact on the utility of the emulation. Is the LsiScsiDxe usable by Debian? James |
|
|
|
dann frazier
On Wed, Dec 07, 2022 at 11:22:10AM -0500, James Bottomley wrote:
On Wed, 2022-12-07 at 17:04 +0100, Ard Biesheuvel wrote:I tried it, but it doesn't seem to enumerate any blk devices.On Wed, 7 Dec 2022 at 17:02, Gerd Hoffmann <kraxel@...> wrote:Sure, who can resist someone else doing all the work.Thanks James, that would be very helpful. The driver loads and reports that it is managing a device: Shell> drivers T D D Y C I R P F A V VERSION E G G #D #C DRIVER NAME IMAGE NAME == ======== = = = == == =================================== ========== [...] 6E 00000010 D - - 1 - LSI 53C895A SCSI Controller Driver LsiScsiDxe [...] But no blk devices. Using the same VM config and just swapping the controller from lsilogic to virtio-scsi, yields the expected blk devices. To be clear, I'm unaware of OVMF ever working with this device in Debian. -dann |
|
|