Date
1 - 5 of 5
[PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt
Ard Biesheuvel
On Sat, 18 Jun 2022 at 04:45, Rebecca Cran <rebecca@...> wrote:
Merged as #2999
|
|
Rebecca Cran
It looks like this hasn't been pushed. Could someone commit/push it please?
toggle quoted messageShow quoted text
-- Rebecca Cran
On 5/16/22 10:26, Sami Mujawar wrote:
Hi Rebecca,
|
|
Sami Mujawar
Hi Rebecca,
Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar
|
|
Rebecca Cran
Could I have some reviews of this v2 patch please?
toggle quoted messageShow quoted text
Thanks. Rebecca Cran
On 5/3/22 14:07, Rebecca Cran wrote:
The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
|
|
Rebecca Cran
The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
the console difficult, for example when using the UiApp. Since the extra output should no longer be needed, delete the DEBUG lines. Signed-off-by: Rebecca Cran <rebecca@...> --- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c index 01ec6f68bd93..013506976f91 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c @@ -815,18 +815,6 @@ LcdGraphicsBlt ( HorizontalResolution = This->Mode->Info->HorizontalResolution; VerticalResolution = This->Mode->Info->VerticalResolution; - DEBUG (( - DEBUG_INFO, - "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n", - BltOperation, - DestinationX, - DestinationY, - Width, - Height, - HorizontalResolution, - VerticalResolution - )); - // Check we have reasonable parameters if ((Width == 0) || (Height == 0)) { DEBUG ((DEBUG_ERROR, "LcdGraphicsBlt: ERROR - Invalid dimension: Zero size area.\n")); -- 2.25.1
|
|